From: b.zolnierkie@samsung.com (Bartlomiej Zolnierkiewicz)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH 1/1] ARM: exynos_defconfig: Enable SBS battery support
Date: Mon, 11 Aug 2014 14:40:38 +0200 [thread overview]
Message-ID: <1761549.yKSqfXafKr@amdc1032> (raw)
In-Reply-To: <1407755198-17568-1-git-send-email-javier.martinez@collabora.co.uk>
Hi,
On Monday, August 11, 2014 01:06:38 PM Javier Martinez Canillas wrote:
> Many Exynos5 boards (e.g: Snow, Peach Pit and Pi) have
> a SBS-compliant gas gauge battery. Enable it as module
> so the needed support is available for these boards.
>
> Suggested-by: Doug Anderson <dianders@chromium.org>
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> Acked-by: Kukjin Kim <kgene.kim@samsung.com>
> ---
> arch/arm/configs/exynos_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index fc7d168..c390bb9 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -77,6 +77,7 @@ CONFIG_SPI_S3C64XX=y
> CONFIG_I2C_S3C2410=y
> CONFIG_DEBUG_GPIO=y
> CONFIG_POWER_SUPPLY=y
> +CONFIG_BATTERY_SBS=m
Why not make it "=y"?
Rationale:
- currently no hardware related option uses "=m" in exynos_defconfig
- it would match the SBS option usage in multi_v7_defconfig
> CONFIG_CHARGER_TPS65090=y
> # CONFIG_HWMON is not set
> CONFIG_THERMAL=y
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
next prev parent reply other threads:[~2014-08-11 12:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-11 11:06 [RESEND PATCH 1/1] ARM: exynos_defconfig: Enable SBS battery support Javier Martinez Canillas
2014-08-11 12:40 ` Bartlomiej Zolnierkiewicz [this message]
2014-08-11 12:52 ` Javier Martinez Canillas
2014-08-11 15:42 ` Bartlomiej Zolnierkiewicz
2014-08-11 15:59 ` Doug Anderson
2014-08-11 16:23 ` Javier Martinez Canillas
2014-08-11 17:28 ` Bartlomiej Zolnierkiewicz
2014-08-11 17:36 ` Doug Anderson
2014-08-11 17:38 ` Javier Martinez Canillas
2014-08-11 15:13 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1761549.yKSqfXafKr@amdc1032 \
--to=b.zolnierkie@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox