From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50C0ECCF9F8 for ; Mon, 3 Nov 2025 13:57:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Message-ID:Date:To:Cc:From: Subject:References:In-Reply-To:Content-Transfer-Encoding:MIME-Version: Content-Type:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0uMrnqh5f2PZua5+dfMwABocG9MFGyjTfiH+GYTRw8g=; b=supD8AbU4cFrJZFLQIKzDE7BoU 6jV6D+fDgfSMFcbm+qgKCSh2ixw0wipgoBU/l2A+a4XhXpZLTjVJK3+HpLnVyBEdk4DigxI6yxcDc rEkf8rOPxWe1VHMenBY0BZS+h7l4a3XjdR0UA4OTiZNj8mTrv+RvSLzAcZq2pk7IP7UZpEHBBeiX+ ALx1ouKhEXugOVuxQig55bf2WF2N/jjlD3WcYNwA5aciC0ezW1cZkWGKQl7IxjU/Gx7WkQpkJY3lg uV0n9jKKbSK/fJp+qbB8xIEcug5j1T+r8mdkdJW976faS76rJz6+mM/3E9hP64sKsS00WCVQ28VN9 uIaUB+bg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vFv4C-00000009yNT-1mg9; Mon, 03 Nov 2025 13:57:52 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vFv49-00000009yMI-16Ho for linux-arm-kernel@lists.infradead.org; Mon, 03 Nov 2025 13:57:50 +0000 Received: from mail.ideasonboard.com (unknown [IPv6:2401:4900:1c69:314e:ee86:ae6e:30:9d13]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 20278C73; Mon, 3 Nov 2025 14:55:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1762178154; bh=VeGaAYfgEvSvT+Gu0xOXuZ+HjyhBKDgEePQmHngeEnA=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=j2ytfEgTTV5gfkQzV5pNcUO4KOeAYQ/HLoaNZL1QOKwj5z3Gg9pMI2JFj7Jj1CuyB uCahs2imDsznJp14QWZrzdZdC10nbJUyWc/cWt+OI+Ms4+VXOWzN+Nb6WrobxK+qWa XNLHLQ1TtaZZzuY4ePt8OqTS2AXQJWhimwdWTntc= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: <20251031-b4-vc-sm-cma-v1-0-0dd5c0ec3f5c@ideasonboard.com> <20251031-b4-vc-sm-cma-v1-13-0dd5c0ec3f5c@ideasonboard.com> Subject: Re: [PATCH 13/13] platform/raspberrypi: vchiq: Register vc-sm-cma as a platform driver From: Jai Luthra Cc: Dave Stevenson , Phil Elwell , Stefan Wahren , Laurent Pinchart , Kieran Bingham , Sumit Semwal , Christian =?utf-8?q?K=C3=B6nig?= , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org To: Florian Fainelli , Krzysztof Kozlowski , Raspberry Pi Kernel Maintenance , bcm-kernel-feedback-list@broadcom.com Date: Mon, 03 Nov 2025 19:27:41 +0530 Message-ID: <176217826196.8690.15955501577381404885@freya> User-Agent: alot/0.12.dev28+gd2c823fe X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251103_055749_437758_7E80719A X-CRM114-Status: GOOD ( 17.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Krzysztof Kozlowski (2025-11-02 15:03:55) > On 31/10/2025 18:27, Jai Luthra wrote: > > From: Dave Stevenson > >=20 > > Register the vc-sm-cma driver as a platform driver under vchiq. > >=20 > > Signed-off-by: Dave Stevenson > > Signed-off-by: Jai Luthra > > --- > > drivers/platform/raspberrypi/vchiq-interface/vchiq_arm.c | 3 +++ > > 1 file changed, 3 insertions(+) > >=20 > > diff --git a/drivers/platform/raspberrypi/vchiq-interface/vchiq_arm.c b= /drivers/platform/raspberrypi/vchiq-interface/vchiq_arm.c > > index 6a7b96d3dae6275a483ef15dc619c5510454765e..09d33bec46ec45175378fff= 8dd1084d0a8a12dd6 100644 > > --- a/drivers/platform/raspberrypi/vchiq-interface/vchiq_arm.c > > +++ b/drivers/platform/raspberrypi/vchiq-interface/vchiq_arm.c > > @@ -63,6 +63,7 @@ > > * the interface. > > */ > > static struct vchiq_device *bcm2835_audio; > > +static struct vchiq_device *vcsm_cma; >=20 > Please don't write singletons. How do you handle probe of two devices? This driver instantiates all the devices under the vchiq bus during its probe. The VCHIQ firmware doesn't support device enumeration, hence we have to list out the supported devices here. >=20 > > =20 > > static const struct vchiq_platform_info bcm2835_info =3D { > > .cache_line_size =3D 32, > > @@ -1421,6 +1422,7 @@ static int vchiq_probe(struct platform_device *pd= ev) >=20 >=20 > Best regards, > Krzysztof Thanks, Jai