linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net] net: airoha: Do not loopback traffic to GDM2 if it is available on the device
@ 2025-11-13 17:19 Lorenzo Bianconi
  2025-11-18  4:20 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Lorenzo Bianconi @ 2025-11-13 17:19 UTC (permalink / raw)
  To: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni
  Cc: linux-arm-kernel, linux-mediatek, netdev, Lorenzo Bianconi

Airoha_eth driver forwards offloaded uplink traffic (packets received on
GDM1 and forwarded to GDM{3,4}) to GDM2 in order to apply hw QoS.
This is correct if the device does not support a dedicated GDM2 port. In
this case, in order to enable hw offloading for uplink traffic, the
packets should be sent to GDM{3,4} directly.

Fixes: 9cd451d414f6 ("net: airoha: Add loopback support for GDM2")
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
---
 drivers/net/ethernet/airoha/airoha_ppe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/airoha/airoha_ppe.c b/drivers/net/ethernet/airoha/airoha_ppe.c
index c373f21d95f5a610deae365c64bc589c21f5e1a0..0caabb0c3aa06948e46ad087c50eba5babc81994 100644
--- a/drivers/net/ethernet/airoha/airoha_ppe.c
+++ b/drivers/net/ethernet/airoha/airoha_ppe.c
@@ -308,7 +308,7 @@ static int airoha_ppe_foe_entry_prepare(struct airoha_eth *eth,
 			if (!airoha_is_valid_gdm_port(eth, port))
 				return -EINVAL;
 
-			if (dsa_port >= 0)
+			if (dsa_port >= 0 || eth->ports[1])
 				pse_port = port->id == 4 ? FE_PSE_PORT_GDM4
 							 : port->id;
 			else

---
base-commit: f694d215d34035cc64b1d176fd82db0d1f2428d4
change-id: 20251113-airoha-hw-offload-gdm2-fix-29f4f8df05bf

Best regards,
-- 
Lorenzo Bianconi <lorenzo@kernel.org>



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net] net: airoha: Do not loopback traffic to GDM2 if it is available on the device
  2025-11-13 17:19 [PATCH net] net: airoha: Do not loopback traffic to GDM2 if it is available on the device Lorenzo Bianconi
@ 2025-11-18  4:20 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-11-18  4:20 UTC (permalink / raw)
  To: Lorenzo Bianconi
  Cc: andrew+netdev, davem, edumazet, kuba, pabeni, linux-arm-kernel,
	linux-mediatek, netdev

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 13 Nov 2025 18:19:38 +0100 you wrote:
> Airoha_eth driver forwards offloaded uplink traffic (packets received on
> GDM1 and forwarded to GDM{3,4}) to GDM2 in order to apply hw QoS.
> This is correct if the device does not support a dedicated GDM2 port. In
> this case, in order to enable hw offloading for uplink traffic, the
> packets should be sent to GDM{3,4} directly.
> 
> Fixes: 9cd451d414f6 ("net: airoha: Add loopback support for GDM2")
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> 
> [...]

Here is the summary with links:
  - [net] net: airoha: Do not loopback traffic to GDM2 if it is available on the device
    https://git.kernel.org/netdev/net/c/8e0a754b0836

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-11-18  4:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-13 17:19 [PATCH net] net: airoha: Do not loopback traffic to GDM2 if it is available on the device Lorenzo Bianconi
2025-11-18  4:20 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).