* [PATCH v5 0/4] Patches to add support for Rockchip dwc2 controller
@ 2014-08-08 3:55 Kever Yang
2014-08-08 3:55 ` [PATCH v5 3/4] ARM: dts: add rk3288 dwc2 controller support Kever Yang
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Kever Yang @ 2014-08-08 3:55 UTC (permalink / raw)
To: linux-arm-kernel
These patches to add support for dwc2 controller found in
Rockchip processors rk3066, rk3188 and rk3288,
and enable dts for rk3288 evb.
Changes in v5:
- max_transfer_size change to 65535 to met the requirement of
header file
- change the sort order of dwc2 in rk3288.dtsi
- don't enable otg port for evb
Changes in v4:
- max_transfer_size change to 65536, this should be enough
for most transfer, the hardware auto-detect will set this
to 0x7ffff which may make dma_alloc_coherent fail when
non-dword aligned buf from driver like usbnet happen.
- remove EHCI and HSIC dts patch for Doug had post it seprately.
Changes in v3:
- EHCI and HSIC move new for version 3.
- Rebase
Changes in v2:
- Split out dr_mode and rk3288 bindings.
- add compatible "snps,dwc2" bingding info
- set most parameters as driver auto-detect
- evb patch added in version 2
Kever Yang (4):
Documentation: dt-bindings: add dt binding info for Rockchip dwc2
usb: dwc2: add compatible data for rockchip soc
ARM: dts: add rk3288 dwc2 controller support
ARM: dts: Enable USB host1(dwc) on rk3288-evb
Documentation/devicetree/bindings/usb/dwc2.txt | 3 +++
arch/arm/boot/dts/rk3288-evb.dtsi | 4 ++++
arch/arm/boot/dts/rk3288.dtsi | 20 ++++++++++++++++++
drivers/usb/dwc2/platform.c | 29 ++++++++++++++++++++++++++
4 files changed, 56 insertions(+)
--
1.9.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v5 3/4] ARM: dts: add rk3288 dwc2 controller support
2014-08-08 3:55 [PATCH v5 0/4] Patches to add support for Rockchip dwc2 controller Kever Yang
@ 2014-08-08 3:55 ` Kever Yang
2014-08-08 15:45 ` Doug Anderson
2014-08-08 3:55 ` [PATCH v5 4/4] ARM: dts: Enable USB host1(dwc) on rk3288-evb Kever Yang
2014-09-08 18:43 ` [PATCH v5 0/4] Patches to add support for Rockchip dwc2 controller Heiko Stübner
2 siblings, 1 reply; 8+ messages in thread
From: Kever Yang @ 2014-08-08 3:55 UTC (permalink / raw)
To: linux-arm-kernel
rk3288 has two kind of usb controller, this add the dwc2 controller
for otg and host1.
Controller can works with usb PHY default setting and Vbus on.
Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
Reviewed-by: Doug Anderson <dianders@chromium.org>
Tested-by: Doug Anderson <dianders@chromium.org>
---
Changes in v5:
- change the sort order of dwc2 in rk3288.dtsi
Changes in v4: None
Changes in v3:
- EHCI and HSIC move new for version 3.
Changes in v2: None
arch/arm/boot/dts/rk3288.dtsi | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
index 5950b0a..58167f1 100644
--- a/arch/arm/boot/dts/rk3288.dtsi
+++ b/arch/arm/boot/dts/rk3288.dtsi
@@ -206,6 +206,26 @@
/* NOTE: ohci at ff520000 doesn't actually work on hardware */
+ usb_host1: usb at ff540000 {
+ compatible = "rockchip,rk3288-usb", "rockchip,rk3066-usb",
+ "snps,dwc2";
+ reg = <0xff540000 0x40000>;
+ interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cru HCLK_USBHOST1>;
+ clock-names = "otg";
+ status = "disabled";
+ };
+
+ usb_otg: usb at ff580000 {
+ compatible = "rockchip,rk3288-usb", "rockchip,rk3066-usb",
+ "snps,dwc2";
+ reg = <0xff580000 0x40000>;
+ interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cru HCLK_OTG0>;
+ clock-names = "otg";
+ status = "disabled";
+ };
+
usb_hsic: usb at ff5c0000 {
compatible = "generic-ehci";
reg = <0xff5c0000 0x100>;
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v5 3/4] ARM: dts: add rk3288 dwc2 controller support
2014-08-08 3:55 ` [PATCH v5 3/4] ARM: dts: add rk3288 dwc2 controller support Kever Yang
@ 2014-08-08 15:45 ` Doug Anderson
2014-08-08 15:53 ` Heiko Stübner
0 siblings, 1 reply; 8+ messages in thread
From: Doug Anderson @ 2014-08-08 15:45 UTC (permalink / raw)
To: linux-arm-kernel
Kever,
On Thu, Aug 7, 2014 at 8:55 PM, Kever Yang <kever.yang@rock-chips.com> wrote:
> rk3288 has two kind of usb controller, this add the dwc2 controller
> for otg and host1.
>
> Controller can works with usb PHY default setting and Vbus on.
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> Reviewed-by: Doug Anderson <dianders@chromium.org>
> Tested-by: Doug Anderson <dianders@chromium.org>
> ---
>
> Changes in v5:
> - change the sort order of dwc2 in rk3288.dtsi
>
> Changes in v4: None
> Changes in v3:
> - EHCI and HSIC move new for version 3.
>
> Changes in v2: None
>
> arch/arm/boot/dts/rk3288.dtsi | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
IMHO this series is ready to go in for 3.18. I'm assuming Heiko will
pick it up once the bindings have landed. It already has my tags. ;)
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v5 3/4] ARM: dts: add rk3288 dwc2 controller support
2014-08-08 15:45 ` Doug Anderson
@ 2014-08-08 15:53 ` Heiko Stübner
2014-09-09 8:09 ` Heiko Stübner
0 siblings, 1 reply; 8+ messages in thread
From: Heiko Stübner @ 2014-08-08 15:53 UTC (permalink / raw)
To: linux-arm-kernel
Am Freitag, 8. August 2014, 08:45:16 schrieb Doug Anderson:
> Kever,
>
> On Thu, Aug 7, 2014 at 8:55 PM, Kever Yang <kever.yang@rock-chips.com>
wrote:
> > rk3288 has two kind of usb controller, this add the dwc2 controller
> > for otg and host1.
> >
> > Controller can works with usb PHY default setting and Vbus on.
> >
> > Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> > Reviewed-by: Doug Anderson <dianders@chromium.org>
> > Tested-by: Doug Anderson <dianders@chromium.org>
> > ---
> >
> > Changes in v5:
> > - change the sort order of dwc2 in rk3288.dtsi
> >
> > Changes in v4: None
> > Changes in v3:
> > - EHCI and HSIC move new for version 3.
> >
> > Changes in v2: None
> >
> > arch/arm/boot/dts/rk3288.dtsi | 20 ++++++++++++++++++++
> > 1 file changed, 20 insertions(+)
>
> IMHO this series is ready to go in for 3.18. I'm assuming Heiko will
> pick it up once the bindings have landed. It already has my tags. ;)
correct ... the dts changes look ok, so I'll take patches 3 and 4 once patches
1 and 2 are included somewhere.
Heiko
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v5 3/4] ARM: dts: add rk3288 dwc2 controller support
2014-08-08 15:53 ` Heiko Stübner
@ 2014-09-09 8:09 ` Heiko Stübner
0 siblings, 0 replies; 8+ messages in thread
From: Heiko Stübner @ 2014-09-09 8:09 UTC (permalink / raw)
To: linux-arm-kernel
Am Freitag, 8. August 2014, 17:53:45 schrieb Heiko St?bner:
> Am Freitag, 8. August 2014, 08:45:16 schrieb Doug Anderson:
> > Kever,
> >
> > On Thu, Aug 7, 2014 at 8:55 PM, Kever Yang <kever.yang@rock-chips.com>
>
> wrote:
> > > rk3288 has two kind of usb controller, this add the dwc2 controller
> > > for otg and host1.
> > >
> > > Controller can works with usb PHY default setting and Vbus on.
> > >
> > > Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> > > Reviewed-by: Doug Anderson <dianders@chromium.org>
> > > Tested-by: Doug Anderson <dianders@chromium.org>
> > > ---
> > >
> > > Changes in v5:
> > > - change the sort order of dwc2 in rk3288.dtsi
> > >
> > > Changes in v4: None
> > > Changes in v3:
> > > - EHCI and HSIC move new for version 3.
> > >
> > > Changes in v2: None
> > >
> > > arch/arm/boot/dts/rk3288.dtsi | 20 ++++++++++++++++++++
> > > 1 file changed, 20 insertions(+)
> >
> > IMHO this series is ready to go in for 3.18. I'm assuming Heiko will
> > pick it up once the bindings have landed. It already has my tags. ;)
>
> correct ... the dts changes look ok, so I'll take patches 3 and 4 once
> patches 1 and 2 are included somewhere.
>
I've added patches 3 and 4 to my v3.18-next/dts branch
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v5 4/4] ARM: dts: Enable USB host1(dwc) on rk3288-evb
2014-08-08 3:55 [PATCH v5 0/4] Patches to add support for Rockchip dwc2 controller Kever Yang
2014-08-08 3:55 ` [PATCH v5 3/4] ARM: dts: add rk3288 dwc2 controller support Kever Yang
@ 2014-08-08 3:55 ` Kever Yang
2014-08-08 15:46 ` Doug Anderson
2014-09-08 18:43 ` [PATCH v5 0/4] Patches to add support for Rockchip dwc2 controller Heiko Stübner
2 siblings, 1 reply; 8+ messages in thread
From: Kever Yang @ 2014-08-08 3:55 UTC (permalink / raw)
To: linux-arm-kernel
USB host1 port is the host A port nearby the otg port.
Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
---
Changes in v5:
- don't enable otg port for evb
Changes in v4: None
Changes in v3:
- Rebase
Changes in v2:
- evb patch added in version 2
arch/arm/boot/dts/rk3288-evb.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi b/arch/arm/boot/dts/rk3288-evb.dtsi
index 4f57209..4b62df6 100644
--- a/arch/arm/boot/dts/rk3288-evb.dtsi
+++ b/arch/arm/boot/dts/rk3288-evb.dtsi
@@ -94,3 +94,7 @@
&usb_host0_ehci {
status = "okay";
};
+
+&usb_host1 {
+ status = "okay";
+};
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v5 4/4] ARM: dts: Enable USB host1(dwc) on rk3288-evb
2014-08-08 3:55 ` [PATCH v5 4/4] ARM: dts: Enable USB host1(dwc) on rk3288-evb Kever Yang
@ 2014-08-08 15:46 ` Doug Anderson
0 siblings, 0 replies; 8+ messages in thread
From: Doug Anderson @ 2014-08-08 15:46 UTC (permalink / raw)
To: linux-arm-kernel
Kever,
On Thu, Aug 7, 2014 at 8:55 PM, Kever Yang <kever.yang@rock-chips.com> wrote:
> USB host1 port is the host A port nearby the otg port.
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
>
> ---
>
> Changes in v5:
> - don't enable otg port for evb
>
> Changes in v4: None
> Changes in v3:
> - Rebase
>
> Changes in v2:
> - evb patch added in version 2
>
> arch/arm/boot/dts/rk3288-evb.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
IMHO this series is ready to go in for 3.18. I'm assuming Heiko will
pick it up once the bindings have landed.
Reviewed-by: Doug Anderson <dianders@chromium.org>
Tested-by: Doug Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v5 0/4] Patches to add support for Rockchip dwc2 controller
2014-08-08 3:55 [PATCH v5 0/4] Patches to add support for Rockchip dwc2 controller Kever Yang
2014-08-08 3:55 ` [PATCH v5 3/4] ARM: dts: add rk3288 dwc2 controller support Kever Yang
2014-08-08 3:55 ` [PATCH v5 4/4] ARM: dts: Enable USB host1(dwc) on rk3288-evb Kever Yang
@ 2014-09-08 18:43 ` Heiko Stübner
2 siblings, 0 replies; 8+ messages in thread
From: Heiko Stübner @ 2014-09-08 18:43 UTC (permalink / raw)
To: linux-arm-kernel
Hi Greg,
Am Freitag, 8. August 2014, 11:55:55 schrieb Kever Yang:
> These patches to add support for dwc2 controller found in
> Rockchip processors rk3066, rk3188 and rk3288,
> and enable dts for rk3288 evb.
will you take patches 1 and 2?
Thanks
Heiko
>
> Changes in v5:
> - max_transfer_size change to 65535 to met the requirement of
> header file
> - change the sort order of dwc2 in rk3288.dtsi
> - don't enable otg port for evb
>
> Changes in v4:
> - max_transfer_size change to 65536, this should be enough
> for most transfer, the hardware auto-detect will set this
> to 0x7ffff which may make dma_alloc_coherent fail when
> non-dword aligned buf from driver like usbnet happen.
> - remove EHCI and HSIC dts patch for Doug had post it seprately.
>
> Changes in v3:
> - EHCI and HSIC move new for version 3.
> - Rebase
>
> Changes in v2:
> - Split out dr_mode and rk3288 bindings.
> - add compatible "snps,dwc2" bingding info
> - set most parameters as driver auto-detect
> - evb patch added in version 2
>
> Kever Yang (4):
> Documentation: dt-bindings: add dt binding info for Rockchip dwc2
> usb: dwc2: add compatible data for rockchip soc
> ARM: dts: add rk3288 dwc2 controller support
> ARM: dts: Enable USB host1(dwc) on rk3288-evb
>
> Documentation/devicetree/bindings/usb/dwc2.txt | 3 +++
> arch/arm/boot/dts/rk3288-evb.dtsi | 4 ++++
> arch/arm/boot/dts/rk3288.dtsi | 20 ++++++++++++++++++
> drivers/usb/dwc2/platform.c | 29
> ++++++++++++++++++++++++++ 4 files changed, 56 insertions(+)
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-09-09 8:09 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-08 3:55 [PATCH v5 0/4] Patches to add support for Rockchip dwc2 controller Kever Yang
2014-08-08 3:55 ` [PATCH v5 3/4] ARM: dts: add rk3288 dwc2 controller support Kever Yang
2014-08-08 15:45 ` Doug Anderson
2014-08-08 15:53 ` Heiko Stübner
2014-09-09 8:09 ` Heiko Stübner
2014-08-08 3:55 ` [PATCH v5 4/4] ARM: dts: Enable USB host1(dwc) on rk3288-evb Kever Yang
2014-08-08 15:46 ` Doug Anderson
2014-09-08 18:43 ` [PATCH v5 0/4] Patches to add support for Rockchip dwc2 controller Heiko Stübner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).