From: Stephen Boyd <sboyd@kernel.org>
To: Haotian Zhang <vulab@iscas.ac.cn>,
angelogioacchino.delregno@collabora.com, matthias.bgg@gmail.com,
mturquette@baylibre.com
Cc: nfraprado@collabora.com, laura.nao@collabora.com,
wenst@chromium.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Haotian Zhang <vulab@iscas.ac.cn>
Subject: Re: [PATCH] clk: mediatek: Fix error handling in runtime PM setup
Date: Thu, 22 Jan 2026 18:47:03 -0700 [thread overview]
Message-ID: <176913282359.4027.16928737563389647276@lazor> (raw)
In-Reply-To: <20251123154315.1564-1-vulab@iscas.ac.cn>
Quoting Haotian Zhang (2025-11-23 08:43:15)
> devm_pm_runtime_enable() can fail due to memory allocation. The current
> code ignores its return value, and when pm_runtime_resume_and_get() fails,
> it returns directly without unmapping the shared_io region.
>
> Add error handling for devm_pm_runtime_enable(). Reorder cleanup labels
> to properly unmap shared_io on pm_runtime_resume_and_get() failure.
>
> Fixes: 2f7b1d8b5505 ("clk: mediatek: Do a runtime PM get on controllers during probe")
> Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
> ---
Applied to clk-next
prev parent reply other threads:[~2026-01-23 1:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-23 15:43 [PATCH] clk: mediatek: Fix error handling in runtime PM setup Haotian Zhang
2025-11-24 8:47 ` AngeloGioacchino Del Regno
2026-01-23 1:47 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176913282359.4027.16928737563389647276@lazor \
--to=sboyd@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=laura.nao@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mturquette@baylibre.com \
--cc=nfraprado@collabora.com \
--cc=vulab@iscas.ac.cn \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox