From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4E7FC76186 for ; Wed, 24 Jul 2019 22:38:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 68A132189F for ; Wed, 24 Jul 2019 22:38:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JfxmQVFP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 68A132189F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Dblfp1WSBb2dRk/BQ9xWFjFXEJqlRtxN1QYUFF7afu8=; b=JfxmQVFPPupoaO nekXkaPgRCAiFqh+tq/JL3wBJoDEch7AkQO7JuAZ3YNrftwU9FdgFVhw4FFO9yOosQOpMR2y+BaAy P/zMnyvYMU+EXYGMJxgxqFHmsadOWEJ3c+V36IYW8LJJ/m7gJAaxRHcLbNX/QYxsNtLkVmaWFgSQ4 N55dQk0bqCpU74k5SFSt1loLV1UgTWy0jBE0J+Cx2WGq9pxgSJwdp7XQxBQR3E1HqUrZGS2cmEhON TH3x5E+++8MKvCpSrz2mkUABl0696q6waJsI0MJjBfCg2xWZJDj2lm6nlzfWI/NeAj0tjk0ZC+l8x /JHgb4ipAmwoIF4VPJEQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hqPto-0006S2-4M; Wed, 24 Jul 2019 22:38:16 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hqPtl-0006RL-6m; Wed, 24 Jul 2019 22:38:14 +0000 Received: from d57e23da.static.ziggozakelijk.nl ([213.126.35.218] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hqPte-0005Vm-0y; Thu, 25 Jul 2019 00:38:06 +0200 From: Heiko Stuebner To: Doug Anderson Subject: Re: [PATCH v2 2/2] ARM: dts: rockchip: consolidate veyron panel and backlight settings Date: Thu, 25 Jul 2019 00:38:05 +0200 Message-ID: <1769449.YPoKHCOSj6@phil> In-Reply-To: References: <20190711223455.12210-1-mka@chromium.org> <20190711223455.12210-2-mka@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190724_153813_401619_201F89C4 X-CRM114-Status: GOOD ( 16.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Rob Herring , "open list:ARM/Rockchip SoC..." , Matthias Kaehlcke , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Mittwoch, 24. Juli 2019, 23:46:30 CEST schrieb Doug Anderson: > Hi, > > On Thu, Jul 11, 2019 at 3:35 PM Matthias Kaehlcke wrote: > > > > diff --git a/arch/arm/boot/dts/rk3288-veyron-minnie.dts b/arch/arm/boot/dts/rk3288-veyron-minnie.dts > > index 4cc7d3659484..2b0801a539c9 100644 > > --- a/arch/arm/boot/dts/rk3288-veyron-minnie.dts > > +++ b/arch/arm/boot/dts/rk3288-veyron-minnie.dts > > @@ -15,40 +15,6 @@ > > "google,veyron-minnie-rev0", "google,veyron-minnie", > > "google,veyron", "rockchip,rk3288"; > > > > - backlight_regulator: backlight-regulator { > > - compatible = "regulator-fixed"; > > - enable-active-high; > > - gpio = <&gpio2 RK_PB4 GPIO_ACTIVE_HIGH>; > > - pinctrl-names = "default"; > > - pinctrl-0 = <&bl_pwr_en>; > > - regulator-name = "backlight_regulator"; > > - vin-supply = <&vcc33_sys>; > > - startup-delay-us = <15000>; > > - }; > > - > > - panel_regulator: panel-regulator { > > - compatible = "regulator-fixed"; > > - enable-active-high; > > - gpio = <&gpio7 RK_PB6 GPIO_ACTIVE_HIGH>; > > - pinctrl-names = "default"; > > - pinctrl-0 = <&lcd_enable_h>; > > - regulator-name = "panel_regulator"; > > - startup-delay-us = <100000>; > > - vin-supply = <&vcc33_sys>; > > - }; > > - > > - vcc18_lcd: vcc18-lcd { > > - compatible = "regulator-fixed"; > > - enable-active-high; > > - gpio = <&gpio2 RK_PB5 GPIO_ACTIVE_HIGH>; > > - pinctrl-names = "default"; > > - pinctrl-0 = <&avdd_1v8_disp_en>; > > - regulator-name = "vcc18_lcd"; > > - regulator-always-on; > > - regulator-boot-on; > > - vin-supply = <&vcc18_wl>; > > - }; > > - > > volume_buttons: volume-buttons { > > compatible = "gpio-keys"; > > pinctrl-names = "default"; > > You forgot to remove the line: > > power-supply = <&backlight_regulator>; > > ...from minnie. > > > > diff --git a/arch/arm/boot/dts/rk3288-veyron-pinky.dts b/arch/arm/boot/dts/rk3288-veyron-pinky.dts > > index 9b6f4d9b03b6..06af58e37a4b 100644 > > --- a/arch/arm/boot/dts/rk3288-veyron-pinky.dts > > +++ b/arch/arm/boot/dts/rk3288-veyron-pinky.dts > > @@ -14,7 +14,14 @@ > > compatible = "google,veyron-pinky-rev2", "google,veyron-pinky", > > "google,veyron", "rockchip,rk3288"; > > > > + /delete-node/backlight-regulator; > > + /delete-node/panel-regulator; > > /delete-node/emmc-pwrseq; > > + /delete-node/vcc18-lcd; > > +}; > > + > > +&backlight { > > + /delete-property/power-supply; > > }; > > > > &emmc { > > @@ -52,7 +59,17 @@ > > i2c-scl-rising-time-ns = <300>; > > }; > > > > +&panel { > > + power-supply= <&vcc33_lcd>; > > Might as well put a space before the "="? > > > > &pinctrl { > > + /delete-node/ lcd; > > + > > + backlight { > > + /delete-node/ bl_pwr_en; > > + }; > > I general as the defender of "pinky", I'll let Heiko confirm he's OK > with the color of this bikeshed. Sometimes a bit of repetition is > preferred over a bunch of confusing /delete-node/ statements since > those tend to make things harder to reason about in general. In this > case I think things are cleaner after your patch but I won't say it's > 100% clear cut. going this way with the delete-nodes looks good to me :-) ... pinky is the "odd" one in that, so I think it can carry the burden ... especially as you said, this really only affects me and my boardfarm at all ;-) . Heiko > > Other than nits I have double-checked this patch, so feel free to add > my Reviewed-by after nits are fixed. > > -Doug > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel