From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37F32C27C4F for ; Fri, 21 Jun 2024 09:50:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cyfaSQ6eFZVMLkaj8s8+3BNIFVscPlhDWCl8BE7Fw08=; b=sAtKy8Ej+xCY7qDWVkd+PGzfgR DFOPMfZtZPVdq4i7hWK8JIDj3M0uxkEOaOKXJYKbTdduPlClxNJB5tYaEANKdjxwL2UB4vmHHYnpx capxkjsk+Pkow9racuu9g2Qh5Z3iR4FNO6492eW9w+0ioAJ9KySgeNoIHNFFZXeQ0vm+sspsGgygn cK1u5Y+ihhQiHUmeLo2MB4+6Jz7Vo0qsgsuVi52oe6qeOg8FIUAht64b3jE++BQPB645ynlR6SKXp ab1fQf2k7Go4yzPl30S7DDvYDLFL/1/TCWYDR+8BC47LZR+wKJDnOdDLIKaJ59QoRFbaTT2/Dme5Y Q6YXU4Vw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKauH-00000008d2R-2uHH; Fri, 21 Jun 2024 09:50:09 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKauE-00000008d16-2f7J; Fri, 21 Jun 2024 09:50:07 +0000 Received: from i5e8616cf.versanet.de ([94.134.22.207] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sKatj-0000eb-JF; Fri, 21 Jun 2024 11:49:35 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Daniel Golle , Aurelien Jarno , Olivia Mackall , Herbert Xu , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= , Sebastian Reichel , Anand Moon , Dragan Simic , Sascha Hauer , Martin Kaiser , Ard Biesheuvel , linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Diederik de Haas Cc: Daniel Golle Subject: Re: [PATCH v3 3/3] arm64: dts: rockchip: add DT entry for RNG to RK356x Date: Fri, 21 Jun 2024 11:49:33 +0200 Message-ID: <1772829.KUTt5R2Mg1@diego> In-Reply-To: <5870442.3KgWVfgXFx@bagend> References: <5870442.3KgWVfgXFx@bagend> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240621_025006_710934_063FF948 X-CRM114-Status: GOOD ( 16.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Freitag, 21. Juni 2024, 11:36:45 CEST schrieb Diederik de Haas: > On Friday, 21 June 2024 03:25:30 CEST Daniel Golle wrote: > > diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi > > b/arch/arm64/boot/dts/rockchip/rk356x.dtsi index d8543b5557ee..57c8103500ea > > 100644 > > --- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi > > +++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi > > @@ -1855,6 +1855,15 @@ usb2phy1_otg: otg-port { > > }; > > }; > > > > + rng: rng@fe388000 { > > + compatible = "rockchip,rk3568-rng"; > > + reg = <0x0 0xfe388000 0x0 0x4000>; > > + clocks = <&cru CLK_TRNG_NS>, <&cru HCLK_TRNG_NS>; > > + clock-names = "core", "ahb"; > > + resets = <&cru SRST_TRNG_NS>; > > + reset-names = "reset"; > > + }; > > + > > pinctrl: pinctrl { > > compatible = "rockchip,rk3568-pinctrl"; > > rockchip,grf = <&grf>; > > -- > > I had placed the node between ``sdhci: mmc@fe310000`` and > ``i2s0_8ch: i2s@fe400000`` which I think is the proper order. correct. If a node has an address in its name, sort by that address.