From: t.figa@samsung.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] arm: dt: Exynos5420: populate cpu node enteries to 8 cpus
Date: Thu, 05 Sep 2013 12:10:26 +0200 [thread overview]
Message-ID: <1772890.cJdvnBcfyj@amdc1227> (raw)
In-Reply-To: <CANuQgHGSAGhA_LzU1aP05J86wjjS0qibPTXZM8ka0O3jZz8Kpw@mail.gmail.com>
On Thursday 05 of September 2013 15:33:17 Chander Kashyap wrote:
> Hi Tomasz,
>
> On 5 September 2013 15:25, Tomasz Figa <t.figa@samsung.com> wrote:
> > Hi Chander,
> >
> > On Thursday 05 of September 2013 14:54:46 Chander Kashyap wrote:
> >> Exynos5420 is octacore SoC from samsung.
> >> Hence populate all the cpu node enteries.
> >>
> >> Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org>
> >> ---
> >>
> >> arch/arm/boot/dts/exynos5420.dtsi | 28 ++++++++++++++++++++++++++++
> >> 1 file changed, 28 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/exynos5420.dtsi
> >> b/arch/arm/boot/dts/exynos5420.dtsi index e97c87b..59489f6 100644
> >> --- a/arch/arm/boot/dts/exynos5420.dtsi
> >> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> >> @@ -57,6 +57,34 @@
> >>
> >> reg = <0x3>;
> >> clock-frequency = <1800000000>;
> >>
> >> };
> >>
> >> +
> >> + cpu4: cpu at 4 {
> >
> > I believe this is a typo. The @unit-address suffix should match the
> > value of reg property.
>
> No this is not typo. It is the MPIDR value of the cpu. (24 bits of
> MPIDR register).
Right. This is what the reg property should be set to. However, the @unit-
address prefix of node name should match the value of reg property, so if
the value of reg property is 0x100, then the node should be named cpu at 100.
Best regards,
Tomasz
next prev parent reply other threads:[~2013-09-05 10:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-05 9:24 [PATCH 0/2] Enable all cpus in Exynos5420 Chander Kashyap
2013-09-05 9:24 ` [PATCH 1/2] clocksource: mct: extend mct to support 8 local interrupts for Exynos5420 Chander Kashyap
2013-09-05 9:24 ` [PATCH 2/2] arm: dt: Exynos5420: populate cpu node enteries to 8 cpus Chander Kashyap
2013-09-05 9:55 ` Tomasz Figa
2013-09-05 10:03 ` Chander Kashyap
2013-09-05 10:10 ` Tomasz Figa [this message]
2013-09-05 10:15 ` Chander Kashyap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1772890.cJdvnBcfyj@amdc1227 \
--to=t.figa@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox