* Build failure: shmobile drm driver references backlight symbols
@ 2013-10-29 10:04 Russell King - ARM Linux
2013-10-29 17:20 ` Laurent Pinchart
2013-10-29 17:20 ` [PATCH] drm: shmobile: Add dependency on BACKLIGHT_CLASS_DEVICE Laurent Pinchart
0 siblings, 2 replies; 3+ messages in thread
From: Russell King - ARM Linux @ 2013-10-29 10:04 UTC (permalink / raw)
To: linux-arm-kernel
My build system picked up on this failure:
drivers/built-in.o: In function `shmob_drm_backlight_init':
fmc-chardev.c:(.text+0x9f2d0): undefined reference to `backlight_device_register'
drivers/built-in.o: In function `shmob_drm_backlight_exit':
fmc-chardev.c:(.text+0x9f370): undefined reference to `backlight_device_unregister'
which is cuased by drivers/gpu/drm/shmobile/shmob_drm_backlight.c being
built without the backlight dependency being enabled. It looks like
the backlight dependency is a hard requirement, so needs ot be added
to the Kconfig entry for this driver in some way.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Build failure: shmobile drm driver references backlight symbols
2013-10-29 10:04 Build failure: shmobile drm driver references backlight symbols Russell King - ARM Linux
@ 2013-10-29 17:20 ` Laurent Pinchart
2013-10-29 17:20 ` [PATCH] drm: shmobile: Add dependency on BACKLIGHT_CLASS_DEVICE Laurent Pinchart
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2013-10-29 17:20 UTC (permalink / raw)
To: linux-arm-kernel
Hi Russell,
On Tuesday 29 October 2013 10:04:13 Russell King - ARM Linux wrote:
> My build system picked up on this failure:
>
> drivers/built-in.o: In function `shmob_drm_backlight_init':
> fmc-chardev.c:(.text+0x9f2d0): undefined reference to
> `backlight_device_register' drivers/built-in.o: In function
> `shmob_drm_backlight_exit':
> fmc-chardev.c:(.text+0x9f370): undefined reference to
> `backlight_device_unregister'
>
> which is cuased by drivers/gpu/drm/shmobile/shmob_drm_backlight.c being
> built without the backlight dependency being enabled. It looks like
> the backlight dependency is a hard requirement, so needs ot be added
> to the Kconfig entry for this driver in some way.
Thank you for the report. I'll send a fix.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] drm: shmobile: Add dependency on BACKLIGHT_CLASS_DEVICE
2013-10-29 10:04 Build failure: shmobile drm driver references backlight symbols Russell King - ARM Linux
2013-10-29 17:20 ` Laurent Pinchart
@ 2013-10-29 17:20 ` Laurent Pinchart
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2013-10-29 17:20 UTC (permalink / raw)
To: linux-arm-kernel
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
The driver registers a backlight device and thus requires
BACKLIGHT_CLASS_DEVICE to be selected to avoid compilation breakages.
Cc: stable at vger.kernel.org
Reported-by: Russell King <linux@arm.linux.org.uk>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
drivers/gpu/drm/shmobile/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/shmobile/Kconfig b/drivers/gpu/drm/shmobile/Kconfig
index ca498d1..5240690 100644
--- a/drivers/gpu/drm/shmobile/Kconfig
+++ b/drivers/gpu/drm/shmobile/Kconfig
@@ -1,6 +1,7 @@
config DRM_SHMOBILE
tristate "DRM Support for SH Mobile"
depends on DRM && (ARM || SUPERH)
+ select BACKLIGHT_CLASS_DEVICE
select DRM_KMS_HELPER
select DRM_KMS_CMA_HELPER
select DRM_GEM_CMA_HELPER
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-10-29 17:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-29 10:04 Build failure: shmobile drm driver references backlight symbols Russell King - ARM Linux
2013-10-29 17:20 ` Laurent Pinchart
2013-10-29 17:20 ` [PATCH] drm: shmobile: Add dependency on BACKLIGHT_CLASS_DEVICE Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).