From: icenowy@aosc.xyz (Icenowy Zheng)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] phy: sun4i: check PHY id when poking unknown bit of pmu
Date: Tue, 25 Oct 2016 11:32:44 +0800 [thread overview]
Message-ID: <1773661477366364@web4j.yandex.ru> (raw)
In-Reply-To: <20161024082802.ev72szwmuqba5ll4@lukather>
> On Mon, Oct 24, 2016 at 11:59:30AM +0800, Icenowy Zheng wrote:
>
>> Allwinner SoC's PHY 0, when used as OTG controller, have no pmu part.
>> The code that poke some unknown bit of PMU for H3/A64 didn't check
>> the PHY, and will cause kernel oops when PHY 0 is used.
>>
>> Fixes: b3e0d141ca9f (phy: sun4i: add support for A64 usb phy)
>>
>> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
>
> Cc'ing stable would be nice.
Yes... As it's also used by H3...
>
> Apart from that, Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
If I change it to check whether phy->pmu is null, will you keep the ACK?
>
> Thanks!
> Maxime
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
next prev parent reply other threads:[~2016-10-25 3:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 3:59 [PATCH 1/3] phy: sun4i: check PHY id when poking unknown bit of pmu Icenowy Zheng
2016-10-24 6:45 ` [linux-sunxi] " Ondřej Jirman
2016-10-24 8:28 ` Maxime Ripard
2016-10-25 3:32 ` Icenowy Zheng [this message]
2016-10-25 10:43 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1773661477366364@web4j.yandex.ru \
--to=icenowy@aosc.xyz \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox