From: Stephen Boyd <sboyd@kernel.org>
To: "Chema Casanova" <jmcasanova@igalia.com>,
"Dave Stevenson" <dave.stevenson@raspberrypi.com>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Iago Toral Quiroga" <itoral@igalia.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Maíra Canal" <mcanal@igalia.com>,
"Melissa Wen" <mwen@igalia.com>,
"Michael Turquette" <mturquette@baylibre.com>,
"Nicolas Saenz Julienne" <nsaenz@kernel.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Stefan Wahren" <wahrenst@gmx.net>
Cc: linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
kernel-dev@igalia.com, "Maíra Canal" <mcanal@igalia.com>
Subject: Re: [PATCH v7 1/5] clk: bcm: rpi: Manage clock rate in prepare/unprepare callbacks
Date: Tue, 24 Mar 2026 19:06:48 -0700 [thread overview]
Message-ID: <177440440896.5403.6955660705156176314@localhost.localdomain> (raw)
In-Reply-To: <20260312-v3d-power-management-v7-1-9f006a1d4c55@igalia.com>
Quoting Maíra Canal (2026-03-12 14:34:23)
> On current firmware versions, RPI_FIRMWARE_SET_CLOCK_STATE doesn't
> actually power off the clock. To achieve meaningful power savings, the
> clock rate must be set to the minimum before disabling. This might be
> fixed in future firmware releases.
>
> Rather than pushing rate management to clock consumers, handle it
> directly in the clock framework's prepare/unprepare callbacks. In
> unprepare, set the rate to the minimum before disabling the clock.
> In prepare, for clocks marked with `maximize` (currently v3d),
> restore the rate to the maximum after enabling.
>
> Signed-off-by: Maíra Canal <mcanal@igalia.com>
> ---
Applied to clk-next
next prev parent reply other threads:[~2026-03-25 2:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 21:34 [PATCH v7 0/5] Power Management for Raspberry Pi V3D GPU Maíra Canal
2026-03-12 21:34 ` [PATCH v7 1/5] clk: bcm: rpi: Manage clock rate in prepare/unprepare callbacks Maíra Canal
2026-03-16 12:16 ` Maxime Ripard
2026-03-24 0:23 ` Stephen Boyd
2026-03-24 11:09 ` Maíra Canal
2026-03-25 2:06 ` Stephen Boyd [this message]
2026-03-31 12:49 ` Mark Brown
2026-03-31 14:32 ` Maíra Canal
2026-03-31 14:44 ` Mark Brown
2026-04-22 15:12 ` Mark Brown
2026-03-12 21:34 ` [PATCH v7 2/5] pmdomain: bcm: bcm2835-power: Increase ASB control timeout Maíra Canal
2026-03-15 23:07 ` Stefan Wahren
2026-03-17 14:44 ` Maíra Canal
2026-03-16 11:02 ` Ulf Hansson
2026-03-12 21:34 ` [PATCH v7 3/5] drm/v3d: Use devm_reset_control_get_optional_exclusive() Maíra Canal
2026-03-12 21:34 ` [PATCH v7 4/5] drm/v3d: Allocate all resources before enabling the clock Maíra Canal
2026-03-12 21:34 ` [PATCH v7 5/5] drm/v3d: Introduce Runtime Power Management Maíra Canal
2026-03-17 17:52 ` Melissa Wen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177440440896.5403.6955660705156176314@localhost.localdomain \
--to=sboyd@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=florian.fainelli@broadcom.com \
--cc=itoral@igalia.com \
--cc=jmcasanova@igalia.com \
--cc=kernel-dev@igalia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mcanal@igalia.com \
--cc=mripard@kernel.org \
--cc=mturquette@baylibre.com \
--cc=mwen@igalia.com \
--cc=nsaenz@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox