From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 01/04] ARM: shmobile: Only build clocks when COMMON_CLK=n
Date: Tue, 09 Jul 2013 09:45:58 +0200 [thread overview]
Message-ID: <1774541.9WRl3VrJqz@avalon> (raw)
In-Reply-To: <201307090943.07898.arnd@arndb.de>
Hi Arnd and Magnus,
On Tuesday 09 July 2013 09:43:07 Arnd Bergmann wrote:
> On Tuesday 09 July 2013, Magnus Damm wrote:
> > +obj-y += $(clk-y$(CONFIG_COMMON_CLK))
>
> It took me a bit to understand the Makefile trick you are using here.
> I assume other readers will have the same problem. How about just
> doing
>
> +ifndef CONFIG_COMMON_CLK
> obj-$(CONFIG_ARCH_SH7372) += setup-sh7372.o intc-sh7372.o
> obj-$(CONFIG_ARCH_SH73A0) += setup-sh73a0.o intc-sh73a0.o
> obj-$(CONFIG_ARCH_R8A73A4) += setup-r8a73a4.o
> obj-$(CONFIG_ARCH_R8A7740) += setup-r8a7740.o intc-r8a7740.o
> obj-$(CONFIG_ARCH_R8A7778) += setup-r8a7778.o
> obj-$(CONFIG_ARCH_R8A7779) += setup-r8a7779.o intc-r8a7779.o
> obj-$(CONFIG_ARCH_R8A7790) += setup-r8a7790.o
> obj-$(CONFIG_ARCH_EMEV2) += setup-emev2.o
> +endif
I was about to mention the same, so I think that would be a good idea.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-07-09 7:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-09 5:43 [PATCH 00/04] ARM: shmobile: ARCH_MULTIPLATFORM for EMEV2 and KZM9D Magnus Damm
2013-07-09 5:43 ` [PATCH 01/04] ARM: shmobile: Only build clocks when COMMON_CLK=n Magnus Damm
2013-07-09 7:43 ` Arnd Bergmann
2013-07-09 7:45 ` Laurent Pinchart [this message]
2013-07-09 9:09 ` Magnus Damm
2013-07-09 21:06 ` Arnd Bergmann
2013-07-09 5:43 ` [PATCH 02/04] ARM: shmobile: Introduce ARCH_SHMOBILE_MULTI Magnus Damm
2013-07-09 5:43 ` [PATCH 03/04] ARM: shmobile: Add EMEV2 and KZM9D to ARCH_SHMOBILE_MULTI Magnus Damm
2013-07-09 7:37 ` Arnd Bergmann
2013-07-09 9:15 ` Magnus Damm
2013-07-09 21:07 ` Arnd Bergmann
2013-07-09 5:44 ` [PATCH 04/04] ARM: shmobile: Allow ARCH_SHMOBILE_MULTI timer configuration Magnus Damm
2013-07-09 7:45 ` [PATCH 00/04] ARM: shmobile: ARCH_MULTIPLATFORM for EMEV2 and KZM9D Arnd Bergmann
2013-07-09 9:11 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1774541.9WRl3VrJqz@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox