From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EDD45C4345F for ; Thu, 18 Apr 2024 09:20:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=b9NR4mX7SVvr9Hi8qJMjMHTchltnRRUkETrSx9SlFyg=; b=HyTXZv4OmtAvqhkJdvLNx5hpz2 3XV252oaG75rD5L+RI9t6fG23qa3hm/Ki6nhGFW+Oq1/KwQPxfnx/tOzE4gYdqGiC4GLkTKblHcjZ xv6SgjDEq0PNQYoOTu0ovoFmhQdJlPSxxbf6afwvsQkhZcTaxxHhuzjU9lZxD54Je9Vxd2FNYn0jc tCccpEUKktO30dnaoZeBT1Haxsa+vXgXS2oJoIY4D3yqb+Q7X/VSHK3y3BaE4OWvmjGliBmpZpDMt 5ywjsUnWCnd5xG7NF06W9anXUfgQsoQaMmYIteycWvSVRluVOHsNIQNpU7dGdweeLjqlo0R5jLoMg 8V5X2Iow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxNwO-00000001aAy-0d1O; Thu, 18 Apr 2024 09:20:24 +0000 Received: from out-184.mta1.migadu.com ([95.215.58.184]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxNwL-00000001a9e-0UYb for linux-arm-kernel@lists.infradead.org; Thu, 18 Apr 2024 09:20:22 +0000 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow.org; s=key1; t=1713432010; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OgDQ00mUpxy3+2dq2TcrdALIdNhTcXrsqRSYdfRVb6Q=; b=ReK9lGQduw+pn4a4IvkuUbIB2GRIVJ1ww7GWvcLG8CsRLsZajZzxpPHo9bfGYmuNmFR2aS y/sLNTbOo6ijQy4bMGv6X/JmXGbAjULg5GYRDp3HumT5gfiDHgXp3vNWhMTUnuZ1PP0+w9 8Pc8VXXHUQanEtLYN0TK16UtWaujF6tssCaFQ1HJl+2a3Ftq4rHLa9aAaW6nacoUiMvS3T XJ3yB06CmbUPnIDf1dmRdEF1WMUGczHML9iH91nYATDBw0gkdtcHmjeWNeu5WJ3xT3MCC8 4KteMe8chIxEq8blw8cIImy0cFdSYS6HCiaDDvbn8UHUd017Zg6iGdiNkhWS3g== From: Diederik de Haas To: liujianfeng1994@gmail.com Cc: krzk@kernel.org, linux-rockchip@lists.infradead.org, conor+dt@kernel.org, devicetree@vger.kernel.org, ezequiel@vanguardiasur.com.ar, heiko@sntech.de, krzk+dt@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, mchehab@kernel.org, p.zabel@pengutronix.de, robh@kernel.org, sfr@canb.auug.org.au, Conor Dooley , Jianfeng Liu Subject: Re: [PATCH v5 2/2] dt-bindings: media: rockchip-vpu: Add rk3588 vdpu121 compatible string Date: Thu, 18 Apr 2024 11:19:56 +0200 Message-ID: <1774986.o0yEF5yP89@bagend> Organization: Connecting Knowledge In-Reply-To: <20240413155709.802362-1-liujianfeng1994@gmail.com> References: <2a516484-ea87-444e-a89d-9fe33d08148f@kernel.org> <20240413155709.802362-1-liujianfeng1994@gmail.com> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240418_022021_313311_0A3B1DDA X-CRM114-Status: GOOD ( 14.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============4209287106962108822==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============4209287106962108822== Content-Type: multipart/signed; boundary="nextPart27639082.gtX0PHzvVj"; micalg="pgp-sha256"; protocol="application/pgp-signature" --nextPart27639082.gtX0PHzvVj Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii"; protected-headers="v1" From: Diederik de Haas To: liujianfeng1994@gmail.com Date: Thu, 18 Apr 2024 11:19:56 +0200 Message-ID: <1774986.o0yEF5yP89@bagend> Organization: Connecting Knowledge In-Reply-To: <20240413155709.802362-1-liujianfeng1994@gmail.com> MIME-Version: 1.0 On Saturday, 13 April 2024 17:57:09 CEST Jianfeng Liu wrote: > I'm sorry for my unkonwing about the kernel patching process. And I'm > sorry to let maintainers do extra work. Thank you for teaching me this. > I will do this right in future patches. > > I did received a Acked-by tag from Conor in v4: > Acked-by: Conor Dooley > > I note it here in case someone forgets this tag. I think it's beneficial to send a v6 with the following changes: 1) Make this dt-bindings patch the first in the series 2) Make sure you've collected all the tags you've received to all the patches 3) Specify the base commit ad 1) I don't know if it's a hard rule, but I've seen a consistent pattern where the dt-binding changes come before those changes being applied to DeviceTree files. It also makes sense as when the dt-binding change hasn't been applied, then the DT file is technically invalid. ad 2) You shouldn't make maintainers do extra work to get your patch(es) merged; you want to make their work as easy as possible. Thus you do the (extra) work and provide a new version of the patch(es). Sending multiple versions in a single day is generally not recommended as you should give reviewers some time to do the review. But it should be fine now as several days have past without new reviews. ad 3) The `git format-patch` command has a `--base=` parameter with which you can make explicit upon which commit the patch is based. That works a lot better/easier then a textual description. HTH --nextPart27639082.gtX0PHzvVj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQT1sUPBYsyGmi4usy/XblvOeH7bbgUCZiDlvAAKCRDXblvOeH7b bmEdAP9OLqzxTgUxfIC4NVwn89ZMipgZ02R2mr8wczdNorVfxgEAwMVlJgDzsjlr 2lkalQpvcr6qdfULVlBbAY1pfncDyAY= =4ic4 -----END PGP SIGNATURE----- --nextPart27639082.gtX0PHzvVj-- --===============4209287106962108822== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============4209287106962108822==--