From: "Rob Herring (Arm)" <robh@kernel.org>
To: mtk36707 <kuanfu.lu@mediatek.com>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
devicetree@vger.kernel.org,
Matthias Brugger <matthias.bgg@gmail.com>,
Balsam CHIHI <bchihi@baylibre.com>,
linux-arm-kernel@lists.infradead.org, vince-wl.liu@mediatek.com,
Philipp Zabel <p.zabel@pengutronix.de>,
justin.yeh@mediatek.com, linux-mediatek@lists.infradead.org,
jarried.lin@mediatek.com,
Daniel Lezcano <daniel.lezcano@kernel.org>,
Lukasz Luba <lukasz.luba@arm.com>,
linux-kernel@vger.kernel.org, Zhang Rui <rui.zhang@intel.com>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: thermal: mediatek: Add MT8189 LVTS bindings
Date: Mon, 27 Apr 2026 01:24:03 -0700 [thread overview]
Message-ID: <177727824371.1363528.14088477684280198031.robh@kernel.org> (raw)
In-Reply-To: <20260427065236.1685057-1-kuanfu.lu@mediatek.com>
On Mon, 27 Apr 2026 14:48:29 +0800, mtk36707 wrote:
> From: Kuanfu Lu <kuanfu.lu@mediatek.com>
>
> Add support for the MediaTek MT8189 LVTS thermal controller to
> the device tree bindings. This includes new compatible strings
> and required properties for MT8189.
>
> Signed-off-by: Kuanfu Lu <kuanfu.lu@mediatek.com>
> ---
> .../thermal/mediatek,lvts-thermal.yaml | 27 +++++++++++++++++--
> .../thermal/mediatek,lvts-thermal.h | 20 ++++++++++++++
> 2 files changed, 45 insertions(+), 2 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
./Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml:99:11: [warning] wrong indentation: expected 8 but found 10 (indentation)
./Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml:119:11: [warning] wrong indentation: expected 8 but found 10 (indentation)
dtschema/dtc warnings/errors:
doc reference errors (make refcheckdocs):
See https://patchwork.kernel.org/project/devicetree/patch/20260427065236.1685057-1-kuanfu.lu@mediatek.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
prev parent reply other threads:[~2026-04-27 8:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 6:48 [PATCH 1/2] dt-bindings: thermal: mediatek: Add MT8189 LVTS bindings mtk36707
2026-04-27 6:48 ` [PATCH 2/2] thermal: mediatek: lvts: Add MT8189 support mtk36707
2026-04-27 9:14 ` Philipp Zabel
2026-04-27 8:24 ` Rob Herring (Arm) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177727824371.1363528.14088477684280198031.robh@kernel.org \
--to=robh@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bchihi@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jarried.lin@mediatek.com \
--cc=justin.yeh@mediatek.com \
--cc=krzk+dt@kernel.org \
--cc=kuanfu.lu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=vince-wl.liu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox