From: "Heiko Stübner" <heiko@sntech.de>
To: Damon Ding <damon.ding@rock-chips.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
macromorgan@hotmail.com, jonas@kwiboo.se, tim@feathertop.org,
knaerzche@gmail.com, efectn@protonmail.com, andyshrk@163.com,
jagan@edgeble.ai, dsimic@manjaro.org, megi@xff.cz,
sebastian.reichel@collabora.com, alchark@gmail.com,
boris.brezillon@collabora.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Damon Ding <damon.ding@rock-chips.com>
Subject: Re: [PATCH v1 2/2] arm64: dts: rockchip: Add support for rk3588s evb1 board
Date: Tue, 10 Sep 2024 10:24:25 +0200 [thread overview]
Message-ID: <1778254.M3retTD8dW@diego> (raw)
In-Reply-To: <20240910030951.3670653-3-damon.ding@rock-chips.com>
Am Dienstag, 10. September 2024, 05:09:51 CEST schrieb Damon Ding:
> Specification:
> - Rockchip RK3588S
> - RK806-2x2pcs + DiscretePower
> - eMMC5.1 + SPI Flash
> - Micro SD Card3.0
> - 1 x Typec3.0 + 2 x USB2 HOST
> - 1 x 1Lane PCIE2.0 Connector(RC Mode)
> - Headphone output
> - Array Key(MENU/VOL+/VOP-/ESC), Reset, Power on/off Key
> - 6 x SARADC
>
> Signed-off-by: Damon Ding <damon.ding@rock-chips.com>
> ---
[...]
> + analog-sound {
> + compatible = "simple-audio-card";
> + pinctrl-names = "default";
> + pinctrl-0 = <&hp_detect>;
> + simple-audio-card,name = "RK3588 EVB1 Audio";
> + simple-audio-card,aux-devs = <&_headphone>, <&_speaker>;
> + simple-audio-card,bitclock-master = <&masterdai>;
> + simple-audio-card,format = "i2s";
> + simple-audio-card,frame-master = <&masterdai>;
> + simple-audio-card,hp-det-gpio = <&gpio1 RK_PD5 GPIO_ACTIVE_LOW>;
> + simple-audio-card,mclk-fs = <256>;
> + simple-audio-card,pin-switches = "Headphones", "Speaker";
> + simple-audio-card,routing =
> + "Speaker Amplifier INL", "LOUT2",
> + "Speaker Amplifier INR", "ROUT2",
> + "Speaker", "Speaker Amplifier OUTL",
> + "Speaker", "Speaker Amplifier OUTR",
> + "Headphones Amplifier INL", "LOUT1",
> + "Headphones Amplifier INR", "ROUT1",
> + "Headphones", "Headphones Amplifier OUTL",
> + "Headphones", "Headphones Amplifier OUTR",
> + "LINPUT1", "Onboard Microphone",
> + "RINPUT1", "Onboard Microphone",
> + "LINPUT2", "Microphone Jack",
> + "RINPUT2", "Microphone Jack";
> + simple-audio-card,widgets =
> + "Microphone", "Microphone Jack",
> + "Microphone", "Onboard Microphone",
> + "Headphone", "Headphones",
> + "Speaker", "Speaker";
> +
> + simple-audio-card,cpu {
> + sound-dai = <&i2s0_8ch>;
> + };
> +
> + masterdai: simple-audio-card,codec {
> + sound-dai = <&es8388>;
> + system-clock-frequency = <12288000>;
> + };
> + };
> +
> + amp_headphone: headphone-amplifier {
> + compatible = "simple-audio-amplifier";
> + enable-gpios = <&gpio4 RK_PA4 GPIO_ACTIVE_HIGH>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&headphone_amplifier_en>;
> + sound-name-prefix = "Headphones Amplifier";
> + };
> +
> + amp_speaker: speaker-amplifier {
> + compatible = "simple-audio-amplifier";
> + enable-gpios = <&gpio4 RK_PA5 GPIO_ACTIVE_HIGH>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&speaker_amplifier_en>;
> + sound-name-prefix = "Speaker Amplifier";
> + };
> +
> + backlight: backlight {
please sort nodes by node name ... so "backlight" after "analog-sound"
> + compatible = "pwm-backlight";
> + power-supply = <&vcc3v3_lcd_edp>;
> + pwms = <&pwm12 0 25000 0>;
> + };
> +
> + combophy_avdd0v85: combophy-avdd0v85-regulator {
generally the naming convention for regulator nodes now is
regulator-* ... so regulator-combophy-avdd0v85 here
and similar for others below.
Heiko
prev parent reply other threads:[~2024-09-10 8:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 3:09 [PATCH v1 0/2] Add support for RK3588S Evaluation board Damon Ding
2024-09-10 3:09 ` [PATCH v1 1/2] dt-bindings: arm: rockchip: Add rk3588s evb1 board Damon Ding
2024-09-10 3:09 ` [PATCH v1 2/2] arm64: dts: rockchip: Add support for " Damon Ding
2024-09-10 8:15 ` Alexey Charkov
2024-09-10 8:24 ` Heiko Stübner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1778254.M3retTD8dW@diego \
--to=heiko@sntech.de \
--cc=alchark@gmail.com \
--cc=andyshrk@163.com \
--cc=boris.brezillon@collabora.com \
--cc=conor+dt@kernel.org \
--cc=damon.ding@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=dsimic@manjaro.org \
--cc=efectn@protonmail.com \
--cc=jagan@edgeble.ai \
--cc=jonas@kwiboo.se \
--cc=knaerzche@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=macromorgan@hotmail.com \
--cc=megi@xff.cz \
--cc=robh@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=tim@feathertop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).