From: Jiaqi <shijiaqi_develop@163.com>
To: dri-devel@lists.freedesktop.org
Cc: Sandy Huang <hjc@rock-chips.com>,
Heiko Stuebner <heiko@sntech.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/6] drm/rockchip: Fix error handling and resource leaks in Rockchip DRM drivers
Date: Sat, 09 May 2026 12:16:58 +0800 [thread overview]
Message-ID: <177830021804.246051.8309807801406217751@openclaw.local> (raw)
This is v2 of the patch series that was previously withdrawn due to
a critical bug in Patch 3/6.
Changes in v2:
- Patch 3/6: Removed incorrect devm_free_irq() call in error path.
The IRQ registered via devm_request_irq() is managed by devres and
must NOT be manually freed. The corrected patch simply jumps to
err_crtcs label for proper cleanup via vop2_destroy_crtcs().
- Patch 5/6: Fixed trailing format issue that caused checkpatch ERROR.
This patch series fixes 6 bugs in the Rockchip DRM driver subsystem,
identified through static code analysis and confirmed by technical review.
The bugs range from Critical (of_node reference leaks, use-after-free)
to Medium (unchecked return values), and span 5 different source files.
Each patch addresses exactly one bug to facilitate review and bisection.
Summary of fixes:
Patch 1/6 (Critical): Fix of_node reference leak in
rockchip_drm_encoder_set_crtc_endpoint_id(). Both success and error
paths leaked references acquired via of_graph helpers.
Patch 2/6 (Critical): Fix dangling crtc->state in vop2_crtc_reset().
kzalloc() failure left crtc->state as a use-after-free pointer.
Patch 3/6 (High): Fix vop2_create_crtcs() error path cleanup in
vop2_bind(). Failures returned directly without calling
vop2_destroy_crtcs(), leaking of_node references. (v2: fixed
double-free by removing manual devm_free_irq())
Patch 4/6 (High): Fix vmap address caching in
rockchip_gem_prime_vmap(). New vmap() results were not saved to
rk_obj->kvaddr, causing repeated mappings and potential leaks.
Patch 5/6 (High): Fix leaked vblank event in
vop_crtc_atomic_disable(). Pending vop->event was warned but never
sent, causing userspace hangs and vblank reference leaks. (v2:
fixed checkpatch format error)
Patch 6/6 (Medium): Check return value of cdn_dp_grf_write() in
cdn_dp_enable_phy() error path. Ignored return value could leave
GRF registers in an inconsistent state.
All patches have been verified against checkpatch.pl --strict.
Signed-off-by: Jiaqi <shijiaqi_develop@163.com>
---
drivers/gpu/drm/rockchip/cdn-dp-core.c | 5 +++--
drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 14 +++++++++----
drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 1 +
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 11 ++++++++++-
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 2 +-
5 files changed, 35 insertions(+), 9 deletions(-)
next reply other threads:[~2026-05-09 4:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-09 4:16 Jiaqi [this message]
2026-05-09 4:17 ` [PATCH v2 1/6] drm/rockchip: Fix of_node reference leak in rockchip_drm_encoder_set_crtc_endpoint_id() Jiaqi
2026-05-09 4:17 ` [PATCH v2 2/6] drm/rockchip: Fix dangling crtc->state in vop2_crtc_reset() Jiaqi
2026-05-09 4:17 ` [PATCH 3/6 v2] drm/rockchip: Fix vop2_create_crtcs() error path cleanup in vop2_bind() Jiaqi
2026-05-09 5:37 ` Fushuai Wang
2026-05-09 4:17 ` [PATCH v2 4/6] drm/rockchip: Fix vmap address caching in rockchip_gem_prime_vmap() Jiaqi
2026-05-09 4:17 ` [PATCH v2 6/6] drm/rockchip: Check return value of cdn_dp_grf_write() in error path Jiaqi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177830021804.246051.8309807801406217751@openclaw.local \
--to=shijiaqi_develop@163.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox