From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B3A7CD37B5 for ; Sat, 9 May 2026 08:34:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:References:In-Reply-To:Date: Message-ID:Subject:Cc:To:From:Content-Transfer-Encoding:MIME-Version: Content-Type:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2bZWS7uJuE4xGLrY8DcRtxtEoAxGXioWLO6qqxg7ikw=; b=TYe5mGRl6WQ4qYtxVcNVz4YuoV kreZ3a9H2yGSpRsJgVKyGqZBp1SySXOXwEoTrsh8UnRbjPHvV7FN0KR5RZcI2ZAUcPDqBqtC/5JkN Y0GXheSYWaeHG/DY2ueZGDrxSpDQUQMQaTDkwt0+RUPCVPVZqH24RdhAoRslt9LEfSPCIvWNps0jT /vsz8KIEfYMEbCaJb5ed6yL3kvDuCbOOS3EhE+VHaTMTNfvEHXlImJXBamYNXx3x37FY/lb4gp2GA VVXt5K4uwWqcr4IyZaGXZSvojv+O1X9m5L9bpc7RZaaKHcmN6q2y3c4x59BESbbvnFVqsu7CYQNVC S7mXgZjw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wLd8Z-00000008agg-1roJ; Sat, 09 May 2026 08:34:15 +0000 Received: from m16.mail.163.com ([117.135.210.2]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wLd8V-00000008aYk-1DTr; Sat, 09 May 2026 08:34:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Content-Type:MIME-Version:From:To:Subject: Message-ID:Date; bh=2bZWS7uJuE4xGLrY8DcRtxtEoAxGXioWLO6qqxg7ikw=; b=OpZ2kqe1QGguTne0u5uh5ocBkWXPvP4aWQwUody/xWBXWl3xK7JIAU3Uzh1pjC lpm00P2bUly55h66qMc0X6zKYPz1zm62hyIDIgZa1JUnT1SkFFp7sFdBdlo6yp36 AETWBUiHqMA2/3O6nzxSX3Gthu6c0R57EX45CGCIGB9tI= Received: from [127.0.1.1] (unknown []) by gzga-smtp-mtada-g1-1 (Coremail) with SMTP id _____wD3hNt28f5pKElvAQ--.45179S2; Sat, 09 May 2026 16:33:59 +0800 (CST) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Jiaqi To: dri-devel@lists.freedesktop.org Cc: Sandy Huang , Heiko Stuebner , David Airlie , Daniel Vetter , Philipp Zabel , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 5/6] drm/rockchip: Fix leaked vblank event in vop_crtc_atomic_disable() Message-ID: <177831563850.322716.2488834570802720729@163.com> Date: Sat, 09 May 2026 16:33:58 +0800 In-Reply-To: <177831560568.322716.7926332149561323511@163.com> References: <177831560568.322716.7926332149561323511@163.com> X-CM-TRANSID: _____wD3hNt28f5pKElvAQ--.45179S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7Aw15Ww1UKF13Cry8Ar1DJrb_yoW8AF1xpr s3G34Yvr40qFWjv3Z8Jr4vyFWfuw4Iv397Cr9rG343Z3Z3Krn8X3W8Cr93ZF45XrsrJa17 Z393JryUZF18ArDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jUfHbUUUUU= X-Originating-IP: [42.63.126.112] X-CM-SenderInfo: xvklyxpdtlsvxhyhz0rs6rljoofrz/xtbCzRezB2n+8XcnlAAA3M X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260509_013411_810579_F71614B8 X-CRM114-Status: GOOD ( 13.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org In vop_crtc_atomic_disable(), there is a WARN_ON(vop->event) that warns when an event is pending, but the event is never actually handled. When vop_crtc_atomic_flush() has been called, it moves crtc->state->event to vop->event and calls drm_crtc_vblank_get(). If atomic_disable() is called before the vblank IRQ fires (e.g., due to a modeset or CRTC disable), vop->event remains set but is never sent to userspace. This means: 1. Userspace waits forever for the flip completion event, causing a hang. 2. The vblank reference acquired in atomic_flush() is never released, leaking the vblank reference count. Fix by sending the pending event and releasing the vblank reference when atomic_disable() detects a pending vop->event, matching the behavior in vop_handle_vblank(). Signed-off-by: Jiaqi --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index 8afabe2118a9..1234567890ab 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c @@ -700,7 +700,16 @@ static void vop_crtc_atomic_disable(struct drm_crtc *crtc, { struct vop *vop = to_vop(crtc); - WARN_ON(vop->event); + if (vop->event) { + WARN_ON(1); + spin_lock_irq(&crtc->dev->event_lock); + drm_crtc_send_vblank_event(crtc, vop->event); + spin_unlock_irq(&crtc->dev->event_lock); + drm_crtc_vblank_put(crtc); + vop->event = NULL; + } if (crtc->state->self_refresh_active) rockchip_drm_set_win_enabled(crtc, false); -- 2.40.0