From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Arnd Bergmann <arnd@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Alim Akhtar <alim.akhtar@samsung.com>,
Brian Masney <bmasney@redhat.com>,
Peter Griffin <peter.griffin@linaro.org>,
linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] firmware: samsung: acpm: remove compile-testing stubs
Date: Fri, 29 May 2026 16:07:50 +0200 [thread overview]
Message-ID: <178006367096.55906.16678510397337205828.b4-ty@b4> (raw)
In-Reply-To: <20260529134454.2147446-1-arnd@kernel.org>
On Fri, 29 May 2026 15:43:31 +0200, Arnd Bergmann wrote:
> Sashiko reported an inconsistent use of NULL vs ERR_PTR()
> returns in the stub helpers in xynos-acpm-protocol.h.
>
> Since this only happens on dead code for COMPILE_TEST=y, this is not
> really a bug though. Having stub functions that return NULL is a common
> way to define optional interfaces, where callers still work when the
> feature is disabled, though this clearly does not work for acpm because
> some callers have a NULL pointer dereference when compile testing.
>
> [...]
Applied, thanks!
[1/1] firmware: samsung: acpm: remove compile-testing stubs
https://git.kernel.org/krzk/linux/c/7b661285aa7507eab79efff0a418445157db4141
Best regards,
--
Krzysztof Kozlowski <krzk@kernel.org>
prev parent reply other threads:[~2026-05-29 14:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-29 13:43 [PATCH] firmware: samsung: acpm: remove compile-testing stubs Arnd Bergmann
2026-05-29 14:07 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178006367096.55906.16678510397337205828.b4-ty@b4 \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bmasney@redhat.com \
--cc=cw00.choi@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=peter.griffin@linaro.org \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=tudor.ambarus@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox