From: Jai Luthra <jai.luthra@ideasonboard.com>
To: Nishanth Menon <nm@ti.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Robert Nelson <robertcnelson@gmail.com>,
Andrew Davis <afd@ti.com>, Devarsh Thakkar <devarsht@ti.com>,
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] arm64: dts: ti: k3-am67a-beagley-ai: Add I2C2 pinctrl
Date: Sat, 30 May 2026 15:45:35 +0530 [thread overview]
Message-ID: <178013613529.933414.3135232474616950291@freya> (raw)
In-Reply-To: <20260529144125.vs4bds6nwimqdnbg@quack>
Hi Nishanth,
Quoting Nishanth Menon (2026-05-29 20:11:25)
> On 06:46-20260515, Jai Luthra wrote:
> > I2C2 is used by camera sensor devices connected on the 22-pin CSI0
> > connector. Add the pin definition here so I2C2 may be enabled by the
> > camera sensor overlays.
> >
>
> Why not add the i2c node here with the pinmux, but disable the node with a
> comment that this should be enabled for camera sensors? A bit confused
> seeing a orphan pinmux node. but i dont see any other function for the
> i2c2 other than support the camera sensors :)
>
Ah I saw main_i2c0 pins defined here already with no node (that's also only
used by CSI1/DSI0 connector), so I followed the same pattern here.
Will move them both here in v2.
Thanks,
Jai
>
> > Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
> > ---
> > arch/arm64/boot/dts/ti/k3-am67a-beagley-ai.dts | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/ti/k3-am67a-beagley-ai.dts b/arch/arm64/boot/dts/ti/k3-am67a-beagley-ai.dts
> > index 5255e04b9ac7..06aac02a7668 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am67a-beagley-ai.dts
> > +++ b/arch/arm64/boot/dts/ti/k3-am67a-beagley-ai.dts
> > @@ -157,6 +157,13 @@ J722S_IOPAD(0x01e4, PIN_INPUT_PULLUP, 0) /* (B22) I2C0_SDA */
> > bootph-all;
> > };
> >
> > + main_i2c2_pins_default: main-i2c2-default-pins {
> > + pinctrl-single,pins = <
> > + J722S_IOPAD(0x00b0, PIN_INPUT_PULLUP, 1) /* (P22) GPMC0_CSn2.I2C2_SCL */
> > + J722S_IOPAD(0x00b4, PIN_INPUT_PULLUP, 1) /* (P23) GPMC0_CSn3.I2C2_SDA */
> > + >;
> > + };
> > +
> > main_uart0_pins_default: main-uart0-default-pins {
> > pinctrl-single,pins = <
> > J722S_IOPAD(0x01c8, PIN_INPUT, 0) /* (A22) UART0_RXD */
> >
> > --
> > 2.54.0
> >
> >
>
>
> --
> Regards,
> Nishanth Menon
> Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
> https://ti.com/opensource
next prev parent reply other threads:[~2026-05-30 10:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 1:16 [PATCH v2 0/4] arm64: dts: ti: BeagleY-AI camera overlays Jai Luthra
2026-05-15 1:16 ` [PATCH v2 1/4] arm64: dts: ti: k3-am67a-beagley-ai: Add I2C2 pinctrl Jai Luthra
2026-05-29 14:41 ` Nishanth Menon
2026-05-30 10:15 ` Jai Luthra [this message]
2026-05-15 1:16 ` [PATCH v2 2/4] arm64: dts: ti: k3-am67a-beagley-ai: Add DSI0/CSI1 mux Jai Luthra
2026-05-31 9:42 ` Rishikesh Donadkar
2026-05-15 1:16 ` [PATCH v2 3/4] arm64: dts: ti: k3-am67a-beagley-ai: Add overlay for IMX219 on CSI0 Jai Luthra
2026-05-29 14:49 ` Nishanth Menon
2026-05-30 10:27 ` Jai Luthra
2026-05-29 15:01 ` Nishanth Menon
2026-05-30 10:24 ` Jai Luthra
2026-06-04 13:29 ` Andrew Davis
2026-05-15 1:16 ` [PATCH v2 4/4] arm64: dts: ti: k3-am67a-beagley-ai: Add overlay for IMX219 on CSI1 Jai Luthra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178013613529.933414.3135232474616950291@freya \
--to=jai.luthra@ideasonboard.com \
--cc=afd@ti.com \
--cc=conor+dt@kernel.org \
--cc=devarsht@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robertcnelson@gmail.com \
--cc=robh@kernel.org \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox