From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2930CC4707B for ; Tue, 9 Jan 2024 20:21:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=c3a1obZ6F2HABDkqs0AeM3SSNKnBkbEsruKkAMsZJTs=; b=skc03ixCgJeLHe PVCDBxABn311bmRbQ+7RKPwNCTYvkpHHBlF7ksMQzTbk1lCoE77Sj2CogeDlw3/Hp+lZO0MrwfwyQ umTMaSjhl1vqFdG0ytS8D4/x26uucno6movQCZmL3b4SGddSuWa88ZEiJYdn5mZeS6BldjWjw+ODb mf8IhvzRImPQuzXWfoWsPGzBuy8AHwNl+lU2Sgy4LiCYkP3KrBe8HTQUh9XzO4ITRKpp0U6vd8NVB 9DY+UoLx1KfR4DgfWX7o/ASNAdvVmtLx4scewd/BHMbOaMtOf9srHa6BcbGMuRSZDF64UbMpVPib1 YpmN3a16A9kfj4TK+MoQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rNIbE-009RQ4-1Q; Tue, 09 Jan 2024 20:21:24 +0000 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rNIbB-009RNb-2A for linux-arm-kernel@lists.infradead.org; Tue, 09 Jan 2024 20:21:23 +0000 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-40e5521dab6so1301555e9.1 for ; Tue, 09 Jan 2024 12:21:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704831677; x=1705436477; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=SV192nZl7wwZqocnDFeUodUzhIyPq553m7hm6fzBgSg=; b=Cg5vssZO25b3V/TVbPUpuk54Q567McTVKCUh/THKLAyDpjlPYYZvfNWu7ERnk9EKPi WnfhK4UPAvvVZVeRIGRb+mC/MZDKmxfPc5C67+lLGM7m8o6PxKN/DIy826m56IGhOyL6 0hNkiFA3JRbYYGqSPGf1cOymn4Yu/3sSqzGwP2mbka/n3npxiNHRkwNtJfQe5l4x0XJx j2CMggQJ8G9ucIIVriPrfgCix5g6yOoSjEzUNwQL5fAFq1kjrGxo4LACMzdYrpRwdn4q 7xHQ42JobP/bHDEIFt+Ajw4Kd9BvuyCRzRSOCADCwX/PJN1A8f7oM5kGN78nO2sxGzxZ y1GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704831677; x=1705436477; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SV192nZl7wwZqocnDFeUodUzhIyPq553m7hm6fzBgSg=; b=OffzHEv+18w4MRfi7gFWfkH3sbgQ0PmSHTNa01OqV/81gtX52kjkmIh1/6HBprCPad XNx1kT4Mx8iMt0s3CobuOBAzx8hulHVlJqcvWf5UkcKAp2L8g2iiD69lDxm7mUtnsp6A THiBw1XQ7Ym9QlX+BE2vIu3OVY6oA0Rz9E7zbsiMMbJ/4PKzKwWPL28ZEghs4wGYIJEY TfF5h+6ccN04zHnT60uDvTgPxjtn4SsmlmKIBCp/FVfY9Wt0HKdoMam7mwvB5DnAnR7z QPP3lJEKlJCagjr8trnKmnwEiV80cNr/mp1im8YKffGU7tBoY0Mc/tM0VrzjxbNvX6e+ dLSg== X-Gm-Message-State: AOJu0YwSi6CQQ/sgJjLNoKUyeF8BsTjlYyLtp/GgdrPrwas35Tq/63uH rVZTZIiiUfCznYAcWNbF3wo= X-Google-Smtp-Source: AGHT+IHG/BUU9h0G4AHEcZub4AHtt+rBOqTvADVCj3ASiPBNesPC+msk3izuB2XDdqx2MI2K3BGAfg== X-Received: by 2002:a05:600c:4512:b0:40e:3549:9021 with SMTP id t18-20020a05600c451200b0040e35499021mr3368771wmo.33.1704831677080; Tue, 09 Jan 2024 12:21:17 -0800 (PST) Received: from jernej-laptop.localnet (213-161-3-116.dynamic.telemach.net. [213.161.3.116]) by smtp.gmail.com with ESMTPSA id f6-20020adfe906000000b0033609584b9dsm3213016wrm.74.2024.01.09.12.21.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jan 2024 12:21:16 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Andre Przywara , Florian Fainelli , Wei Xu , Gregory CLEMENT , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, =?utf-8?B?6bqm5YGl5bu6?= Subject: Re: [PATCH v2] ARM: dts: sun8i: Open FETA40i-C regulator aldo1 Date: Tue, 09 Jan 2024 21:21:13 +0100 Message-ID: <1780716.VLH7GnMWUR@jernej-laptop> In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240109_122121_710241_65B0C104 X-CRM114-Status: GOOD ( 20.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne torek, 26. december 2023 ob 09:40:05 CET je Fuyao Kashizuku napisal(a): > The USB PHY in the Allwinner R40 SoC seems to rely on voltage on the > VCC-TVIN/OUT supply pins for proper operation, on top of its own supply > voltage on VCC-USB. Without a 3.3V voltage supplied to VCC-TV*, USB > operation becomes unstable and can result in disconnects. > > The Forlinx FETA40i-C SoM connects both the VCC-TVOUT and VCC-TVIN pins > to the ALDO1 rail of the PMIC, so we need to enable that rail for USB > operation. Since there is no supply property in the DT bindings for > the USB core, we need to always enable the regulator. > > This fixes unstable USB operation on boards using the Forlinx FETA40i-C > module. > > Signed-off-by: Fuyao Kashizuku Reviewed-by: Jernej Skrabec Best regards, Jernej > --- > Changes in v2: > - Subject include board name. > - regulator name changed to vcc-3v3-tv-usb. > - explain why we need to enable the regulator. > - use full name of the commiter > - Link to v1: https://lore.kernel.org/lkml/ZYKjYypuAx7gNuam@debian.cyg/ > > arch/arm/boot/dts/allwinner/sun8i-r40-feta40i.dtsi | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm/boot/dts/allwinner/sun8i-r40-feta40i.dtsi b/arch/arm/boot/dts/allwinner/sun8i-r40-feta40i.dtsi > index 9f39b5a2bb35..c12361d0317f 100644 > --- a/arch/arm/boot/dts/allwinner/sun8i-r40-feta40i.dtsi > +++ b/arch/arm/boot/dts/allwinner/sun8i-r40-feta40i.dtsi > @@ -42,6 +42,13 @@ &pio { > vcc-pg-supply = <®_dldo1>; > }; > > +®_aldo1 { > + regulator-always-on; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-name = "vcc-3v3-tv-usb"; > +}; > + > ®_aldo2 { > regulator-always-on; > regulator-min-microvolt = <1800000>; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel