From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36538CD98E6 for ; Tue, 16 Jun 2026 12:42:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=6uM0ObpaAPGFXgDRAB4wX+6R8VKBvIYPs4Db/iskdHQ=; b=dKExGMC85AraRrBJow7w4F+PlG p7QWsxN9RCijAFiUkMajiRke2qAe62vd1ky0/T9xAqzXNz9ms8DSN9YRDWsJwJtv/46/YudZXwgB1 Fi1czs760VIh/yAxXKrkMphfhcJkDlKZIpe/3gOr+Qc8AC58Opk0LN5R2fXMIoihzdJvNXa5hMoZL vawFIiNeSy0GktiQQz7qk05VW1e2rjJhFqtPzWNZCRgtELQgWAE3pZRc4z2vxG9Lk199P31O1VE61 +t3GWgBzCeuCPYZXw29H4fSTTkM/TsPaXVJcENDSQoISWPp7Brrypi5gVZQNvbjF51xeQi6qr+dnx r7Yrn8cQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wZT7a-0000000FmNZ-34IY; Tue, 16 Jun 2026 12:42:26 +0000 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wZT7X-0000000FmMw-1uYH for linux-arm-kernel@lists.infradead.org; Tue, 16 Jun 2026 12:42:24 +0000 Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-2bf1f074a12so44903335ad.0 for ; Tue, 16 Jun 2026 05:42:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781613742; x=1782218542; darn=lists.infradead.org; h=mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=6uM0ObpaAPGFXgDRAB4wX+6R8VKBvIYPs4Db/iskdHQ=; b=gi7QisEhr5cSMibZHFShv1yOVcBQPejS5ic/4DUxKEn5gDC+06qz9f7/D0AVwdFV2v nh1/lcHeFeEntYtx5vTPlZa2XqEf9hER9Ccv1/6zHO7+a7ikajhfN9SEMbWCDsBUzMFk 2yltvMvOzfqInxl76sGUWXYHctsphU8CG2bUDny0Hno0k6KA3H972MVChltyS6vO+YUl yzyYUvM6FTNDPlVonDs233G1ZxIAy+2K26ebWRluAWLMLR1HGtwQJlP2KWqsClBIe7YW +et4LTQcEOYWI5stbxbiCa81TAKZewoM3u7Exe7P7chRfu0nu77DDwYa3J1gVFq+yH1c /aIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781613742; x=1782218542; h=mime-version:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6uM0ObpaAPGFXgDRAB4wX+6R8VKBvIYPs4Db/iskdHQ=; b=G2xFkdetlpLH+NWN5ukTTIlsDAUTFxi4JB33Vft4mkJTEV4V8wlo4R5l233B2kXtAc GBsjB37GWTRp62HCUwuPvH8NlVO35srJ1A0Wyu/ntYGeE3laAU8gCZvEoGIkoaKvnLUM xDwhsvA9EaLDPK8asere5/NEFlQIOnqnbSh/0PMUL/Bvf7u3D9IJEX00zro5bv1PBIo/ Ut4GUmj7TZQr+x2GdVP4z1ISQ6x41WhtihuRojFg6nn4orAwuETQgh2dmsZwAUwVYoVc Jvc303dS0xZtYlOw2bvyUj/YeooMXZ4bDya1pUSbdcxCpbeN9Xq7e1mFYM2mnthS7MUq /B9A== X-Forwarded-Encrypted: i=1; AFNElJ938EwI2mLYpI9o5KiGJO6KbA3wWnWWSb/nliDuubJedkQwygwKP8aatNCZD5PggLrQW74Q77zwDo7EqTF0x6CE@lists.infradead.org X-Gm-Message-State: AOJu0YxIn20PC+6tWcDIQcceCLz4WSpz6z/ls4HDfl72Tb9mhmaOx3vS DQGTuGl1jCJw/kWt0XFZV5R44X9CdZedAF80HqYsiPyOgYxEoq380vrQ X-Gm-Gg: Acq92OF/i5/05YvuUhEvbrBNhIMlMdB8icn8sUr8/97xmYrDhmi9S9UoNP+d4N8fQSe gCEVCY0nyZR6BvMnOImGyy/d3GLSPcB2RZUFYiOP6J1xw7KbgBcEKcuOQNiFyF0X26y5VbfHMYV NjtyoVtJhPiSepDVEnPeXbnr+ouMvg7wULTaMXsUyiPG63HvUS45YGkiFdnPFuNwkCNA2K0wkDy sKs0ODlImkzeOFf4pff/6ZRQWbrqm/WGAHSQojGanD70DpAlnvAjCQYJQoJxRRi1vGTwzTnkeGo xp1sxh9wtp9r23c2DA9di3ssWLQE9MDRBodneoovYCZvHbNhbHocNCldR4R+p2/7m6n3a3anOpF WE98YVyPB/VBBRj7xr77OPZxb6YMT25k6TfEy0PH5FqONjOfvwdjDZTF7NsbNug32SW2A47oKAw Lwx0cMKTwc8cu5FBjT X-Received: by 2002:a17:902:c944:b0:2c6:9448:363a with SMTP id d9443c01a7336-2c69a1731b3mr37365455ad.20.1781613742538; Tue, 16 Jun 2026 05:42:22 -0700 (PDT) Received: from [127.0.1.1] ([47.253.114.73]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c42fbb50e5sm135274665ad.35.2026.06.16.05.42.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2026 05:42:22 -0700 (PDT) From: Wayen Yan To: netdev@vger.kernel.org Cc: lorenzo@kernel.org, horms@kernel.org, pabeni@redhat.com, kuba@kernel.org, edumazet@google.com, andrew+netdev@lunn.ch, angelogioacchino.delregno@collabora.com, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH net v3] net: airoha: Fix skb->priority underflow in airoha_dev_select_queue() Date: Sun, 14 Jun 2026 07:30:54 +0800 Message-ID: <178161373805.2167512.2544164327472822616@gmail.com> Content-Type: text/plain; charset=utf-8 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260616_054223_514173_9F137606 X-CRM114-Status: GOOD ( 10.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org In airoha_dev_select_queue(), the expression: queue = (skb->priority - 1) % AIROHA_NUM_QOS_QUEUES; implicitly converts to unsigned arithmetic: when skb->priority is 0 (the default for unclassified traffic), (0u - 1u) wraps to UINT_MAX, and UINT_MAX % 8 = 7, routing default best-effort packets to the highest-priority QoS queue. This causes QoS inversion where the majority of traffic on a PON gateway starves actual high-priority flows (VoIP, gaming, etc.). Fix by guarding the subtraction: when priority is 0, map to queue 0 (lowest priority), otherwise apply the original (priority - 1) % 8 mapping. Fixes: 2b288b81560b ("net: airoha: Introduce ndo_select_queue callback") Acked-by: Lorenzo Bianconi Reviewed-by: Joe Damato Signed-off-by: Wayen Yan --- drivers/net/ethernet/airoha/airoha_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/airoha/airoha_eth.c b/drivers/net/ethernet/airoha/airoha_eth.c index 31cdb11cd7..d476ef83c3 100644 --- a/drivers/net/ethernet/airoha/airoha_eth.c +++ b/drivers/net/ethernet/airoha/airoha_eth.c @@ -1933,7 +1933,7 @@ static u16 airoha_dev_select_queue(struct net_device *dev, struct sk_buff *skb, */ channel = netdev_uses_dsa(dev) ? skb_get_queue_mapping(skb) : port->id; channel = channel % AIROHA_NUM_QOS_CHANNELS; - queue = (skb->priority - 1) % AIROHA_NUM_QOS_QUEUES; /* QoS queue */ + queue = skb->priority ? (skb->priority - 1) % AIROHA_NUM_QOS_QUEUES : 0; queue = channel * AIROHA_NUM_QOS_QUEUES + queue; return queue < dev->num_tx_queues ? queue : 0; -- 2.51.0