public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] arm64: to allow EFI_RTC can be selected on ARM64
Date: Mon, 28 Sep 2015 09:35:50 +0200	[thread overview]
Message-ID: <1783631.jH4WY2RqXu@wuerfel> (raw)
In-Reply-To: <1443418478-8240-3-git-send-email-thunder.leizhen@huawei.com>

On Monday 28 September 2015 13:34:38 Zhen Lei wrote:
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 07d1811..25cec57 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -85,7 +85,7 @@ config ARM64
>         select PERF_USE_VMALLOC
>         select POWER_RESET
>         select POWER_SUPPLY
> -       select RTC_LIB
> +       select RTC_LIB if !EFI
>         select SPARSE_IRQ
>         select SYSCTL_EXCEPTION_TRACE
>         select HAVE_CONTEXT_TRACKING

Sorry, we can't do that: enabling EFI has to be done in a way that it only
adds features but not disables them.

Your patch breaks RTC on all non-EFI platforms as soon as CONFIG_EFI
is selected by the user.

	Arnd

  reply	other threads:[~2015-09-28  7:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-28  5:34 [PATCH 0/2] to allow EFI_RTC can be selected on ARM64 Zhen Lei
2015-09-28  5:34 ` [PATCH 1/2] char/rtc: " Zhen Lei
2015-09-28  5:34 ` [PATCH 2/2] arm64: " Zhen Lei
2015-09-28  7:35   ` Arnd Bergmann [this message]
2015-09-28  8:29     ` Leizhen (ThunderTown)
2015-09-28  8:42       ` Arnd Bergmann
2015-09-28  9:44         ` Leizhen (ThunderTown)
2015-09-28  9:56           ` Arnd Bergmann
2015-10-08  9:07           ` Leizhen (ThunderTown)
2015-09-28  7:40   ` Ard Biesheuvel
2015-09-28  8:41     ` Leizhen (ThunderTown)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1783631.jH4WY2RqXu@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox