From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: "João Rodrigues" <jrodrigues@ubimet.com>,
"Bruno Thomsen" <bruno.thomsen@gmail.com>,
"Fabio Estevam" <festevam@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] ARM: dts: imx: tqma7: add lm75a sensor (rev. 01xxx)
Date: Thu, 09 Nov 2023 07:57:36 +0100 [thread overview]
Message-ID: <1783737.VLH7GnMWUR@steina-w> (raw)
In-Reply-To: <2253436.iZASKD2KPV@steina-w>
Hi João,
Am Dienstag, 7. November 2023, 07:34:32 CET schrieb Alexander Stein:
> Hi,
>
> Am Freitag, 3. November 2023, 22:07:08 CET schrieb Fabio Estevam:
> > [Adding Bruno and Alexander]
> >
> > On Thu, Nov 2, 2023 at 7:12 PM João Rodrigues <jrodrigues@ubimet.com>
wrote:
> > > From: João Rodrigues <jrodrigues@ubimet.com>
> > >
> > > TQMa7x (revision 01xxx) uses a LM75A temperature sensor.
> > > The two sensors use different I2C addresses, so we can set both sensors
> > > simultaneously.
>
> I've contacted responsible department and I am waiting for more details.
I got response that REV.01xx was just a prototype and not released officially.
> Best regards,
> Alexander
>
> > > Signed-off-by: João Rodrigues <jrodrigues@ubimet.com>
> > > ---
> > >
> > > arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi | 9 +++++++--
> > > 1 file changed, 7 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi
> > > b/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi index
> > > fe42b0a4683..3fc3130f9de 100644
> > > --- a/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi
> > > +++ b/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi
> > > @@ -128,11 +128,16 @@ vgen6_reg: vldo4 {
> > >
> > > };
> > >
> > > };
> > >
> > > - /* NXP SE97BTP with temperature sensor + eeprom */
> > > + /* LM75A temperature sensor, TQMa7x 01xx */
> > > + lm75a: temperature-sensor@48 {
> > > + compatible = "national,lm75a";
> > > + reg = <0x48>;
> > > + };
I don't like the idea of adding an i2c device for everybody. This restricts/
affects usage of i2c address 0x48 for all rev.02xx users, no?
Best regards,
Alexander
> > > +
> > > + /* NXP SE97BTP with temperature sensor + eeprom, TQMa7x 02xx */
> > >
> > > se97b: temperature-sensor-eeprom@1e {
> > >
> > > compatible = "nxp,se97b", "jedec,jc-42.4-temp";
> > > reg = <0x1e>;
> > >
> > > - status = "okay";
> > >
> > > };
> > >
> > > /* ST M24C64 */
> > >
> > > --
> > > 2.25.1
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-11-09 6:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 22:11 [PATCH v1] ARM: dts: imx: tqma7: add lm75a sensor (rev. 01xxx) João Rodrigues
2023-11-03 21:07 ` Fabio Estevam
2023-11-07 6:34 ` Alexander Stein
2023-11-09 6:57 ` Alexander Stein [this message]
2023-11-09 9:26 ` jrodrigues
2023-11-08 22:51 ` Bruno Thomsen
2023-11-09 8:49 ` jrodrigues
2023-12-05 12:14 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1783737.VLH7GnMWUR@steina-w \
--to=alexander.stein@ew.tq-group.com \
--cc=bruno.thomsen@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=jrodrigues@ubimet.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).