From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8D6CC433EF for ; Mon, 20 Sep 2021 10:10:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A07A60F25 for ; Mon, 20 Sep 2021 10:10:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9A07A60F25 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=w9wgar7SGkyHloWXqn/UuCmFWwelxbm8JwXpu9zgbj0=; b=WgqHI4EdgDmQsj/4Rl8rgn4jUs aPS5vVtR/vR08s8m11o+GcDQrzbNa1TbKqYv3BD66mhFTPJ5otiotz84qdRVvIYUA58xklUY1eW7T tjdsNQcL4Mm7tfkTgBrfNzmFXPK2ZOwjcwATFzXuK0DF7LBOgsneDIFs4vmIlPyR9FRj6jCYglgpc 5hWDGJo/3yVPVpSIOtydld7zJZ059Gm1r16ZF/DlzctiPRJFlBo5iDVSiJR+FzUbkJjAfhPFpgp/Q goJ0X3MR28RhaTOrqJjXrMINs4P3OKiCTsbUpDKASTzC9R2Oc5uaoV9U1ZIRyRP/6KvApkX03sBto e4VyIEDQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSGDy-001EyD-F5; Mon, 20 Sep 2021 10:08:34 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSGDu-001Ewy-8e for linux-arm-kernel@lists.infradead.org; Mon, 20 Sep 2021 10:08:31 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0532960F25; Mon, 20 Sep 2021 10:08:30 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mSGDs-00Bjgb-1s; Mon, 20 Sep 2021 11:08:28 +0100 MIME-Version: 1.0 Date: Mon, 20 Sep 2021 11:08:27 +0100 From: Marc Zyngier To: Arnd Bergmann Cc: Catalin Marinas , Will Deacon , David Brazdil , Arnd Bergmann , James Morse , Alexandru Elisei , Suzuki K Poulose , Quentin Perret , Kees Cook , Sami Tolvanen , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: arm: add Kbuild FORCE prerequisite for hyp-reloc In-Reply-To: <20210920100515.1554788-1-arnd@kernel.org> References: <20210920100515.1554788-1-arnd@kernel.org> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <1785d70bf2211832c4640763114d3f8d@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: arnd@kernel.org, catalin.marinas@arm.com, will@kernel.org, dbrazdil@google.com, arnd@arndb.de, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, qperret@google.com, keescook@chromium.org, samitolvanen@google.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210920_030830_352703_CDBF5355 X-CRM114-Status: GOOD ( 21.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2021-09-20 11:05, Arnd Bergmann wrote: > From: Arnd Bergmann > > Commit e1f86d7b4b2a ("kbuild: warn if FORCE is missing for > if_changed(_dep,_rule) > and filechk") added a helpful check for Kbuild, which now notices > that a problem with the hyp-reloc rule: > > arch/arm64/kvm/hyp/nvhe/Makefile:58: FORCE prerequisite is missing > > Do as suggested and add FORCE here. > > Fixes: 8c49b5d43d4c ("KVM: arm64: Generate hyp relocation data") > Signed-off-by: Arnd Bergmann > --- > arch/arm64/kvm/hyp/nvhe/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/hyp/nvhe/Makefile > b/arch/arm64/kvm/hyp/nvhe/Makefile > index 5df6193fc430..8d741f71377f 100644 > --- a/arch/arm64/kvm/hyp/nvhe/Makefile > +++ b/arch/arm64/kvm/hyp/nvhe/Makefile > @@ -54,7 +54,7 @@ $(obj)/kvm_nvhe.tmp.o: $(obj)/hyp.lds $(addprefix > $(obj)/,$(hyp-obj)) FORCE > # runtime. Because the hypervisor is part of the kernel binary, > relocations > # produce a kernel VA. We enumerate relocations targeting hyp at > build time > # and convert the kernel VAs at those positions to hyp VAs. > -$(obj)/hyp-reloc.S: $(obj)/kvm_nvhe.tmp.o $(obj)/gen-hyprel > +$(obj)/hyp-reloc.S: $(obj)/kvm_nvhe.tmp.o $(obj)/gen-hyprel FORCE > $(call if_changed,hyprel) > > # 5) Compile hyp-reloc.S and link it into the existing partially > linked object. I already have queued [1], which does the same thing. Thanks, M. [1] https://lore.kernel.org/r/20210907052137.1059-1-yuzenghui@huawei.com -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel