From: Oliver Upton <oupton@kernel.org>
To: maz@kernel.org, Qihang <q.h.hack.winter@gmail.com>
Cc: Oliver Upton <oupton@kernel.org>,
catalin.marinas@arm.com, will@kernel.org,
linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] KVM: arm64: vgic-v3: take an LPI reference in vgic_v3_save_pending_tables
Date: Sat, 8 Aug 2026 11:35:40 -0700 [thread overview]
Message-ID: <178621413201.380376.9463585617788229094.b4-ty@kernel.org> (raw)
In-Reply-To: <20260807025534.34125-1-q.h.hack.winter@gmail.com>
On Fri, 07 Aug 2026 10:55:34 +0800, Qihang wrote:
> vgic_v3_save_pending_tables() iterates dist->lpi_xa using xa_for_each()
> and dereferences the returned struct vgic_irq in the loop body without
> holding a reference on the LPI.
>
> The xarray iterator only provides temporary RCU coverage while looking up
> the current entry. That is not sufficient for this loop body, which reads
> fields from struct vgic_irq and performs guest memory accesses before the
> iteration completes.
>
> [...]
Applied to next, thanks!
[1/1] KVM: arm64: vgic-v3: take an LPI reference in vgic_v3_save_pending_tables
https://git.kernel.org/kvmarm/kvmarm/c/f5b8f203bfc0
--
Best,
Oliver
prev parent reply other threads:[~2026-08-08 18:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-07 2:55 [PATCH v2] KVM: arm64: vgic-v3: take an LPI reference in vgic_v3_save_pending_tables Qihang
2026-08-07 7:52 ` Marc Zyngier
2026-08-08 18:35 ` Oliver Upton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178621413201.380376.9463585617788229094.b4-ty@kernel.org \
--to=oupton@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=q.h.hack.winter@gmail.com \
--cc=stable@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox