From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD39DC54E4A for ; Fri, 23 Feb 2024 09:07:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Q83iE9Azq6IMKejSo9/zyfSugRoFAYJJyW81zrReD08=; b=vn3ZojBJONTdMl Ntw6kRCc5cFxEaNiLcvb1BJCajnf6Py6ev5zlAdooExoa2EcXtVFm9+hQQEUw1687QUMDfuqdBowk dvUen+ZY/rZoQmsWQw+LyoAKrx97nUFICWtngwqMBmll1Os8rwOuquId+E5r0Yv559NssXA09vhB+ fxw4/qevKUbU+nYoYce4KNSYHe+MFkjp+uBwbRnkr3dORdnNyYhAldF33eBsLEAkWQADUoA3Edzwd 419XhT9j4Lss+/XhMa1wlzLQq/sCIMBosmefhWea5VHJRo49vnZGR3PewLZfz9lR3OoOVEUkNXn6/ SpurwductHACaNuPPx4g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdRW4-00000008bdP-0C3c; Fri, 23 Feb 2024 09:07:00 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdRVw-00000008bbr-0uWM for linux-arm-kernel@lists.infradead.org; Fri, 23 Feb 2024 09:06:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1708679200; x=1740215200; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=VgtHxEGL1VIdQ9PPu9qSENiuIzT8Bdf8Y4csSbIwc7k=; b=pO8eSohefAOBFF+gz6wbQWB9+Cmunj9h0ud/NkGy4654si0g10Iiw+VK uU4PsUEh/ywufxtdtecNuvKEkRPSm41XkLY0MQsO/v9XwM6GGsRB3bD11 43kB8pB3HGAfcJSoNlULn0pzfL82zdj8ECkhBMWwFBqTWuk0nqENHIF4x QEuaSivFxsGtEctTe+zGubhyomakXmiBFmIIrIDQ96QHvnw1POaxfaJ25 ISz383afI+HqxKE/QXAxyiohUDIGUgDS8K6JB3Z/8w4NOwfMolOjWThx4 I7xKrcyynsxUSAb71eaj0fKK/rY9RwPcPgpUtfoB9u7E/VzDWJmVodRid w==; X-IronPort-AV: E=Sophos;i="6.06,179,1705359600"; d="scan'208";a="35562337" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 23 Feb 2024 10:06:34 +0100 Received: from steina-w.localnet (steina-w.tq-net.de [10.123.53.25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id F316D280075; Fri, 23 Feb 2024 10:06:33 +0100 (CET) From: Alexander Stein To: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, shengjiu.wang@gmail.com Cc: Shengjiu Wang Subject: Re: [PATCH 1/2] arm64: dts: imx8mp-evk: Add HDMI audio sound card support Date: Fri, 23 Feb 2024 10:06:33 +0100 Message-ID: <1786327.VLH7GnMWUR@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <1708675339-8180-1-git-send-email-shengjiu.wang@nxp.com> References: <1708675339-8180-1-git-send-email-shengjiu.wang@nxp.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240223_010640_715706_54621392 X-CRM114-Status: GOOD ( 16.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, thanks for the patch. Am Freitag, 23. Februar 2024, 09:02:18 CET schrieb Shengjiu Wang: > The AUD2HTX is a digital module that provides a bridge between > the Audio Subsystem and the HDMI RTX Subsystem. This > module includes intermediate storage to queue SDMA transactions > prior to being synchronized and passed to the HDMI > RTX Subsystem over the Audio Link. > = > AUD2HTX works as the cpu dai in HDMI audio sound card. > = > Signed-off-by: Shengjiu Wang > --- > arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 12 ++++++++++++ > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 10 ++++++++++ > 2 files changed, 22 insertions(+) > = > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts b/arch/arm64/bo= ot/dts/freescale/imx8mp-evk.dts > index f87fa5a948cc..63f6e72fa18a 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts > @@ -138,6 +138,14 @@ simple-audio-card,codec { > = > }; > = > + sound-hdmi { > + compatible =3D "fsl,imx-audio-hdmi"; > + model =3D "audio-hdmi"; > + audio-cpu =3D <&aud2htx>; > + hdmi-out; > + status =3D "okay"; No need for 'status' here. Don't you need to configure the PAI as well? See [1] for downstream implementation. I'm wondering because I had to hack something similar. Without I got no HDMI audio. Best regards, Alexander [1] https://github.com/Freescale/linux-fslc/blob/6.1-2.0.x-imx/drivers/gpu/= drm/imx/imx8mp-hdmi-pavi.c#L51-L59 > + }; > + > reserved-memory { > #address-cells =3D <2>; > #size-cells =3D <2>; > @@ -191,6 +199,10 @@ &A53_3 { > cpu-supply =3D <®_arm>; > }; > = > +&aud2htx { > + status =3D "okay"; > +}; > + > &eqos { > pinctrl-names =3D "default"; > pinctrl-0 =3D <&pinctrl_eqos>; > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/= dts/freescale/imx8mp.dtsi > index 9ab9c057f41e..721ab630d895 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > @@ -1513,6 +1513,16 @@ micfil: audio-controller@30ca0000 { > status =3D "disabled"; > }; > = > + aud2htx: aud2htx@30cb0000 { > + compatible =3D "fsl,imx8mp-aud2htx"; > + reg =3D <0x30cb0000 0x10000>; > + interrupts =3D ; > + clocks =3D <&audio_blk_ctrl IMX8MP_CLK_AUDIOMIX_AUD2HTX_IPG>; > + clock-names =3D "bus"; > + dmas =3D <&sdma2 26 2 0>; > + dma-names =3D "tx"; > + status =3D "disabled"; > + }; > }; > = > sdma3: dma-controller@30e00000 { > = -- = TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel