Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Hemanth Selam <hemanth.selam@gmail.com>
To: Fuad Tabba <fuad.tabba@linux.dev>
Cc: Marc Zyngier <maz@kernel.org>, Oliver Upton <oupton@kernel.org>,
	Joey Gouly <joey.gouly@arm.com>,
	Steffen Eiden <seiden@linux.ibm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Zenghui Yu <yuzenghui@huawei.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>, Andrew Lunn <andrew@lunn.ch>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev
Subject: Re: [PATCH 3/3] arm64: kvm: fix repeated word 'is' in comment
Date: Fri, 11 Sep 2026 13:55:59 +0530	[thread overview]
Message-ID: <178911515996.474202.18153234548688379981@gmail.com> (raw)
In-Reply-To: <CA+EHjTwW64qwPPAY7GpGWnW7kTHgK+NOycPD+ztZLu8MxhKEgg@mail.gmail.com>

On Fri, 4 Sept 2026 at 13:46, Fuad Tabba wrote:
> The typo here is that the first "is" should have been an "it", rather
> than being a duplicate.

You are right, and the patch as I sent it makes the sentence worse
rather than better.  Please drop 3/3; it should not be applied.

I should have read the sentence instead of the checkpatch warning, and
Andrew made the same point in this thread.  I have stopped treating that
warning as a list of things to fix.

The comment still reads "assumes that is is run from EL2".  If you would
like the correction, the line should be:

   * This code assumes that it is run from EL2, and that it is part of

and I will send it as a single patch, or leave it for whoever next
touches the file, whichever you prefer.

Thanks for catching it,
Hemanth



  reply	other threads:[~2026-09-11  8:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260904122445.31163-1-hemanth.selam@gmail.com>
2026-09-04 12:24 ` [PATCH 1/3] arm64: kvm: fix typo "synchonized" in comment Hemanth Selam
2026-09-04 12:24 ` [PATCH 2/3] selftests: kvm: fix typos in comments Hemanth Selam
2026-09-04 12:24 ` [PATCH 3/3] arm64: kvm: fix repeated word 'is' in comment Hemanth Selam
2026-09-04 12:46   ` Fuad Tabba
2026-09-11  8:25     ` Hemanth Selam [this message]
2026-09-04 19:29   ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178911515996.474202.18153234548688379981@gmail.com \
    --to=hemanth.selam@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=catalin.marinas@arm.com \
    --cc=fuad.tabba@linux.dev \
    --cc=joey.gouly@arm.com \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maz@kernel.org \
    --cc=oupton@kernel.org \
    --cc=seiden@linux.ibm.com \
    --cc=suzuki.poulose@arm.com \
    --cc=will@kernel.org \
    --cc=yuzenghui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox