From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5AB5CC88E4A for ; Fri, 11 Sep 2026 11:25:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Message-ID:Date :Cc:To:From:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UTTG8yan6yVoKZGPEDLowwJNC987s9yGpXDxZ0pvHPw=; b=mqVIwltgqdFHsEghqTX9irAG5k ePpdMTPGyYmbFw/ZQi+KT1om/a9AK4yn0KT3W7j1jbYkHzCcg5LSGrgA3U05ruGSEA7zPz30Oc6WE VnMAcK/MzOTrR8UOIA29hhpg8r91c73AVr5LZli4GRgpVZ/gtq7YGzoIkq9Ejkn3CpoUiCe+ZCAXe qaF0DtRmN2tJs7WLhl7bFj0u/3/PUn9v2h7WZSxIOlWXshJgT9aZwCQmsp3r5k3YL1n8tFxcUjD0z 25TJQeFfCAVg8NPpxB5q5+4NW245ugYJw6VeX5NKNrbktkcnPcgSoKTlPxw4iao7A964i4MGQzT/s wV0ke4Ig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x4zNY-0000000GUKX-16cr; Fri, 11 Sep 2026 11:25:12 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x4zNV-0000000GUKE-3yCF for linux-arm-kernel@lists.infradead.org; Fri, 11 Sep 2026 11:25:10 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 314EF60A58; Fri, 11 Sep 2026 11:25:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75D4F1F00893; Fri, 11 Sep 2026 11:25:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789125908; bh=UTTG8yan6yVoKZGPEDLowwJNC987s9yGpXDxZ0pvHPw=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=XczocO6d55CVKrVVPATsFg2zy9sPS0Jxt22hCBVDF65gfZ3jm+YUfeomUJzOzLD3B ntD0sMYNbEZML9W0CoFx1p7KeP5KBaNFZMAAKVS/r6cNo3EMEEQPtTNg17I/t3pFl0 yI0TiH3T5LZHy5pkGtpARjkzt7WIuOaS7rwAX9VeQSqaQEFRJJO/81gKVYj2zdZkGB OHqSUoGDPsn+1fJgxNlmvjs3WcnjRZIC5Yw9oJGqec1HtJL6sWJs4Ldd1s409E5xsF +cB3TdRh8iFYJER57+PZA4jVz3IFW9pg8usW7WPNeinfvYgirww97B88N5c+fFNssD HR29fmBvobvSg== Subject: Re: [PATCH net-next v2 1/9] dt-bindings: net: ti,dp83867: add supply properties From: netdev-bot+sashiko@kernel.org To: mohd.anwar@oss.qualcomm.com Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, afd@ti.com, andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk, richardcochran@gmail.com, andersson@kernel.org, konradybcio@kernel.org, alexandre.torgue@foss.st.com, peppe.cavallaro@st.com, joabreu@synopsys.com, maxime.chevallier@bootlin.com, mcoquelin.stm32@gmail.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Date: Fri, 11 Sep 2026 11:25:07 +0000 Message-ID: <178912590701.219967.15448701667812128746@kernel.org> In-Reply-To: <20260908-shikra_ethernet-v2-1-bbe3389d0652@oss.qualcomm.com> References: <20260908-shikra_ethernet-v2-1-bbe3389d0652@oss.qualcomm.com> X-sashiko-severity: Low Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: Critical: 0 · High: 0 · Medium: 0 · Low: 1 - [Low] Reported concern (assessed INVALID): the binding patch adds four regulator-consumer properties (vdda-2p5-supply, vdd-1p0-supply,… -- dt-bindings: net: ti,dp83867: add supply properties This documents four regulator consumer properties for the DP83867 PHY (vdda-2p5-supply, vdd-1p0-supply, vdda-1p8-supply and vddio-supply), matching the two-supply and three-supply configurations described in the datasheet plus the separate VDDIO rail. Documentation-only change, no code is touched. No Link: tags present in the commit header. > diff --git a/Documentation/devicetree/bindings/net/ti,dp83867.yaml b/Documentation/devicetree/bindings/net/ti,dp83867.yaml > index 4bc1f98fd9fe5..e78f08ded3d0d 100644 > --- a/Documentation/devicetree/bindings/net/ti,dp83867.yaml > +++ b/Documentation/devicetree/bindings/net/ti,dp83867.yaml > @@ -118,6 +118,20 @@ properties: > Transmitt FIFO depth- see dt-bindings/net/ti-dp83867.h for applicable > values. > > + vdda-2p5-supply: > + description: 2.5V analog supply (connected to the VDDA2P5 pins). > + > + vdd-1p0-supply: > + description: 1.0V digital core supply (connected to the VDD1P0 pins). > + > + vdda-1p8-supply: > + description: 1.8V analog supply (connected to the VDDA1P8 pins). > + > + vddio-supply: > + description: | > + I/O supply (connected to the VDDIO pins). The supply can be 1.8V, > + 2.5V or 3.3V. > + [Severity: Low] One thing that came up while reading this in isolation: at this commit drivers/net/phy/dp83867.c has no regulator API usage, so the four new properties describe DT ABI with no in-tree consumer yet. Is that intentional for this patch of the series? Checking the rest of the series answers it, so this looks fine as posted. The following patch, "net: phy: dp83867: add regulator supply management", adds dp83867_power_on() with: static const char * const supply_names[] = { "vdda-2p5", "vdd-1p0", "vdda-1p8", "vddio", }; ... ret = devm_regulator_get_enable_optional(dev, supply_names[i]); and dp83867_probe() calls dp83867_power_on() before dp83867_of_init() and before any register programming in dp83867_config_init(), with the datasheet stabilization delay applied there. The supply IDs match the property names documented here exactly, and the enable reference taken by devm_regulator_get_enable_optional() keeps the regulator core's late cleanup from turning the rails back off. So no change is being requested here; noting it only in case the documentation is meant to land ahead of the driver change. -- Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260908-shikra_ethernet-v2-0-bbe3389d0652%40oss.qualcomm.com