From: Miquel Raynal <miquel.raynal@bootlin.com>
To: alexandre.belloni@bootlin.com, Wentao Liang <vulab@iscas.ac.cn>
Cc: bbrezillon@kernel.org, claudiu.beznea@tuxon.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
nicolas.ferre@microchip.com, richard@nod.at, vigneshr@ti.com,
stable@vger.kernel.org
Subject: Re: [PATCH] mtd: rawnand: atmel: Fix MCK clock leak in atmel_nand_controller_init()
Date: Fri, 25 Sep 2026 15:35:45 +0200 [thread overview]
Message-ID: <179034334517.1124555.16021884625975139988.b4-ty@bootlin.com> (raw)
In-Reply-To: <20260917102924.2146959-1-vulab@iscas.ac.cn>
On Thu, 17 Sep 2026 10:29:24 +0000, Wentao Liang wrote:
> atmel_nand_controller_init() takes a reference to the MCK clock with
> of_clk_get() and keeps it in nc->mck for the lifetime of the
> controller. If the "atmel,smc" phandle is missing or the SMC regmap
> cannot be obtained afterwards, the error path jumps to out_release_dma
> which only releases the DMA channel, so the clock reference is leaked.
> The callers return the error directly and never run
> atmel_nand_controller_cleanup(), where the clock is normally put.
>
> [...]
Applied to nand/next, thanks!
[1/1] mtd: rawnand: atmel: Fix MCK clock leak in atmel_nand_controller_init()
commit: 94edcda45d888c3bb1310de11e10e4537c166f00
Patche(s) should be available on mtd/linux.git and will be
part of the next PR (provided that no robot complains by then).
Kind regards,
Miquèl
prev parent reply other threads:[~2026-09-25 13:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 10:29 [PATCH] mtd: rawnand: atmel: Fix MCK clock leak in atmel_nand_controller_init() Wentao Liang
2026-09-25 13:35 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179034334517.1124555.16021884625975139988.b4-ty@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=alexandre.belloni@bootlin.com \
--cc=bbrezillon@kernel.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=nicolas.ferre@microchip.com \
--cc=richard@nod.at \
--cc=stable@vger.kernel.org \
--cc=vigneshr@ti.com \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox