[PATCH 0/2] Fix compilation errors with pruss APIs

[PATCH 0/2] Fix compilation errors with pruss APIs

[MD Danish Anwar]

The APIs in 'include/linux/pruss_driver.h' produce compilation errors and
warnings when config symbol CONFIG_TI_PRUSS is not enabled.

This series fixes those errors / warnings.

Also the header file 'include/linux/pruss_driver.h' is orphan and has no
entry in MAINTAINERS file. Patch 2/2 of the series adds the entry for this
file in MAINTAINERS file

MD Danish Anwar (2):
  soc: ti: pruss: Fix pruss APIs
  MAINTAINERS: Add entry for linux/pruss_driver.h

 MAINTAINERS                  |  1 +
 include/linux/pruss_driver.h | 12 ++++++------
 2 files changed, 7 insertions(+), 6 deletions(-)


base-commit: 7fa366f1b6e376c38966faa42da7f0f2e013fdab
-- 
2.34.1

[PATCH 1/2] soc: ti: pruss: Fix pruss APIs

[MD Danish Anwar]

PRUSS APIs in pruss_driver.h produce lots of compilation errors when
CONFIG_TI_PRUSS is not set.

The errors and warnings,
warning: returning 'void *' from a function with return type 'int' makes
	integer from pointer without a cast [-Wint-conversion]
error: expected identifier or '(' before '{' token

Fix these warnings and errors by fixing the return type of pruss APIs as
well as removing the misplaced semicolon from pruss_cfg_xfr_enable()

Fixes: 0211cc1e4fbb ("soc: ti: pruss: Add helper functions to set GPI mode, MII_RT_event and XFR")
Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
---
 include/linux/pruss_driver.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/include/linux/pruss_driver.h b/include/linux/pruss_driver.h
index c9a31c567e85..2e18fef1a2e1 100644
--- a/include/linux/pruss_driver.h
+++ b/include/linux/pruss_driver.h
@@ -144,32 +144,32 @@ static inline int pruss_release_mem_region(struct pruss *pruss,
 static inline int pruss_cfg_get_gpmux(struct pruss *pruss,
 				      enum pruss_pru_id pru_id, u8 *mux)
 {
-	return ERR_PTR(-EOPNOTSUPP);
+	return -EOPNOTSUPP;
 }
 
 static inline int pruss_cfg_set_gpmux(struct pruss *pruss,
 				      enum pruss_pru_id pru_id, u8 mux)
 {
-	return ERR_PTR(-EOPNOTSUPP);
+	return -EOPNOTSUPP;
 }
 
 static inline int pruss_cfg_gpimode(struct pruss *pruss,
 				    enum pruss_pru_id pru_id,
 				    enum pruss_gpi_mode mode)
 {
-	return ERR_PTR(-EOPNOTSUPP);
+	return -EOPNOTSUPP;
 }
 
 static inline int pruss_cfg_miirt_enable(struct pruss *pruss, bool enable)
 {
-	return ERR_PTR(-EOPNOTSUPP);
+	return -EOPNOTSUPP;
 }
 
 static inline int pruss_cfg_xfr_enable(struct pruss *pruss,
 				       enum pru_type pru_type,
-				       bool enable);
+				       bool enable)
 {
-	return ERR_PTR(-EOPNOTSUPP);
+	return -EOPNOTSUPP;
 }
 
 #endif /* CONFIG_TI_PRUSS */
-- 
2.34.1

Re: [PATCH 1/2] soc: ti: pruss: Fix pruss APIs

[Roger Quadros]

On 18/12/2024 12:44, MD Danish Anwar wrote:
> PRUSS APIs in pruss_driver.h produce lots of compilation errors when
> CONFIG_TI_PRUSS is not set.
> 
> The errors and warnings,
> warning: returning 'void *' from a function with return type 'int' makes
> 	integer from pointer without a cast [-Wint-conversion]
> error: expected identifier or '(' before '{' token
> 
> Fix these warnings and errors by fixing the return type of pruss APIs as
> well as removing the misplaced semicolon from pruss_cfg_xfr_enable()
> 
> Fixes: 0211cc1e4fbb ("soc: ti: pruss: Add helper functions to set GPI mode, MII_RT_event and XFR")
> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>

Reviewed-by: Roger Quadros <rogerq@kernel.org>

[PATCH 2/2] MAINTAINERS: Add entry for linux/pruss_driver.h

[MD Danish Anwar]

include/linux/pruss_driver.h is an orphan file. Add entry for this in
the MAINATAINERS file.

Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index bc992f10a2f6..069817391e9f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -23638,6 +23638,7 @@ T:	git git://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
 F:	Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
 F:	drivers/pmdomain/ti/omap_prm.c
 F:	drivers/soc/ti/*
+F:	include/linux/pruss_driver.h
 
 TI LM49xxx FAMILY ASoC CODEC DRIVERS
 M:	M R Swami Reddy <mr.swami.reddy@ti.com>
-- 
2.34.1

Re: [PATCH 2/2] MAINTAINERS: Add entry for linux/pruss_driver.h

[Roger Quadros]

On 18/12/2024 12:44, MD Danish Anwar wrote:
> include/linux/pruss_driver.h is an orphan file. Add entry for this in
> the MAINATAINERS file.

s/MAINATAINERS/MAINTAINERS

> 
> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index bc992f10a2f6..069817391e9f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -23638,6 +23638,7 @@ T:	git git://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
>  F:	Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>  F:	drivers/pmdomain/ti/omap_prm.c
>  F:	drivers/soc/ti/*
> +F:	include/linux/pruss_driver.h
>  
>  TI LM49xxx FAMILY ASoC CODEC DRIVERS
>  M:	M R Swami Reddy <mr.swami.reddy@ti.com>