From: TAKANO Mitsuhiro <takano32@gmail.com>
To: James Clark <james.clark@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
TAKANO Mitsuhiro <takano32@gmail.com>
Subject: Re: [PATCH] arm64: perf: Fix the userspace counter example link
Date: Wed, 11 Nov 2026 02:33:49 +0000 [thread overview]
Message-ID: <179436442976.1969388.1279174885793827001@gmail.com> (raw)
In-Reply-To: <1baeb4ec-4244-42e0-8c53-29df079c80f6@linaro.org>
You are right on all three points, and the middle one was worse than a
style choice: I measured it after your message and "perf test -v user"
does not run the cases in mmap-basic.c at all. It matches the tests
whose name contains "user" and runs those; the mmap interface cases that
file provides are 175.x, so the v1 changelog was wrong about what the
command runs as well.
So v2 does what you suggested instead of pointing somewhere else:
the sentence that sends the reader to another file, and its link target,
are both gone. The How-to section above already names test-evsel.c as
the example, so the instruction for running an example moves there, next
to the reference it belongs to:
make -C tools/lib/perf make-tests
tools/lib/perf/tests-static
I built that pair from a clean tree before writing it down, and the
Makefile target produces both tests-static and tests-shared.
The section on heterogeneous systems keeps its text about the PMU type
number; it just no longer ends with an example pointer that was to a file
which does not exist.
prev parent reply other threads:[~2026-11-11 2:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 23:45 [PATCH] arm64: perf: Fix the userspace counter example link TAKANO Mitsuhiro
2026-11-09 11:19 ` James Clark
2026-11-11 2:33 ` TAKANO Mitsuhiro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179436442976.1969388.1279174885793827001@gmail.com \
--to=takano32@gmail.com \
--cc=james.clark@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox