From: netdev-bot+sashiko@kernel.org
To: aiyengar1990@gmail.com
Cc: maxime.chevallier@bootlin.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org,
pabeni@redhat.com, wens@kernel.org, jernej.skrabec@gmail.com,
samuel@sholland.org, mcoquelin.stm32@gmail.com,
alexandre.torgue@foss.st.com, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev,
linux-stm32@st-md-mailman.stormreply.com,
linux-kernel@vger.kernel.org, clabbe.montjoie@gmail.com
Subject: Re: [PATCH net-next v2 2/2] net: stmmac: dwmac-sun8i: Enable jumbo frames up to MTU 2018
Date: Mon, 16 Nov 2026 13:54:25 +0000 [thread overview]
Message-ID: <179483726554.3136.14444857396156719322@kernel.org> (raw)
In-Reply-To: <20261112-sun8i-emac-jumbo-v2-2-aca0cf23cf17@gmail.com>
Thank you for your contribution! Sashiko AI review found 2 potential
issue(s) to consider.
Critical: 0 · High: 0 · Medium: 1 · Low: 1
If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).
- [Medium] The commit message says "A device tree max-frame-size can
still lower it", but for this driver that is false.
- [Low] The max_mtu clamp fixes a real, user-visible bug, but the commit
is framed as a feature ("Enable jumbo frames") and has no Fixes: tag.
--
net: stmmac: dwmac-sun8i: Enable jumbo frames up to MTU 2018
This patch sets the JUMBO_FRM_EN bit in EMAC_RX_CTL0 from
sun8i_dwmac_core_init(), so the sun8i EMAC accepts frames longer than 1518
bytes. It also clamps plat_dat->maxmtu to 2018 in sun8i_dwmac_probe(). With
that limit, a frame with two VLAN tags and the FCS fits in a single 2044
byte descriptor buffer.
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
> index 0c82662fbe6ea..a18d3daf6a3ff 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
[ ... ]
> @@ -645,6 +659,15 @@ static void sun8i_dwmac_core_init(struct mac_device_info *hw,
>
> v = (8 << EMAC_BURSTLEN_SHIFT); /* burst len */
> writel(v, ioaddr + EMAC_BASIC_CTL1);
> +
> + /* Without JUMBO_FRM_EN the receiver flags every frame longer than
> + * 1518 bytes (1522 with a VLAN tag) as a length error, so any MTU
> + * above 1500 is unusable. Frames are still bounded by the RX
> + * descriptor buffer size, see EMAC_MAX_MTU.
> + */
> + v = readl(ioaddr + EMAC_RX_CTL0);
> + v |= EMAC_RX_JUMBO_FRM_EN;
> + writel(v, ioaddr + EMAC_RX_CTL0);
> }
[Severity: Low]
JUMBO_FRM_EN is now set unconditionally. A peer can therefore send oversized
frames that reach the RX DMA even at the default MTU of 1500, and those
frames span several descriptors.
Dropping them correctly depends on commit 834ec9530832 ("net: stmmac: drop
split frames on AF_XDP zero-copy RX"). That commit made
ndesc_get_rx_status() return discard_frame | rx_not_ls for non-last
descriptors, and made stmmac_rx() test status & discard_frame and drain the
split frame.
On a tree without that commit, wouldn't stmmac_rx() treat the last fragment
of such a frame as a new packet? The commit message cites 834ec9530832 only
as background. Could it be listed as a prerequisite for backporters?
Related to this, the max_mtu clamp in sun8i_dwmac_probe() also fixes an
existing problem, but the patch has no Fixes: tag. Before this patch, the
driver advertised a max_mtu of 3712 and was in this state:
- stmmac_hw_init() forces chain mode for STMMAC_FLAG_HAS_SUN8I.
- stmmac_xmit() calls stmmac_is_jumbo_frm() only for enh_desc.
- norm_set_tx_desc_len_on_chain() masks the length to 11 bits:
p->des1 |= cpu_to_le32(len & TDES1_BUFFER1_SIZE_MASK);
So with an MTU between 2048 and 3712, a linear TX frame longer than 2047
bytes was silently truncated. Would a Fixes: tag make sense for that part?
[ ... ]
> @@ -1209,6 +1232,7 @@ static int sun8i_dwmac_probe(struct platform_device *pdev)
> plat_dat->mac_setup = sun8i_dwmac_setup;
> plat_dat->tx_fifo_size = 4096;
> plat_dat->rx_fifo_size = 16384;
> + plat_dat->maxmtu = min(plat_dat->maxmtu, EMAC_MAX_MTU);
[Severity: Medium]
The commit message says:
A device tree max-frame-size can still lower it.
Is that true for this driver? stmmac_probe_config_dt() reads the property
only for a few compatibles:
stmmac_platform.c:stmmac_probe_config_dt() {
...
if (of_device_is_compatible(np, "st,spear600-gmac") ||
of_device_is_compatible(np, "snps,dwmac-3.50a") ||
of_device_is_compatible(np, "snps,dwmac-3.70a") ||
of_device_is_compatible(np, "snps,dwmac-3.72a") ||
of_device_is_compatible(np, "snps,dwmac")) {
...
of_property_read_u32(np, "max-frame-size", &plat->maxmtu);
...
}
None of the compatibles in sun8i_dwmac_match[] can carry an snps,dwmac
fallback under allwinner,sun8i-a83t-emac.yaml. So plat_dat->maxmtu always
holds the JUMBO_LEN default (9000) when this min() runs, and the line always
sets it to 2018.
The binding does accept max-frame-size on these nodes, because it includes
snps,dwmac.yaml through allOf, and that pulls in ethernet-controller.yaml.
If a board sets max-frame-size to cap the MTU for a PHY or switch limit, the
driver ignores it without a warning.
Should the commit message be corrected, or should the driver parse
max-frame-size itself?
If the property is ever parsed for these nodes, the min() has a second
problem. plat->maxmtu is an int filled by of_property_read_u32(). A value
below min_mtu, or one that is negative as an int, passes straight through
min(). stmmac_dvr_probe() then only warns:
if (priv->plat->maxmtu < ndev->min_mtu)
dev_warn(priv->device,
"%s: warning: maxmtu having invalid value (%d)\n",
__func__, priv->plat->maxmtu);
else if (priv->plat->maxmtu < ndev->max_mtu)
ndev->max_mtu = priv->plat->maxmtu;
In that case ndev->max_mtu stays at SKB_MAX_HEAD(NET_SKB_PAD + NET_IP_ALIGN).
Wouldn't that bring back the TX truncation and the RX split-frame drops that
this patch is meant to prevent?
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261112-sun8i-emac-jumbo-v2-0-aca0cf23cf17%40gmail.com
prev parent reply other threads:[~2026-11-16 13:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 8:41 [PATCH net-next v2 0/2] net: stmmac: dwmac-sun8i: Jumbo frames and an RX_TH fix Arun Iyengar via B4 Relay
2026-11-12 8:41 ` [PATCH net-next v2 1/2] net: stmmac: dwmac-sun8i: Fix the RX_TH threshold encoding Arun Iyengar via B4 Relay
2026-11-12 9:43 ` Nicolai Buchwitz
2026-11-12 13:32 ` Chen-Yu Tsai
2026-11-12 8:41 ` [PATCH net-next v2 2/2] net: stmmac: dwmac-sun8i: Enable jumbo frames up to MTU 2018 Arun Iyengar via B4 Relay
2026-11-12 9:46 ` Nicolai Buchwitz
2026-11-12 14:30 ` Chen-Yu Tsai
2026-11-16 13:54 ` netdev-bot+sashiko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179483726554.3136.14444857396156719322@kernel.org \
--to=netdev-bot+sashiko@kernel.org \
--cc=aiyengar1990@gmail.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=maxime.chevallier@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=samuel@sholland.org \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox