Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Fil Dunsky <filipp.dunsky@gmail.com>
To: Bartosz Golaszewski <brgl@kernel.org>
Cc: Linus Walleij <linusw@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 2/2] gpio: Add Cortina Systems CS75xx GPIO driver
Date: Thu, 19 Nov 2026 14:01:58 +0300	[thread overview]
Message-ID: <179508611881.4.16899217970121840224@gmail.com> (raw)
In-Reply-To: <ndapsfnk4wdon57ihawkorz5rwrhxsb7ql3mujqvuu6ixi4sbc@ugtxsjqt7gcc>

Hi Bart,

On Thu, Nov 19, 2026 at 11:32:23AM +0100, Bartosz Golaszewski wrote:
> Can you please address sashiko comments?

Yes. The spurious edge IRQ is fixed in v5: after programming the trigger
and polarity, set_type clears the latched interrupt status before the
line can be unmasked. This was tested on the Almond+ reset button, with
the pin mux configured separately by the test kernel.

ARCH_CORTINA_ACCESS is defined in arch/arm/mach-goldengate/Kconfig by the
CS75xx platform series [1], which is still under review and not in
mainline yet. The GPIO driver has no code dependency on it and can be
built independently with COMPILE_TEST. The architecture symbol allows
enabling the driver normally once the platform support is present.
I have clarified this in the v5 cover letter.

I am sending v5 with the IRQ fix and the updated explanation.

[1] https://lore.kernel.org/all/20261114-b4-cs75xx-v7-0-8f17f38821b4@gmail.com/

Thanks,
Fil



      reply	other threads:[~2026-11-19 11:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  2:08 [PATCH v4 0/2] gpio: Add Cortina Systems CS75xx GPIO driver Fil Dunsky via B4 Relay
2026-11-16  2:08 ` [PATCH v4 1/2] dt-bindings: gpio: Add Cortina Systems CS7542 GPIO controller Fil Dunsky via B4 Relay
2026-11-16 11:36   ` Krzysztof Kozlowski
2026-11-16  2:08 ` [PATCH v4 2/2] gpio: Add Cortina Systems CS75xx GPIO driver Fil Dunsky via B4 Relay
2026-11-16 14:33   ` Linus Walleij
2026-11-19 10:32   ` Bartosz Golaszewski
2026-11-19 11:01     ` Fil Dunsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179508611881.4.16899217970121840224@gmail.com \
    --to=filipp.dunsky@gmail.com \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox