Re: [PATCH v3 2/5] dt-bindings: arm: blaize: Add Blaize BLZP1600 SoC

From: Nikolaos Pasaloukos <nikolaos.pasaloukos@blaize.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	"robh@kernel.org" <robh@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org"
	<krzysztof.kozlowski+dt@linaro.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
	"will@kernel.org" <will@kernel.org>,
	"arnd@arndb.de" <arnd@arndb.de>,
	"olof@lixom.net" <olof@lixom.net>,
	Neil Jones <neil.jones@blaize.com>,
	Matt Redfearn <matthew.redfearn@blaize.com>,
	James Cowgill <james.cowgill@blaize.com>,
	"heiko.stuebner@cherry.de" <heiko.stuebner@cherry.de>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"macromorgan@hotmail.com" <macromorgan@hotmail.com>,
	"sre@kernel.org" <sre@kernel.org>,
	"hvilleneuve@dimonoff.com" <hvilleneuve@dimonoff.com>,
	"andre.przywara@arm.com" <andre.przywara@arm.com>,
	"rafal@milecki.pl" <rafal@milecki.pl>,
	"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
	"andersson@kernel.org" <andersson@kernel.org>,
	"konrad.dybcio@linaro.org" <konrad.dybcio@linaro.org>,
	"geert+renesas@glider.be" <geert+renesas@glider.be>,
	"neil.armstrong@linaro.org" <neil.armstrong@linaro.org>,
	"m.szyprowski@samsung.com" <m.szyprowski@samsung.com>,
	"nfraprado@collabora.com" <nfraprado@collabora.com>,
	"u-kumar1@ti.com" <u-kumar1@ti.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 2/5] dt-bindings: arm: blaize: Add Blaize BLZP1600 SoC
Date: Thu, 25 Apr 2024 10:20:49 +0100	[thread overview]
Message-ID: <17953924-bf09-4eba-b8d6-1f828f39c0a2@blaize.com> (raw)
In-Reply-To: <f45a76b3-996f-4204-9b9c-289d40767708@linaro.org>

On 25/04/2024 10:16, Krzysztof Kozlowski wrote:
> On 25/04/2024 11:15, Niko Pasaloukos wrote:
>> Add device tree bindings for the Blaize BLZP1600 CB2
>> development board (carrier board), which uses the
>> BLZP1600 SoM.
>>
>> Reviewed-by: James Cowgill <james.cowgill@blaize.com>
>> Reviewed-by: Matt Redfearn <matt.redfearn@blaize.com>
>> Reviewed-by: Neil Jones <neil.jones@blaize.com>
>> Signed-off-by: Nikolaos Pasaloukos <nikolaos.pasaloukos@blaize.com>
>> ---
>>  .../devicetree/bindings/arm/blaize.yaml       | 40 +++++++++++++++++++
>>  1 file changed, 40 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/arm/blaize.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/arm/blaize.yaml b/Documentation/devicetree/bindings/arm/blaize.yaml
>> new file mode 100644
>> index 000000000000..8034aeb7a2b4
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/arm/blaize.yaml
>> @@ -0,0 +1,40 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: https://urldefense.com/v3/__http://devicetree.org/schemas/arm/blaize.yaml*__;Iw!!FddXBOku!i6XKbnL3gXmoklJKfuksrfCB61MTEFuw8JiIVn9sS0CzEmHpqDhXguC5Me3sUQt1gw4RxA4mo8TAHR8psxBV0Dmrs0veWKlRgo18$ 
>> +$schema: https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!FddXBOku!i6XKbnL3gXmoklJKfuksrfCB61MTEFuw8JiIVn9sS0CzEmHpqDhXguC5Me3sUQt1gw4RxA4mo8TAHR8psxBV0Dmrs0veWEVjMhqf$ 
>> +
>> +title: Blaize Platforms
>> +
>> +maintainers:
>> +  - James Cowgill <james.cowgill@blaize.com>
>> +  - Matt Redfearn <matt.redfearn@blaize.com>
>> +  - Neil Jones <neil.jones@blaize.com>
>> +  - Nikolaos Pasaloukos <nikolaos.pasaloukos@blaize.com>
>> +
>> +description: |
>> +  Blaize Platforms using SoCs designed by Blaize Inc.
>> +
>> +  The products currently based on the BLZP1600 SoC:
>> +
>> +  - BLZP1600-SoM: SoM module
>> +  - BLZP1600-CB2: Development board CB2 based on BLZP1600-SoM
>> +
>> +  The compatible property should follow the format:
>> +
>> +  compatible = "blaize,blzp1600-cb2", "blaize,blzp1600";
> 
> This is a friendly reminder during the review process.
> 
> It seems my or other reviewer's previous comments were not fully
> addressed. Maybe the feedback got lost between the quotes, maybe you
> just forgot to apply it. Please go back to the previous discussion and
> either implement all requested changes or keep discussing them.
> 
> Thank you.
> 
> Best regards,
> Krzysztof
> 

Apologies, you are right. Now with the threading fixed, I'll be able to gather all the feedback properly.
I'll fix this on V4.

Best regards,
Niko

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel