From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CFD8AEDE99A for ; Tue, 10 Sep 2024 16:47:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yUa3TLnRUIgVIBOiAVf2d1Rp6JcumIEXWfBSjgDQ8Oo=; b=bTy1Mk6VSbN+EoDgpmb4r5Vzqh wGsR/ci4/7eDoYhSPP5ajQlR8nybM6oU9SVHSpgwsk6szxpSplaXlkpuS3Cn/EKlEqlNHgRhHOj20 K6ezSgiLHxJU/ByeNiMqag/SM8Q20CM2kDt2pGI0zuN4fSxpHfzXvxfmy+SQ3a5ZWq4kbvW7p/VgT ScQs3GJSq1DGwMWYUlfkDKNDyrGtKDsJ780Wokl/Tf0cvKlk8eVxNaVXuGJOGendtpQOJllD+4L8U RlHSo7cmq6EUoworn/ciFtIexchrFt+LlEf89/7Wxbh9WK+4n26k6dKo5hkJBLie3gylvQ5UNt/kw /FNxbXBw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1so41G-00000006Pps-2gYB; Tue, 10 Sep 2024 16:47:10 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1so3sJ-00000006Mex-0Osx; Tue, 10 Sep 2024 16:37:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=yUa3TLnRUIgVIBOiAVf2d1Rp6JcumIEXWfBSjgDQ8Oo=; b=Xo9nJXF74V8gMBzUmSZ96XzpCK V0luRgiAHN4MhSDj3P4e1VklMl3LrZbtIMcu9GaUgOTfoAPWDwM6qi1drgoaGCHQ4cA+J8+k5laru x9YzXc4fUUgUxklnMScdN8rOnwpO71QhSLcVmJFN1abK/+s1J3P07CmnCPOonerecZmgp2F8DnHrs 7hxEKSbGdolTzLgxa3tIva67RUfXrKNEMv1g00kvM/rWbIw1VbVpES0GYLcMnBkj7zykPD7Dgo7F3 QHwzx9Nn/bb3N7LMdoqin1ExRbaWTCvISmQ78ddHn3zgiIs9HsQzzdbsCxJhITo86Xq78ZaIRjb9c gpRUd6zA==; Received: from i53875a02.versanet.de ([83.135.90.2] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1so3rr-0006Fs-F9; Tue, 10 Sep 2024 18:37:27 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Sandy Huang , Andy Yan , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mark Yao , Sascha Hauer , Cristian Ciocaltea Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@collabora.com, Alexandre ARNOUD , Luis de Arquer , Algea Cao Subject: Re: [PATCH v6 3/3] drm/rockchip: Add basic RK3588 HDMI output support Date: Tue, 10 Sep 2024 18:39:54 +0200 Message-ID: <1796743.esFFXGZ24q@diego> In-Reply-To: <324b12ea-805a-499c-909d-3723f0bca7cb@collabora.com> References: <20240906-b4-rk3588-bridge-upstream-v6-0-a3128fb103eb@collabora.com> <1899262.u6TykanW85@diego> <324b12ea-805a-499c-909d-3723f0bca7cb@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240910_093755_206734_A6234127 X-CRM114-Status: GOOD ( 21.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Dienstag, 10. September 2024, 17:41:42 CEST schrieb Cristian Ciocaltea: > On 9/10/24 6:21 PM, Heiko St=FCbner wrote: > > Am Dienstag, 10. September 2024, 17:07:57 CEST schrieb Heiko St=FCbner: > >> Am Freitag, 6. September 2024, 03:17:42 CEST schrieb Cristian Ciocalte= a: > >>> The RK3588 SoC family integrates the newer Synopsys DesignWare HDMI 2= =2E1 > >>> Quad-Pixel (QP) TX controller IP and a HDMI/eDP TX Combo PHY based on= a > >>> Samsung IP block. > >>> > >>> Add just the basic support for now, i.e. RGB output up to 4K@60Hz, > >>> without audio, CEC or any of the HDMI 2.1 specific features. > >>> > >>> Co-developed-by: Algea Cao > >>> Signed-off-by: Algea Cao > >>> Tested-by: Heiko Stuebner > >>> Signed-off-by: Cristian Ciocaltea > >> > >> I had switched from the v3 to this v6 in my playground-kernel today, > >> with v3 I've never seen those, but now with v6 I have gotten multiple > >> times: > >> > >> [ 805.730608] Internal error: synchronous external abort: 00000000960= 00010 [#1] PREEMPT SMP > >> [ 805.739764] Modules linked in: snd_soc_simple_card crct10dif_ce snd= _soc_simple_card_utils panthor drm_gpuvm drm_exec fuse > >> [ 805.752031] CPU: 3 UID: 0 PID: 775 Comm: Xorg Not tainted 6.11.0-rc= 7-00099-g459302f1f908-dirty #934 > >> [ 805.762143] Hardware name: Theobroma Systems RK3588-Q7 SoM on Haiko= u devkit (DT) > >> [ 805.770407] pstate: 204000c9 (nzCv daIF +PAN -UAO -TCO -DIT -SSBS B= TYPE=3D--) > >> [ 805.778186] pc : regmap_mmio_read32le+0x8/0x20 > >> [ 805.783155] lr : regmap_mmio_read+0x44/0x70 > >> [ 805.787828] sp : ffff80008293b830 > >> [ 805.791516] x29: ffff80008293b830 x28: ffff80008293bce8 x27: ffff00= 01f20ab080 > >> [ 805.799495] x26: ffff800081139500 x25: 0000000000000000 x24: 000000= 0000000010 > >> [ 805.807472] x23: 0000000000000000 x22: ffff0001f5a4b400 x21: ffff80= 008293b8c4 > >> [ 805.815450] x20: 0000000000000968 x19: ffff0001f5a27a80 x18: 000000= 0000000070 > >> [ 805.823428] x17: 0002441400000005 x16: 000004650441043c x15: 043800= 0008980804 > >> [ 805.831406] x14: 07d8089807800780 x13: 0438000008980804 x12: ffff80= 0081133630 > >> [ 805.839384] x11: 0002441400000005 x10: 000004650441043c x9 : ffff80= 0081a59000 > >> [ 805.847361] x8 : 07d8089807800780 x7 : 0000000000000000 x6 : ffff00= 01f5b453c0 > >> [ 805.855339] x5 : ffff800080750dc0 x4 : 0000000000000968 x3 : 000000= 0000000968 > >> [ 805.863316] x2 : ffff800080751520 x1 : 0000000000000968 x0 : ffff80= 0083b20968 > >> [ 805.871294] Call trace: > >> [ 805.874012] regmap_mmio_read32le+0x8/0x20 > >> [ 805.878588] _regmap_bus_reg_read+0x6c/0xac > >> [ 805.883262] _regmap_read+0x60/0xd8 > >> [ 805.887159] _regmap_update_bits+0xf4/0x140 > >> [ 805.891832] regmap_update_bits_base+0x64/0xa0 > >> [ 805.896797] dw_hdmi_qp_bridge_atomic_enable+0x134/0x220 > >> [ 805.902734] drm_atomic_bridge_chain_enable+0x54/0xc8 > >> [ 805.908380] drm_atomic_helper_commit_modeset_enables+0x194/0x280 > >> [ 805.915190] drm_atomic_helper_commit_tail_rpm+0x50/0xa0 > >> [ 805.921125] commit_tail+0xa0/0x1a0 > >> [ 805.925021] drm_atomic_helper_commit+0x17c/0x1b0 > >> [ 805.930276] drm_atomic_commit+0xb8/0x100 > >> [ 805.934754] drm_atomic_connector_commit_dpms+0xe0/0x110 > >> [ 805.940690] drm_mode_obj_set_property_ioctl+0x1c0/0x420 > >> [ 805.946626] drm_connector_property_set_ioctl+0x3c/0x68 > >> [ 805.952465] drm_ioctl_kernel+0xc0/0x130 > >> [ 805.956846] drm_ioctl+0x214/0x4a0 > >> [ 805.960643] __arm64_sys_ioctl+0xac/0xf8 > >> [ 805.965025] invoke_syscall+0x48/0x104 > >> [ 805.969214] el0_svc_common.constprop.0+0x40/0xe0 > >> [ 805.974470] do_el0_svc+0x1c/0x28 > >> [ 805.978171] el0_svc+0x34/0xe0 > >> [ 805.981582] el0t_64_sync_handler+0x120/0x12c > >> [ 805.986449] el0t_64_sync+0x190/0x194 > >> [ 805.990540] Code: d503201f d503201f f9400000 8b214000 (b9400000) > >> > >> I guess that might be some clocking issue? > >=20 > > Forgot to add, this happens when the display has blanked and then is > > supposed to unblank again. >=20 > Hmm, I've never encountered this while testing with my v6.11-rc1 based > tree. What is your current kernel base? Did you change it while > switching from v3 to v6? >=20 > I'll rebase my tree onto latest linux-next and see if I can reproduce. The setup is 6.11-rc7 with your hdmi series + my wip dsi + X11 running on top. At some point after being idle a while this blanks the display, which will probably turn off clocks and such. After moving the mouse or just doing anything else that unblanks the display, that splat happens. Apart from updating mesa from 24.2.0 to 24.2.2 I haven't changed anything in my test-setup so far.