From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dmaengine: pl330: Fix linker error "undefined reference to `__aeabi_uldivmod'"
Date: Thu, 13 Nov 2014 17:49:05 +0100 [thread overview]
Message-ID: <1799482.v2vqT9blFd@wuerfel> (raw)
In-Reply-To: <1415896047.1787.4.camel@linaro.org>
On Thursday 13 November 2014 16:27:27 Jon Medhurst wrote:
> 32-bit ARM kernels may have a 64-bit dma_addr_t but have no
> implementation of the compiler helper for 64-bit unsigned division,
> therefore the use of the modulo operator in pl330_prep_dma_memcpy causes
> the link error "undefined reference to `__aeabi_uldivmod'"
>
> As the burst value is always a power of two we can fix the problem, and
> make the code more efficient, by replacing "% burst" with "& (burst-1)".
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Jon Medhurst <tixy@linaro.org>
>
Just saw the same thing and was going to send a different patch, but
yours is better.
Acked-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2014-11-13 16:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 16:27 [PATCH] dmaengine: pl330: Fix linker error "undefined reference to `__aeabi_uldivmod'" Jon Medhurst (Tixy)
2014-11-13 16:49 ` Arnd Bergmann [this message]
2014-11-13 17:01 ` Vinod Koul
2014-11-13 17:11 ` Jon Medhurst (Tixy)
2014-11-17 8:23 ` Vinod Koul
2014-11-13 17:02 ` Joe Perches
2014-11-13 18:19 ` Jon Medhurst (Tixy)
2014-11-13 18:28 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1799482.v2vqT9blFd@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).