From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] net: stmmac: dwmac-rk: add rk3366 & rk3399 specific data
Date: Thu, 11 Aug 2016 10:12:44 +0200 [thread overview]
Message-ID: <1799606.7CVTQCi7m5@diego> (raw)
In-Reply-To: <1470900288-10109-2-git-send-email-roger.chen@rock-chips.com>
Hi Roger,
Am Donnerstag, 11. August 2016, 15:24:46 schrieb Roger Chen:
> Add constants and callback functions for the dwmac on rk3228/rk3229 socs.
> As can be seen, the base structure is the same, only registers and the
> bits in them moved slightly.
>
> Signed-off-by: Roger Chen <roger.chen@rock-chips.com>
> ---
> .../devicetree/bindings/net/rockchip-dwmac.txt | 4 +-
> drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 226
> +++++++++++++++++++++ 2 files changed, 228 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.txt
> b/Documentation/devicetree/bindings/net/rockchip-dwmac.txt index
> cccd945..8c066e6 100644
> --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.txt
> +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.txt
> @@ -3,8 +3,8 @@ Rockchip SoC RK3288 10/100/1000 Ethernet driver(GMAC)
> The device node has following properties.
>
> Required properties:
> - - compatible: Can be one of "rockchip,rk3228-gmac",
> "rockchip,rk3288-gmac", -
> "rockchip,rk3368-gmac"
> + - compatible: Can be one of "rockchip,rk3288-gmac",
you're dropping the rk3228 here.
Otherwise looks fine, so with the compatible list fixed you can add my
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Heiko
next prev parent reply other threads:[~2016-08-11 8:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-11 7:24 [PATCH 0/3] support GMAC for RK3399 & RK3366 Roger Chen
2016-08-11 7:24 ` [PATCH 1/3] net: stmmac: dwmac-rk: add rk3366 & rk3399 specific data Roger Chen
2016-08-11 8:12 ` Heiko Stübner [this message]
2016-08-12 18:37 ` Rob Herring
2016-08-11 7:24 ` [PATCH 2/3] arm64: dts: rockchip: add GMAC dt nodes for rk3399 SoC Roger Chen
2016-08-11 7:24 ` [PATCH 3/3] arm64: dts: rockchip: add GMAC dt nodes for RK3399 evb Roger Chen
2016-09-01 11:39 ` [PATCH 0/3] support GMAC for RK3399 & RK3366 Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1799606.7CVTQCi7m5@diego \
--to=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).