From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15BDCC77B7C for ; Fri, 26 May 2023 08:37:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+9DPu8toFgTklVG9SsROiLHP1J+zOBfRQsN5x3MICBo=; b=3zD7JXy2S3i5MR C3SQciZS49DHqoemBI1AivYH7bENoENLop7yszObXh4RLGCceBxRdzzeioI4c7LOr8vM9hUnKN7rs EKoBEAxYcyGF1r22QqwOw/CdRfIR3sutk1218TMnkr1FQRfDJQljmTHUtX05w/0yM9ezyWieC3Mp6 K1j06hh/+4m32wFpr6QTKR/PZ42+AYbZ+L/jOfYS0vUjZp9LBTyMAS2ztq/TzfDR4XEjR+2oqyT/V wYaxdTuv1waRxh3TT7X96pCZwAZOKBqKjncGLmSMaWM0e/ZJYi3gtzxthKQJNyrhCPMaub4WmFa/x 3dBL0NPu3f/phqvMiZHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q2Sw7-001cwc-37; Fri, 26 May 2023 08:36:35 +0000 Received: from madras.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e5ab]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q2Sw4-001cvV-1X; Fri, 26 May 2023 08:36:33 +0000 Received: from [IPV6:2001:b07:2ed:14ed:a962:cd4d:a84:1eab] (unknown [IPv6:2001:b07:2ed:14ed:a962:cd4d:a84:1eab]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 2F34B6606E83; Fri, 26 May 2023 09:36:26 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1685090187; bh=Y+IJxiWc633XOBZbB2+BJidraljDp8EXXiUQb5yaXZU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=kpszq4hXIKce8PXvPTFmhLX/QqAmnkIe2GlYur04oNEP2DB+Ty24ObhrS9VHyNi3f jvPhgysl5tFu9/L/tA5WQQq+iYFKmPnirKuzSetjd7j1x1VE2eUStQkfnCHxkputL7 B13Ve7LfYoMADZslX7CQrB8U08I+vDZ15MrHQQtfmgeGjC6fRO5jYkC4vreXnY6q2u UISI0P0JCQOYYCf8os8otZ9K81NSeX6/N5K2aLr0bthLzegi0fmqtqrB9467rdOUQ3 OrIZZucUTGg3otczqteuOumrR6oNUmi21vmfZDCX9sC3j48qhE02QlmP6nUx7c1hxq Mb1TGrXiu7mjg== Message-ID: <17ac612b-4464-4a97-4e4d-5e053b760130@collabora.com> Date: Fri, 26 May 2023 10:36:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v2 2/8] iio: adc: rockchip_saradc: Add support for RK3588 Content-Language: en-US To: Shreeya Patel , jic23@kernel.org, lars@metafoo.de, heiko@sntech.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, sebastian.reichel@collabora.com Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com, gustavo.padovan@collabora.com, serge.broslavsky@collabora.com, Simon Xue References: <20230525212712.255406-1-shreeya.patel@collabora.com> <20230525212712.255406-3-shreeya.patel@collabora.com> From: AngeloGioacchino Del Regno In-Reply-To: <20230525212712.255406-3-shreeya.patel@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230526_013632_669618_B80B3F86 X-CRM114-Status: GOOD ( 16.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Il 25/05/23 23:27, Shreeya Patel ha scritto: > From: Simon Xue > > Add new start and read functions to support rk3588 device. > Also, add a device compatible string for the same. > > Signed-off-by: Simon Xue > Signed-off-by: Shreeya Patel > --- > > Changes in v2 > - Add a from address. > - Create separate patches for adding new device support and changes to > the old device code. > - Make use of FIELD_PREP. > > drivers/iio/adc/rockchip_saradc.c | 69 +++++++++++++++++++++++++++++++ > 1 file changed, 69 insertions(+) > > diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c > index 21f9d92a6af4..31637440be83 100644 > --- a/drivers/iio/adc/rockchip_saradc.c > +++ b/drivers/iio/adc/rockchip_saradc.c You're missing a header... #include after adding that, you can get my Reviewed-by: AngeloGioacchino Del Regno Cheers, Angelo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel