From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86F87EE49AB for ; Tue, 22 Aug 2023 20:17:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:To:Cc:From:Subject:References: In-Reply-To:MIME-Version:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PZEiT6LnTvU5BIM0FItq+jHhdljKAQ/aNVAuN81rEgY=; b=EbJ/jGFoh+IM8I S1hp6FTQcQsebJWxDMyuUKsJ2/aiWL0zWHAolYjSEH2xik/UMjFFxWX8ECoJHZMmxCUbraf3LiHEL LkNtrskBMYcBzvyERzrIGnGaGAS3bRURWx2MJh1j2XSS1hxmBF/kQZe4S/CjcnbohZ9WhWg5mYRlq B2BaAH2Nkbxyz7OSImf5VfZDO4lNvBy3hihLS9yMU0KSm5dhpAud3bxohkV5eIgjUOmBAwqmTr+MO 1gXZIoEy9ORjaacCpZK7rgrQt9Xtc1s2p34V0KnRf1m1dER5RrWX4FXsmXR480GoSUKmPYT9GM/ZR iVhHlIpJ00f1AZ8dlFow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qYXoZ-00GlN3-1s; Tue, 22 Aug 2023 20:17:23 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qYXoW-00GlMS-2o for linux-arm-kernel@lists.infradead.org; Tue, 22 Aug 2023 20:17:22 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B1186624CF; Tue, 22 Aug 2023 20:17:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 08250C433C7; Tue, 22 Aug 2023 20:17:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692735438; bh=QdTTuQ+Mug3wHUDRHlafLoo8YB7CrkNNHVFAfFK1fWs=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=A25SwGi5HWqRbBZutRVRGVmfML+PS/yJFx4jXa6520tJU1uwK95Ffppwy2i5WiKiv v3J+HSJN0eyaazJRietKvypvI3PzVq/odPmXjF3RQYvxOprHcXai4Ofo9M7b8N9ttz akFjpPXlRIjZDECWg82v8UxpboUlyjfasfACpKDllLh/boOznPgTDMRM3QfvLTWvlQ /ZPeISUawzQKZpd5jPhd7Gav+bQiPBgz9VF+dClu1LBnpQ0XMQSHcrI/qYAeO5dAl+ ybYqevHnqZcV7oaCtOjXDg0Um/zQdpzlsPCYT/yJ6kxxdNS6reSEX+bG/pkAgd24Uu q9J1h798v9UEw== Message-ID: <17bd83d833b59fd4f64eec433589fa55.sboyd@kernel.org> MIME-Version: 1.0 In-Reply-To: <20230811161446.636253-2-cristian.marussi@arm.com> References: <20230811161446.636253-1-cristian.marussi@arm.com> <20230811161446.636253-2-cristian.marussi@arm.com> Subject: Re: [PATCH 1/6] firmware: arm_scmi: Simplify enable/disable Clock operations From: Stephen Boyd Cc: sudeep.holla@arm.com, james.quinlan@broadcom.com, f.fainelli@gmail.com, vincent.guittot@linaro.org, etienne.carriere@linaro.org, peng.fan@oss.nxp.com, chuck.cannon@nxp.com, souvik.chakravarty@arm.com, nicola.mazzucato@arm.com, Cristian Marussi , Michael Turquette , linux-clk@vger.kernel.org To: Cristian Marussi , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Tue, 22 Aug 2023 13:17:15 -0700 User-Agent: alot/0.10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230822_131720_958401_24E657D7 X-CRM114-Status: GOOD ( 15.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Cristian Marussi (2023-08-11 09:14:41) > Add a param to Clock enable/disable operation to ask for atomic operation > and remove _atomic version of such operations. Why? > > No functional change. > > CC: Michael Turquette > CC: Stephen Boyd > CC: linux-clk@vger.kernel.org > Signed-off-by: Cristian Marussi > --- > drivers/clk/clk-scmi.c | 8 ++++---- > drivers/firmware/arm_scmi/clock.c | 24 ++++++------------------ > include/linux/scmi_protocol.h | 9 ++++----- > 3 files changed, 14 insertions(+), 27 deletions(-) > > diff --git a/drivers/clk/clk-scmi.c b/drivers/clk/clk-scmi.c > index 2c7a830ce308..ff003083e592 100644 > --- a/drivers/clk/clk-scmi.c > +++ b/drivers/clk/clk-scmi.c > @@ -78,28 +78,28 @@ static int scmi_clk_enable(struct clk_hw *hw) > { > struct scmi_clk *clk = to_scmi_clk(hw); > > - return scmi_proto_clk_ops->enable(clk->ph, clk->id); > + return scmi_proto_clk_ops->enable(clk->ph, clk->id, false); > } > > static void scmi_clk_disable(struct clk_hw *hw) > { > struct scmi_clk *clk = to_scmi_clk(hw); > > - scmi_proto_clk_ops->disable(clk->ph, clk->id); > + scmi_proto_clk_ops->disable(clk->ph, clk->id, false); I enjoyed how it was before because I don't know what 'false' means without looking at the ops now. > } > > static int scmi_clk_atomic_enable(struct clk_hw *hw) > { > struct scmi_clk *clk = to_scmi_clk(hw); > > - return scmi_proto_clk_ops->enable_atomic(clk->ph, clk->id); > + return scmi_proto_clk_ops->enable(clk->ph, clk->id, true); > } > > static void scmi_clk_atomic_disable(struct clk_hw *hw) > { > struct scmi_clk *clk = to_scmi_clk(hw); > > - scmi_proto_clk_ops->disable_atomic(clk->ph, clk->id); > + scmi_proto_clk_ops->disable(clk->ph, clk->id, true); > } > > /* _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel