From: Krzysztof Kozlowski <krzk@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
David Jander <david@protonic.nl>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH v1] arm: dts: st: Add MECIO1 and MECT1S board variants
Date: Tue, 6 Aug 2024 15:31:15 +0200 [thread overview]
Message-ID: <17c21be3-5bdc-48e5-b005-be6018a49106@kernel.org> (raw)
In-Reply-To: <ZrIiCX89nRDLvXtC@pengutronix.de>
On 06/08/2024 15:15, Oleksij Rempel wrote:
> On Tue, Aug 06, 2024 at 02:39:31PM +0200, Krzysztof Kozlowski wrote:
>> On 06/08/2024 14:03, Oleksij Rempel wrote:
>>> From: David Jander <david@protonic.nl>
>>>
>>> Introduce device tree support for the MECIO1 and MECT1S board variants.
>>> MECIO1 is an I/O and motor control board used in blood sample analysis
>>> machines. MECT1S is a 1000Base-T1 switch for internal machine networks
>>> of blood sample analysis machines.
>>>
>>> Signed-off-by: David Jander <david@protonic.nl>
>>> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
>>> ---
>>> .../devicetree/bindings/arm/stm32/stm32.yaml | 8 +
>>> arch/arm/boot/dts/st/Makefile | 3 +
>>> arch/arm/boot/dts/st/stm32mp151c-mecio1r0.dts | 48 ++
>>> arch/arm/boot/dts/st/stm32mp151c-mect1s.dts | 297 ++++++++++
>>> arch/arm/boot/dts/st/stm32mp153c-mecio1r1.dts | 48 ++
>>> .../arm/boot/dts/st/stm32mp15x-mecio1-io.dtsi | 533 ++++++++++++++++++
>>> 6 files changed, 937 insertions(+)
>>> create mode 100644 arch/arm/boot/dts/st/stm32mp151c-mecio1r0.dts
>>> create mode 100644 arch/arm/boot/dts/st/stm32mp151c-mect1s.dts
>>> create mode 100644 arch/arm/boot/dts/st/stm32mp153c-mecio1r1.dts
>>> create mode 100644 arch/arm/boot/dts/st/stm32mp15x-mecio1-io.dtsi
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
>>> index 58099949e8f3a..703d4b574398d 100644
>>> --- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
>>
>> Please run scripts/checkpatch.pl and fix reported warnings. Then please
>> run `scripts/checkpatch.pl --strict` and (probably) fix more warnings.
>
> Ack, I see. stm32.yaml should be in separate patch.
Yes
>
>> Some warnings can be ignored, especially from --strict run, but the code
>> here looks like it needs a fix. Feel free to get in touch if the warning
>> is not clear.
>
> What should be done with "ethernet-phy-id2000.a284" appears
> un-documente warnings? Should it be handled by
> Documentation/devicetree/bindings/net/ethernet-phy.yaml?
I think it is documented. checkpatch is not accurate for this one.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-06 13:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-06 12:03 [PATCH v1] arm: dts: st: Add MECIO1 and MECT1S board variants Oleksij Rempel
2024-08-06 12:39 ` Krzysztof Kozlowski
2024-08-06 13:15 ` Oleksij Rempel
2024-08-06 13:31 ` Krzysztof Kozlowski [this message]
2024-08-06 13:43 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17c21be3-5bdc-48e5-b005-be6018a49106@kernel.org \
--to=krzk@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=david@protonic.nl \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox