From: tomasz.figa@gmail.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: s3c64xx: cpuidle: convert to platform driver
Date: Wed, 30 Oct 2013 23:40:24 +0100 [thread overview]
Message-ID: <1807659.lxGmRkUGnf@flatron> (raw)
In-Reply-To: <52717D97.8090905@linaro.org>
Hi Daniel,
On Wednesday 30 of October 2013 14:43:51 Daniel Lezcano wrote:
> On 10/25/2013 03:23 PM, Daniel Lezcano wrote:
>
> [ ... ]
>
> >>> Won't it be worth to add a new WFI_SLEEP state to the cpuidle driver
> >>> ?
> >>
> >> I don't think so. How a suspend-to-RAM specific thing like WFI_SLEEP
> >> could
> >> be relevant to a cpuidle driver? (Unless there are some plans to
> >> consolidate STR with cpuidle that I haven't heard about...)
> >
> > I finally found a documentation for the s3c6410x and the description
> > of
> > the different modes. Indeed, the sleep mode is not adequate for a
> > cpuidle state. What about the 'stop' and 'deep stop' state ?
>
> Hi Thomas,
>
> just a reminder about the question above, so I can go ahead: fix what
> you pointed out or remove the driver directly.
>
> You mentionned in the previous email the STOP is not usful because it
> can be controlled by manually outside of the cpuidle driver. But I see
> in the documentation, the stop states power gates the cpu and deep-stop
> stops the regulator.
STOP clock-gates the CPU and DEEP-STOP power-gates it by stopping the
regulator.
There are some interesting aspects of those modes, like memory self-
refresh, PLL power-off and system-wide down clocking, but I believe they
are too tricky to handle (coupling with device PM, stopped timers) and
with too little possible power saving to justify the effort of adding
support for them.
In the end, I haven't seen support for them implemented even in strange
vendor kernels used even on production devices, like Android phones.
>
> If these states have to been added later, still it worth to remove the
> driver ?
I don't think that anybody is even going to add support for them and by
anybody I should probably mean myself, since I'm currently the only person
actively adding new code for this platform, as a part of my hobby.
Best regards,
Tomasz
next prev parent reply other threads:[~2013-10-30 22:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-25 7:11 [PATCH 1/2] ARM: s3c64xx: cpuidle: convert to platform driver Daniel Lezcano
2013-10-25 7:11 ` [PATCH 2/2] ARM: s3c64xx: cpuidle: move driver to drivers/cpuidle Daniel Lezcano
2013-10-25 10:39 ` [PATCH 1/2] ARM: s3c64xx: cpuidle: convert to platform driver Tomasz Figa
2013-10-25 19:13 ` Daniel Lezcano
2013-10-25 20:52 ` Tomasz Figa
2013-10-25 22:23 ` Daniel Lezcano
2013-10-30 21:43 ` Daniel Lezcano
2013-10-30 22:40 ` Tomasz Figa [this message]
2013-10-30 22:50 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1807659.lxGmRkUGnf@flatron \
--to=tomasz.figa@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).