From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A12BAC43458 for ; Mon, 13 Jul 2026 20:26:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: References:In-Reply-To:Date:To:From:Subject:Message-ID:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=en6i9rQnKxSjXYUiFYKBBZmYxCjty6UKB+7+YcGtULk=; b=XQYFtQcp4oUoeyMgKI/m21aaZN C5bzI943uYR7lD+X2yIAVXmejwyeiSaKBpOPJEn2C/W5utF/2bNAT0r9L6fnfS5wikwvczDMX7Clg mq0TFlmzP2XOOS7Mn2/IJZ0QxDWPIclkEre1yA7695gdANZUQer4+zMbLAZcBwN7eVJ9AjUJZnxxK P0tB2JJWI/7eg3q1Hr77IfxKkjWB37GOmfFa6CijAOaxtWupbmO2zUeXN4DMuTgRnFzfVTMtkFw32 VY3lEkYVxFsUyS/fvNldU7bFgE7WirRvJKhVOChTicyXvm0VgFEiOx47EbH6XHwff4Uq81nbY/lb+ yqPH/KyQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wjNEV-0000000AMQB-3LJW; Mon, 13 Jul 2026 20:26:31 +0000 Received: from bali.collaboradmins.com ([2a01:4f8:201:9162::2]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wjNET-0000000AMPi-0XMo; Mon, 13 Jul 2026 20:26:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1783974385; bh=rb6mPYklYuYVHSZpGzru92M8ezjoY2NpIOKtf3TKwQY=; h=Subject:From:To:Date:In-Reply-To:References:From; b=Ukp+njbZqtrisGCjs0oI4f/B+7gVLnS4w0sfAsVar8euI9r+Oq8JpFbM2/BMdqQxS dzjrD9ioHa8hE4SXzuN8aEybwx2l5RvzLEbmvdeHuqdic0j3k1ZG3AIBF7RbnwN916 zBUiKQr3a9S6Jdc2uKgs4z7C3IcwkoLXNcKINq2gMFGwU3La09SP2biOTgOy/eEZrJ 5jpNuv7cPIyxJe3ZveweXtro1gckv2B5buD9cfrPNntD7p/7KtBrVr3AjsnCxiE33I yvj7Mo9RK7caTpiXZLpytiTyBlOZHoats214PWtv0AW6AUO/dCRkvwKMtpZu2YYa81 jMrjcJbn1a8JQ== Received: from [100.64.0.214] (unknown [100.64.0.214]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange secp256r1 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nicolas) by bali.collaboradmins.com (Postfix) with ESMTPSA id 8C9E617E095B; Mon, 13 Jul 2026 22:26:23 +0200 (CEST) Message-ID: <1812cb35e3f3bf459201b2d7830b0877fd5520a6.camel@collabora.com> Subject: Re: [PATCH v15 07/12] media: mediatek: jpeg: fix resolution change event handling in decoder From: Nicolas Dufresne To: Kyrie Wu , Hans Verkuil , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Date: Mon, 13 Jul 2026 16:26:21 -0400 In-Reply-To: <20260702072614.10373-8-kyrie.wu@mediatek.com> References: <20260702072614.10373-1-kyrie.wu@mediatek.com> <20260702072614.10373-8-kyrie.wu@mediatek.com> Autocrypt: addr=nicolas.dufresne@collabora.com; prefer-encrypt=mutual; keydata=mDMEaCN2ixYJKwYBBAHaRw8BAQdAM0EHepTful3JOIzcPv6ekHOenE1u0vDG1gdHFrChD /e0J05pY29sYXMgRHVmcmVzbmUgPG5pY29sYXNAbmR1ZnJlc25lLmNhPoicBBMWCgBEAhsDBQsJCA cCAiICBhUKCQgLAgQWAgMBAh4HAheABQkJZfd1FiEE7w1SgRXEw8IaBG8S2UGUUSlgcvQFAmibrjo CGQEACgkQ2UGUUSlgcvQlQwD/RjpU1SZYcKG6pnfnQ8ivgtTkGDRUJ8gP3fK7+XUjRNIA/iXfhXMN abIWxO2oCXKf3TdD7aQ4070KO6zSxIcxgNQFtDFOaWNvbGFzIER1ZnJlc25lIDxuaWNvbGFzLmR1Z nJlc25lQGNvbGxhYm9yYS5jb20+iJkEExYKAEECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4 AWIQTvDVKBFcTDwhoEbxLZQZRRKWBy9AUCaCyyxgUJCWX3dQAKCRDZQZRRKWBy9ARJAP96pFmLffZ smBUpkyVBfFAf+zq6BJt769R0al3kHvUKdgD9G7KAHuioxD2v6SX7idpIazjzx8b8rfzwTWyOQWHC AAS0LU5pY29sYXMgRHVmcmVzbmUgPG5pY29sYXMuZHVmcmVzbmVAZ21haWwuY29tPoiZBBMWCgBBF iEE7w1SgRXEw8IaBG8S2UGUUSlgcvQFAmibrGYCGwMFCQll93UFCwkIBwICIgIGFQoJCAsCBBYCAw ECHgcCF4AACgkQ2UGUUSlgcvRObgD/YnQjfi4+L8f4fI7p1pPMTwRTcaRdy6aqkKEmKsCArzQBAK8 bRLv9QjuqsE6oQZra/RB4widZPvphs78H0P6NmpIJ Organization: Collabora Canada Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-2pGwts7IlWDue0rFiGli" User-Agent: Evolution 3.60.2 (3.60.2-1.fc44) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260713_132629_325233_32C939BA X-CRM114-Status: GOOD ( 17.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --=-2pGwts7IlWDue0rFiGli Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Le jeudi 02 juillet 2026 =C3=A0 15:26 +0800, Kyrie Wu a =C3=A9crit=C2=A0: > This patch refines the handling of resolution change events within > JPEG decoder worker. The `mtk_jpeg_set_queue_data` function is now > called to set up queue data before signaling a source change through > `mtk_jpeg_queue_src_chg_event`. By reorganizing these calls, the > patch ensures that necessary queue information is updated prior to > transitioning the context state to `MTK_JPEG_SOURCE_CHANGE`. > A condition is added to exit early if the context is already in the > `MTK_JPEG_SOURCE_CHANGE` state, preventing redundant operations and > improving processing efficiency. >=20 > Fixes: dedc21500334 ("media: mtk-jpegdec: add jpeg decode worker interfac= e") > Signed-off-by: Kyrie Wu Reviewed-by: Nicolas Dufresne > --- > =C2=A0drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c | 6 +++++- > =C2=A01 file changed, 5 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c b/drive= rs/media/platform/mediatek/jpeg/mtk_jpeg_core.c > index 4dc574e03bd5..02efaed198b8 100644 > --- a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c > +++ b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c > @@ -1737,11 +1737,15 @@ static void mtk_jpegdec_worker(struct work_struct= *work) > =C2=A0 > =C2=A0 if (mtk_jpeg_check_resolution_change(ctx, > =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 &jpeg_src_buf->dec_param)) { > - mtk_jpeg_queue_src_chg_event(ctx); > + mtk_jpeg_set_queue_data(ctx, &jpeg_src_buf->dec_param); > =C2=A0 ctx->state =3D MTK_JPEG_SOURCE_CHANGE; > + mtk_jpeg_queue_src_chg_event(ctx); > =C2=A0 goto getbuf_fail; > =C2=A0 } > =C2=A0 > + if (ctx->state =3D=3D MTK_JPEG_SOURCE_CHANGE) > + goto getbuf_fail; > + > =C2=A0 mtk_jpegdec_set_hw_param(ctx, hw_id, src_buf, dst_buf); > =C2=A0 ret =3D pm_runtime_resume_and_get(comp_jpeg[hw_id]->dev); > =C2=A0 if (ret < 0) { --=-2pGwts7IlWDue0rFiGli Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTvDVKBFcTDwhoEbxLZQZRRKWBy9AUCalVJ7QAKCRDZQZRRKWBy 9PUpAP9e8+xCQMSWuQo7VpP4zwepSnhUzH75b78q1mxYH9dD+gD/Yu05bs8tffuv QBNLFn3oWQTj7UBCWdc/BvI+ghLxnQg= =gtQ+ -----END PGP SIGNATURE----- --=-2pGwts7IlWDue0rFiGli--