From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6636BC43381 for ; Tue, 12 Mar 2019 14:18:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 36A2D2075C for ; Tue, 12 Mar 2019 14:18:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cgBtbB2D" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36A2D2075C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hsq68Tu17vjzsVf6Uzfmm73t8JfHeEhFfsf0yL0Duxc=; b=cgBtbB2DD7a2p4 +BreOPPO7MmG2c4mNiiZjgDhtEANbw2c9XI8pt8KOWcT1TaEZV4DoAtYkqcR6e4OLIo7oh49Tka+H 5zvxlNbSUPwNreeipaKhuEgbjcm78CckOtA02syobcwsWIa0RBuiZVcGRkV/BgwquZ7IcBKH/KFoC nKF7ajGG/Zprw9R430fKdzOUsnxAieEm5pdec2yOOByZE9THWtdqK5TctIahOR4mPH/LwBT8tIR8b FERkzW1T0QV0g7yxJ9WvKYsP1iOkTRor5pwTiUakUXLLMDZMuyRfwSprdp3RWgyS9gUSCTwndsW55 g0VUxhWcJYlc0iN5Fr2w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3iEr-0006gz-88; Tue, 12 Mar 2019 14:18:41 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3iEn-0006gD-56; Tue, 12 Mar 2019 14:18:38 +0000 Received: from we0652.dip.tu-dresden.de ([141.76.178.140] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1h3iEj-00025f-Rl; Tue, 12 Mar 2019 15:18:33 +0100 From: Heiko Stuebner To: David Summers Subject: Re: [PATCH v3 2/3] arm: dts: rk3288-tinker.dtsi: Enable WiFi Date: Tue, 12 Mar 2019 15:18:33 +0100 Message-ID: <1822354.MXcUDnUBre@phil> In-Reply-To: <20190309153923.22806-2-beagleboard@davidjohnsummers.uk> References: <20190217121513.22965-1-beagleboard@davidjohnsummers.uk> <20190309153923.22806-1-beagleboard@davidjohnsummers.uk> <20190309153923.22806-2-beagleboard@davidjohnsummers.uk> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190312_071837_343847_167A71E3 X-CRM114-Status: GOOD ( 19.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefan Wahren , devicetree@vger.kernel.org, Robin Murphy , linux-rockchip@lists.infradead.org, robh+dt@kernel.org, frowand.list@gmail.com, Tony McKahan , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Samstag, 9. M=E4rz 2019, 16:39:22 CET schrieb David Summers: > This patch adds wifi support to the ASUS Tinker Board (S) machines. > = > This is provided by an wifi card (RTL8723BS) wired into the sdio interfac= e. > = > It requires certain pins pulled, to enable the WiFi. > = > The schematics for these board do not show the WiFi connection, so the > connections have been taken from: > = > https://github.com/TinkerBoard/debian_kernel/blob/develop/arch/arm/boot/d= ts/rk3288-miniarm.dts > = > In particular the pulling of two pins. > = > This patch is almost identical to v1. A few additional line breaks for > readability. On Armbian, they did not use sd-uhs-ddr50, so this has > been removed. It does not change functionality. The ASUS patch set > sd-uhs-sdr104;. > = > Signed-off-by: David Summers > Signed-off-by: Stefan Wahren trying to understand the relationship here, is that a "Co-developed-by: Stefan Wahren <...>" case? Because individual Signed-off-bys would be (1) author, (2) sender and (3) me and Stefan obviously didn't send the patch :-) > Tested-by: Tony McKahan > Reviewed-by: Robin Murphy = > Test-by: TheSaint @ ArchLinux ARM = Same comment about Tested-by with an actual name+mail please. Other than that bit of bureaucracy this looks good, minus some reordering. If you need to resend for whatever reason, please try to order devicetree nodes and properties alphabetical if they don't have an address in the name (otherwise obviously by address). But I can do that reordering myself and also drop the Review-tag naming Robin above, if you clear up the "paperwork" above :-). Heiko Heiko > = > --- > arch/arm/boot/dts/rk3288-tinker.dtsi | 40 +++++++++++++++++++++++++++- > 1 file changed, 39 insertions(+), 1 deletion(-) > = > diff --git a/arch/arm/boot/dts/rk3288-tinker.dtsi b/arch/arm/boot/dts/rk3= 288-tinker.dtsi > index ef653c3209bc..0ffab1b7c940 100644 > --- a/arch/arm/boot/dts/rk3288-tinker.dtsi > +++ b/arch/arm/boot/dts/rk3288-tinker.dtsi > @@ -5,6 +5,7 @@ > = > #include "rk3288.dtsi" > #include > +#include > = > / { > chosen { > @@ -96,6 +97,17 @@ > startup-delay-us =3D <100000>; > vin-supply =3D <&vcc_io>; > }; > + > + sdio_pwrseq: sdio-pwrseq { > + compatible =3D "mmc-pwrseq-simple"; > + clocks =3D <&rk808 RK808_CLKOUT1>; > + clock-names =3D "ext_clock"; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&wifi_enable>; > + reset-gpios =3D <&gpio4 RK_PD3 GPIO_ACTIVE_LOW>, > + <&gpio4 RK_PD4 GPIO_ACTIVE_LOW>; > + }; > + > }; > = > &cpu0 { > @@ -336,7 +348,7 @@ > = > &io_domains { > status =3D "okay"; > - > + wifi-supply =3D <&vcc_18>; > sdcard-supply =3D <&vccio_sd>; > }; > = > @@ -416,6 +428,13 @@ > rockchip,pins =3D <7 8 RK_FUNC_GPIO &pcfg_pull_none>; > }; > }; > + > + sdio { > + wifi_enable: wifi-enable { > + rockchip,pins =3D <4 RK_PD3 RK_FUNC_GPIO &pcfg_pull_none>, > + <4 RK_PD4 RK_FUNC_GPIO &pcfg_pull_none>; > + }; > + }; > }; > = > &pwm0 { > @@ -440,6 +459,25 @@ > vqmmc-supply =3D <&vccio_sd>; > }; > = > +&sdio0 { > + bus-width =3D <4>; > + cap-sd-highspeed; > + cap-sdio-irq; > + keep-power-in-suspend; > + mmc-pwrseq =3D <&sdio_pwrseq>; > + non-removable; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&sdio0_bus4>, <&sdio0_cmd>, <&sdio0_clk>, <&sdio0_int>; > + max-frequency =3D <50000000>; > + sd-uhs-sdr12; > + sd-uhs-sdr25; > + sd-uhs-sdr50; > + vmmc-supply =3D <&vcc_io>; > + vqmmc-supply =3D <&vcc_18>; > + status =3D "okay"; > +}; > + > + > &tsadc { > rockchip,hw-tshut-mode =3D <1>; /* tshut mode 0:CRU 1:GPIO */ > rockchip,hw-tshut-polarity =3D <1>; /* tshut polarity 0:LOW 1:HIGH */ > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel