From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, FROM_EXCESS_BASE64,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12039C31E49 for ; Sun, 16 Jun 2019 11:05:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA10F20870 for ; Sun, 16 Jun 2019 11:05:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nLpYkZmE"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UwFN84U/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA10F20870 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GB1rT+pbfmYFdC4rg/Xr9hPx5ewh5oVB1DhTO4bOWaA=; b=nLpYkZmEyVQqu0 5eF9zV7LVqeFruJ54zlJecXmp/R+c3hAENwKQHRs3YgSIoTphLIFRMsTD4NU0ZdhFlC39/z6kEOqu iKX78WHep8PX+ieUrCzDXyUfKHds+sgVpHo9t/8AsmIAcPxD7JN8aVzxtOaesPpAnN058PtTpapgi 0lVGnHIxChA8XNKShpAUHUsbCvu9MY0K/CAQgYlmxA6GUIf1PMmMwqmH1ETU0I9of3XF1sbNzX/5E f718AVzfDnEMbs1c6gnoe0kpBixG4j74o+7I0HHb8tW1nVqwsAxtq6avDnWMWphQUV8DBU4hkIz97 X0fSlaW+rATHU8lqBPtA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hcSyQ-0004VI-Rq; Sun, 16 Jun 2019 11:05:22 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hcSyM-0004Ui-AL for linux-arm-kernel@lists.infradead.org; Sun, 16 Jun 2019 11:05:20 +0000 Received: by mail-wr1-x441.google.com with SMTP id n4so6817569wrw.13 for ; Sun, 16 Jun 2019 04:05:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jYpdMxao6pliYnnD2x77IZriJWD7lFq0HxazhfUGYeM=; b=UwFN84U/ghpHYCjJsDjNhvd0IG6uo6P/Ch88x8naJcdJ3LA2P+oVvUyG2OddL1IfWo Txz07ZLzHPkSr8t6uXZYv+JBxeYlPaL1q6TjnJV5i5NsIHi8otj703Hw439tfzCJmkx9 bhtZwyBGnDAfKH75NBMd9QFWoSzIRXN7SWKl/tUPS9VsqMtLYoA7ZItlJ0Qe6h6Gc1H4 qSmX/Z0FQ6FbVAP6j62fzdvl7Kx7qsJb3yVW+gAouv+ZrB1JfGLTsGPbBCjmTDsQIrUA xMoN/N5HJ9atne/L4VNVvkuBNudrkBYAjRmGwG1yPEPswZ9FqVwy4LkjPSgvi+gf6yz3 NADw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jYpdMxao6pliYnnD2x77IZriJWD7lFq0HxazhfUGYeM=; b=O/yCOk/alRTH3qkK0UsYayuoa7uPU5r8VkVk0Rr3KCYrjWNOaJKHMA3QU9O7JFXjJW KRO/OZNH+zoe5hFXbHZ4DXaTpAtR/o6FSk5n02vj3kO6DPLdJk/zZQALc6Lk6yFUFCT3 yNyo3+73d6qHSC8DwXTNoPBnuz302mJimPVfTy318NrsOqPXco+E9kRjD9rmfdyBf4lS ekypJ9R6wkREPrOVwLNLEf5Ug6gw+/Inbk16d1vS3emi1eB3TSgYNv5sEsSKcCKHnab6 c+GtjpQemPMCQcBIGWxklHm83YOLdcvCuQ1hPFDQOznvQLpBaEMNqfnqQWL4jTR8a2pf l+Yg== X-Gm-Message-State: APjAAAWDpj+rz5I0VTvuo3uYxMz0lGjiY3//jctPjmrRn2u4TuTOV2Wu PYqHwV773+AbR2nAoqGDd+o= X-Google-Smtp-Source: APXvYqzzqx42PAT4ueneqpG+etvE0yFc0vTzd9YPvagfFq04jv7+a+XjTXMN2fn6y898d3uHmGL14w== X-Received: by 2002:adf:ef8d:: with SMTP id d13mr55684452wro.60.1560683116461; Sun, 16 Jun 2019 04:05:16 -0700 (PDT) Received: from jernej-laptop.localnet (cpe-86-58-52-202.static.triera.net. [86.58.52.202]) by smtp.gmail.com with ESMTPSA id t1sm8457650wra.74.2019.06.16.04.05.13 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sun, 16 Jun 2019 04:05:14 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: linux-sunxi@googlegroups.com, megous@megous.com Subject: Re: [linux-sunxi] [PATCH v6 5/6] drm: sun4i: Add support for enabling DDC I2C bus to sun8i_dw_hdmi glue Date: Sun, 16 Jun 2019 13:05:13 +0200 Message-ID: <1823986.m04BvQ5ALy@jernej-laptop> In-Reply-To: <20190527162237.18495-6-megous@megous.com> References: <20190527162237.18495-1-megous@megous.com> <20190527162237.18495-6-megous@megous.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190616_040518_387984_F9F907AF X-CRM114-Status: GOOD ( 19.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Jose Abreu , Alexandre Torgue , devicetree@vger.kernel.org, Maxime Ripard , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, David Airlie , Chen-Yu Tsai , Rob Herring , linux-arm-kernel@lists.infradead.org, Daniel Vetter , Giuseppe Cavallaro , "David S. Miller" , Maxime Coquelin Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Ondrej! Dne ponedeljek, 27. maj 2019 ob 18:22:36 CEST je megous via linux-sunxi napisal(a): > From: Ondrej Jirman > > Orange Pi 3 board requires enabling a voltage shifting circuit via GPIO > for the DDC bus to be usable. > > Add support for hdmi-connector node's optional ddc-en-gpios property to > support this use case. > > Signed-off-by: Ondrej Jirman > --- > drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 55 +++++++++++++++++++++++++-- > drivers/gpu/drm/sun4i/sun8i_dw_hdmi.h | 3 ++ > 2 files changed, 55 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c > b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c index 39d8509d96a0..59b81ba02d96 > 100644 > --- a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c > +++ b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c > @@ -98,6 +98,30 @@ static u32 sun8i_dw_hdmi_find_possible_crtcs(struct > drm_device *drm, return crtcs; > } > > +static int sun8i_dw_hdmi_find_connector_pdev(struct device *dev, > + struct platform_device **pdev_out) > +{ > + struct platform_device *pdev; > + struct device_node *remote; > + > + remote = of_graph_get_remote_node(dev->of_node, 1, -1); > + if (!remote) > + return -ENODEV; > + > + if (!of_device_is_compatible(remote, "hdmi-connector")) { > + of_node_put(remote); > + return -ENODEV; > + } > + > + pdev = of_find_device_by_node(remote); > + of_node_put(remote); > + if (!pdev) > + return -ENODEV; > + > + *pdev_out = pdev; > + return 0; > +} > + > static int sun8i_dw_hdmi_bind(struct device *dev, struct device *master, > void *data) > { > @@ -151,16 +175,29 @@ static int sun8i_dw_hdmi_bind(struct device *dev, > struct device *master, return PTR_ERR(hdmi->regulator); > } > > + ret = sun8i_dw_hdmi_find_connector_pdev(dev, &hdmi->connector_pdev); > + if (!ret) { > + hdmi->ddc_en = gpiod_get_optional(&hdmi->connector_pdev- >dev, > + "ddc-en", GPIOD_OUT_HIGH); > + if (IS_ERR(hdmi->ddc_en)) { > + platform_device_put(hdmi->connector_pdev); > + dev_err(dev, "Couldn't get ddc-en gpio\n"); > + return PTR_ERR(hdmi->ddc_en); > + } > + } > + > ret = regulator_enable(hdmi->regulator); > if (ret) { > dev_err(dev, "Failed to enable regulator\n"); > - return ret; > + goto err_unref_ddc_en; > } > > + gpiod_set_value(hdmi->ddc_en, 1); Why don't you do that inside if clause where hdmi->ddc_en is assigned? It's not useful otherwise anyway. Besides, you would then only need to adjust one goto label in error path. > + > ret = reset_control_deassert(hdmi->rst_ctrl); > if (ret) { > dev_err(dev, "Could not deassert ctrl reset control\n"); > - goto err_disable_regulator; > + goto err_disable_ddc_en; > } > > ret = clk_prepare_enable(hdmi->clk_tmds); > @@ -213,8 +250,14 @@ static int sun8i_dw_hdmi_bind(struct device *dev, > struct device *master, clk_disable_unprepare(hdmi->clk_tmds); > err_assert_ctrl_reset: > reset_control_assert(hdmi->rst_ctrl); > -err_disable_regulator: > +err_disable_ddc_en: > + gpiod_set_value(hdmi->ddc_en, 0); > regulator_disable(hdmi->regulator); > +err_unref_ddc_en: > + if (hdmi->ddc_en) > + gpiod_put(hdmi->ddc_en); > + > + platform_device_put(hdmi->connector_pdev); > > return ret; > } > @@ -228,7 +271,13 @@ static void sun8i_dw_hdmi_unbind(struct device *dev, > struct device *master, sun8i_hdmi_phy_remove(hdmi); > clk_disable_unprepare(hdmi->clk_tmds); > reset_control_assert(hdmi->rst_ctrl); > + gpiod_set_value(hdmi->ddc_en, 0); > regulator_disable(hdmi->regulator); > + > + if (hdmi->ddc_en) > + gpiod_put(hdmi->ddc_en); > + > + platform_device_put(hdmi->connector_pdev); > } > > static const struct component_ops sun8i_dw_hdmi_ops = { > diff --git a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.h > b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.h index 720c5aa8adc1..dad66b8301c2 > 100644 > --- a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.h > +++ b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.h > @@ -9,6 +9,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -190,6 +191,8 @@ struct sun8i_dw_hdmi { > struct regulator *regulator; > const struct sun8i_dw_hdmi_quirks *quirks; > struct reset_control *rst_ctrl; > + struct platform_device *connector_pdev; It seems that connector_pdev is needed only during intialization. Why do you store it? Best regards, Jernej > + struct gpio_desc *ddc_en; > }; > > static inline struct sun8i_dw_hdmi * _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel