From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94FF0C3ABBC for ; Fri, 9 May 2025 08:15:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=k66pmCI1pT3vfBJYih/fR8R6maFESHCnrlUq6lhyU7E=; b=F/hkmvY9QSxhqt6ZmZaURETXjh jsMY6yJHzNT7lKZF8mZXemSgc7EOgpPnjjsRQXIJWsDNCnqAjQEIw0hReOxfsVPwnemwRKM5yD9Zx vt8hMFAwL5dcbyWPocoUHz9LtwG9PWxSZMDRCdDlI0ucvW6nijWV6l3HZFV02jQn7RJBkQtSCfubu PhzRLlJGKoe10m8kje8HOetYSvp05dVVXX7cHuMyTf/lmJ/2zjd1zGTdL+tjKNt5kfDTsyIXu0laq RrxXzOnkIQX4Y88GETGgOluDOcwJAN7+r37TQJf/8iKQnLodnq00kk4laFAUfEnPpdK+3gl6+oiuI AkJfQIkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uDItO-00000002tL1-1A28; Fri, 09 May 2025 08:15:38 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uDIS7-00000002npg-3TWg; Fri, 09 May 2025 07:47:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID; bh=k66pmCI1pT3vfBJYih/fR8R6maFESHCnrlUq6lhyU7E=; b=uf1RgzYa1jurRkM4LRmh7M2nKi X/tNKnrMcl9U3XpmbQXaWzo+GtVk2elzKzG+FacPEffuVMPfQzBsi4GYPHTJfh4wa3q8SS4uYbr5w 38D7UiS497Wv+KxKTttiN6YWS9Gi2SXLmG5gfxG0GyTADF+EUp7qGoiC0pBINFIsW6SjWr0vTVAPz bH98GaqZTd6jGfDtZtFA8kexrzNPabyXJx9uekAdnvYdAWWixnZbkPqpObBteA5dPPAwxstxYIHMg yTrJZ6pR+o/+4FED01z3iFhYKVPZ/UXHDyQg9McHn3Bb9ptOo9OWt68bZ8HyFq8IR3vsDgSKTWFIH OItVOlXg==; Received: from i53875a1d.versanet.de ([83.135.90.29] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uDIRf-0007kz-JF; Fri, 09 May 2025 09:46:59 +0200 From: Heiko =?UTF-8?B?U3TDvGJuZXI=?= To: Krzysztof Kozlowski , Chaoyi Chen , Sandy Huang , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chaoyi Chen Cc: Dragan Simic , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] dt-bindings: display: rockchip: Convert cdn-dp-rockchip.txt to yaml Date: Fri, 09 May 2025 09:46:57 +0200 Message-ID: <1824349.VLH7GnMWUR@diego> In-Reply-To: <5a4f6229-1450-4c96-bfac-5257f66b2ddf@rock-chips.com> References: <20250509070247.868-1-kernel@airkyi.com> <5a4f6229-1450-4c96-bfac-5257f66b2ddf@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250509_004727_891923_CC633BCA X-CRM114-Status: GOOD ( 18.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Freitag, 9. Mai 2025, 09:34:47 Mitteleurop=C3=A4ische Sommerzeit schrieb= Chaoyi Chen: > Hi Krzysztof, >=20 > On 2025/5/9 15:11, Krzysztof Kozlowski wrote: > > On 09/05/2025 09:02, Chaoyi Chen wrote: > >> + > >> + clock-names: > >> + items: > >> + - const: core-clk > >> + - const: pclk > >> + - const: spdif > >> + - const: grf > >> + > >> + extcon: > >> + $ref: /schemas/types.yaml#/definitions/phandle-array > >> + description: > >> + Phandle to the extcon device providing the cable state for the = DP PHY. > >> + > >> + interrupts: > >> + maxItems: 1 > >> + > >> + phys: > >> + $ref: /schemas/types.yaml#/definitions/phandle-array > > Just phandle. If this is an array (but why?), you need maxItems for > > outer and inner dimensions. >=20 > I think it could be phandle or phandle-array. Since the RK3399 DP has=20 > two PHYs, if we put in two PHYs here, the driver will pick one PHY port=20 > that is already plugged into the DP for output. If we fill in only one=20 > PHY here, then output is only allowed on the corresponding PHY. >=20 > Will add restrictions and add more descriptions in v3. Just looked that up in the documentation. Only the rk3399 has used this controller at all so far. There is one cdn-dp controller on it, but two phys for the two type-c blocks on the soc. The controller can then select which one to drive. So yep, there are two phys. Heiko