linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Ryan Chen <ryan_chen@aspeedtech.com>,
	Joel Stanley <joel@jms.id.au>,
	 linux-arm-kernel@lists.infradead.org,
	linux-aspeed@lists.ozlabs.org,  linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/soc/aspeed: Add AST27XX SoC ID support
Date: Wed, 06 Aug 2025 10:45:25 +0930	[thread overview]
Message-ID: <182db4f2848dc7b8c110d45bb606e6219983c237.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20250805063957.1452653-1-ryan_chen@aspeedtech.com>

Hi Ryan,

Regarding the patch subject, can you please follow the patterns
established by other commits under drivers/soc ?

Separately, can we concentrate efforts on trying to get the platform
definition bits upstream for the AST2700? Arnd's recent newsoc PR adds
several new SoCs (as the tag name suggests), which is a helpful
reference:

https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git/log/?h=soc-newsoc-6.17

Cheers,

Andrew

On Tue, 2025-08-05 at 14:39 +0800, Ryan Chen wrote:
> Extend the ASPEED SoC info driver to support AST27XX silicon IDs.
> 
> Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com>
> ---
>  drivers/soc/aspeed/aspeed-socinfo.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/soc/aspeed/aspeed-socinfo.c b/drivers/soc/aspeed/aspeed-socinfo.c
> index 3f759121dc00..67e9ac3d08ec 100644
> --- a/drivers/soc/aspeed/aspeed-socinfo.c
> +++ b/drivers/soc/aspeed/aspeed-socinfo.c
> @@ -27,6 +27,10 @@ static struct {
>         { "AST2620", 0x05010203 },
>         { "AST2605", 0x05030103 },
>         { "AST2625", 0x05030403 },
> +       /* AST2700 */
> +       { "AST2750", 0x06000003 },
> +       { "AST2700", 0x06000103 },
> +       { "AST2720", 0x06000203 },
>  };
>  
>  static const char *siliconid_to_name(u32 siliconid)



  reply	other threads:[~2025-08-06  1:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-05  6:39 [PATCH] drivers/soc/aspeed: Add AST27XX SoC ID support Ryan Chen
2025-08-06  1:15 ` Andrew Jeffery [this message]
2025-08-06  2:54   ` Ryan Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=182db4f2848dc7b8c110d45bb606e6219983c237.camel@codeconstruct.com.au \
    --to=andrew@codeconstruct.com.au \
    --cc=joel@jms.id.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ryan_chen@aspeedtech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).