From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] ARM: dts: Turn on USB host vbus on rk3288-evb
Date: Wed, 30 Jul 2014 13:24:17 +0200 [thread overview]
Message-ID: <1836225.xQCoI7eRWl@diego> (raw)
In-Reply-To: <1406676273-20701-2-git-send-email-dianders@chromium.org>
Am Dienstag, 29. Juli 2014, 16:24:31 schrieb Doug Anderson:
> There is no phy driver that works on the Rockchip board for either USB
> host port yet. For now just hardcode the vbus signal to be on all the
> time which makes both the dwc2 host and the EHCI port work.
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
> ---
> arch/arm/boot/dts/rk3288-evb.dtsi | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi
> b/arch/arm/boot/dts/rk3288-evb.dtsi index 749e20d..efd625e 100644
> --- a/arch/arm/boot/dts/rk3288-evb.dtsi
> +++ b/arch/arm/boot/dts/rk3288-evb.dtsi
> @@ -35,6 +35,18 @@
> debounce-interval = <100>;
> };
> };
> +
> + /* This turns on vbus for both host0 (ehci) and host1 (dwc2) */
> + usb_host_vbus_regulator: usb-host-vbus-regulator {
> + compatible = "regulator-fixed";
> + enable-active-high;
> + gpio = <&gpio0 14 GPIO_ACTIVE_HIGH>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&usb_host_vbus>;
> + regulator-name = "usb-host-vbus";
> + regulator-always-on;
> + regulator-boot-on;
> + };
> };
It seems I have a slightly outdated schematics pdf for the evb ... and only
see the OTG vbus pin, on <&gpio0 12>, but am missing the whole host vbus.
Could you think about finding another name for the handle? For example, in my
incomplete evb-schematics the supply coming from the otg regulator is called
vcc50_usb and there should be something similar for the host supply, so I'd
like something like
vcc50_usbhost: usb-host-vbus-regulator { /* or whatever it gets called */
...
};
simply to keep with the supply names defined in the schematics - makes reading
easier.
Heiko
>
> &i2c0 {
> @@ -71,4 +83,10 @@
> rockchip,pins = <0 5 RK_FUNC_GPIO &pcfg_pull_up>;
> };
> };
> +
> + usb-host {
> + usb_host_vbus: usb-host-vbus {
> + rockchip,pins = <0 14 RK_FUNC_GPIO &pcfg_pull_none>;
> + };
> + };
> };
next prev parent reply other threads:[~2014-07-30 11:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-29 23:24 [PATCH 0/3] Enable EHCI port on rk3288-evb Doug Anderson
2014-07-29 23:24 ` [PATCH 1/3] ARM: dts: Turn on USB host vbus " Doug Anderson
2014-07-30 11:24 ` Heiko Stübner [this message]
2014-07-30 15:13 ` Doug Anderson
2014-07-30 18:24 ` Heiko Stübner
2014-07-30 19:54 ` Doug Anderson
2014-07-29 23:24 ` [PATCH 2/3] ARM: dts: add rk3288 ehci usb devices Doug Anderson
2014-07-30 16:07 ` Doug Anderson
2014-07-29 23:24 ` [PATCH 3/3] ARM: dts: Enable USB host0 (EHCI) on rk3288-evb Doug Anderson
2014-07-30 11:26 ` Heiko Stübner
2014-07-30 15:22 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1836225.xQCoI7eRWl@diego \
--to=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).