From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3974FC76196 for ; Tue, 28 Mar 2023 06:38:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Liex/dU9zN7NVJqD/oxyb+SXVjs1ZmLABKOMCYPpGJA=; b=bm6zfzUN9jWkta L0n82sDeIztq1khMv5sU1pZuo3AuBAmxN/9yTbKSfxBjAtJH4BYr7OrOfxWkvl3bUZgfT4pZuovqI qLE/fW+SB+vC7itCu1cjNqXUomPkDWU5JyLREYMIKYh7n9lzmC+DL+BvNTe/0QMl9+Emopj+QTbea 3/btjh4v6fFhMBE9zm3C9D2TJuzuTla7zIi04rXb50ivHJeZPOw7aHDsfHGYWK4/Vfl4QiQvm3Cyq YvFGTTldKA+x5ELwf8LO6bOemScH0NYLIyB3GEerOCk+ATckgaz3XF9CdA1E+lGyQgPMCIlHUSYdA 3KeX/dMiO1T0pu+sbTMw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1ph2x2-00DKhA-32; Tue, 28 Mar 2023 06:37:00 +0000 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1ph2wz-00DKgV-2l for linux-arm-kernel@lists.infradead.org; Tue, 28 Mar 2023 06:36:59 +0000 Received: by mail-ed1-x535.google.com with SMTP id eh3so45225417edb.11 for ; Mon, 27 Mar 2023 23:36:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679985413; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rg7ln0vtWUz2rX09aiXxcm/NmjbrwQwhmjlO2+xf65c=; b=bJFuoeYvos6lpzBKhbZ13koLXy0NZysEjyNZje4vCdC0hEor+K56w5X94AhomyWBPK +arik7s1GIUOE4i3bp1dViZXfhYiDWje5wDy+VguF6ZE4b6165vuScAkj9h3qnYy50uo +e71NUyCldyEvdC6VjA2F+HGlimCffcz4hiCpLRJMXwHIkuZM2tmuPRNuXiO4zleFvhN kGg4okFvG6lc4W/timUsjP3mJxDN5pwaqqC0LyshnJHCMvuMXvMk5RzW1lrcsArnX9kw 4EBXz+ExSJDKrEx10Q1rYaDxrVpXcbRtamA466QBSihz1LtVDDuue1qLjHIRcNKxav84 7ysA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679985413; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rg7ln0vtWUz2rX09aiXxcm/NmjbrwQwhmjlO2+xf65c=; b=2YRR0NmHwUxpuooFxN0IQLnyB1sBLYS3jYONnDu3mF/blvntK7nsO7ZvNN8C6KYe1k 7Iy8hiweeJ8D+9oVSFmuYsCgIlKuAntdM/1Nvzi3ZOzD/6BfiHqct8yC3daZCjF8HSf4 nXId4VCzE7SJEgMeDsT07GpfO9u9bPXjsinnAkmI11ZA0eav+vjM8Cm1T8QXL1AeV4sC 3XsfdoJ416+uDCRFAL9cySF13YU9K47fBas/8rRBHS60EqL9h9f9DPqYeFWlBC47jZaN S+fts90TDDk6KAOahmwNCJ7YN/fZCjG6A4ToR/EnfurPGrVcxhAOKqhJ7SUVILJZYtgn jL3g== X-Gm-Message-State: AAQBX9fbdFYm0/vXyC5F6UKD1gV7fql1H4a6J4osfJxBsB4KJQtvBUZ+ AfLwtFwdnfLO7WaBKG8wKsu/8A== X-Google-Smtp-Source: AKy350YR4kjr4yCk8UnUPhlJWSjLT1aUW1CZ0zwUJkBhu0R6dQMskjbM2t0Zl3BjeL+CDVqDOR++FA== X-Received: by 2002:a17:906:d78f:b0:932:40f4:5c49 with SMTP id pj15-20020a170906d78f00b0093240f45c49mr15253200ejb.67.1679985413260; Mon, 27 Mar 2023 23:36:53 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:9e92:dca6:241d:71b6? ([2a02:810d:15c0:828:9e92:dca6:241d:71b6]) by smtp.gmail.com with ESMTPSA id r5-20020a1709064d0500b00923f05b2931sm14868672eju.118.2023.03.27.23.36.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Mar 2023 23:36:52 -0700 (PDT) Message-ID: <1838b760-c911-cb0a-184e-150df2f86c3b@linaro.org> Date: Tue, 28 Mar 2023 08:36:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 1/2] dt-bindings: firmware: arm,scmi: Support mailboxes unidirectional channels Content-Language: en-US To: Cristian Marussi Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, sudeep.holla@arm.com, vincent.guittot@linaro.org, souvik.chakravarty@arm.com, nicola.mazzucato@arm.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org References: <20230327140342.222168-1-cristian.marussi@arm.com> <20230327140342.222168-2-cristian.marussi@arm.com> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230327_233657_896930_3B046444 X-CRM114-Status: GOOD ( 13.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 27/03/2023 17:27, Cristian Marussi wrote: >>> + - | >>> + firmware { >>> + scmi { >>> + compatible = "arm,scmi"; >>> + mboxes = <&mhu_U_tx 0 0>, <&mhu_U_rx 0 0>; >>> + shmem = <&cpu_scp_lpri0>; >>> + >>> + #address-cells = <1>; >>> + #size-cells = <0>; >> >> I don't think adding one more example with difference in only one piece >> is needed here. >> > > Mmm, I thought was sensible to add this example, given that a mailbox > transport configuration for a mailbox exposing unidrectional channels is > quite different from the usual bidirectional channel config already > present in the pre-existent example. > > I'll add mbox-names into this example and see if I can change your > mind...or I can then finally drop it. And what exactly this one more example changes? Does not validate different parts of the binding if only one property differs... Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel