From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27914C636CC for ; Tue, 31 Jan 2023 12:15:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/JoIVg7ro1cDNNCvqcnQ8XuhzkGrpN/hqYp18bzRMOU=; b=j+u6zCS/RtzStF C3G0gImkHku51W/Xu5jZot64+y6j2+UDP5xg10KvXVQKeQADdG4lsOzU43Q53UnEVEDnKxjQZlGCi 67YhOewdHdjy7x2smF1BbNzJ3ytPxZsT1cHtj28lKwXhf9czT8Jbrx0VaOVzFIwWAFXgx3yoBM6sb gISi2HpngRtPWx2KrBY7AgqjYWy8uQ+w8XsrLiz3FQrmVUMbkROXlK10tSNEO9VdHt347SllSI9+w xJvo3xC4mKJHBSHgFhLnaXnYjCSdriGrmEQLza2F9TeXF4uBzOlYg/+ZEkziFxQBh2AZpxchELxFD WRhw8o3wPyvYPWtSNIqQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMpWg-007qJC-Au; Tue, 31 Jan 2023 12:14:14 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMpWb-007qI8-W6 for linux-arm-kernel@lists.infradead.org; Tue, 31 Jan 2023 12:14:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1675167250; x=1706703250; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=SrQW494zQd/xOVGrIEuwYC9iCR7cZ/BHB1SKMWvGKo4=; b=m83ZJFBTcfEtWkD9mvnDgWVyIhPEiUtQE0tQS5btF1h/l7pnFaSU9lK9 m2yis3nIDjXTlrfBvz1rZv7dWtIJM0GBOt8GAXjXd/VfB4qrSrrJPfmd4 CuN3sDX2RioEFCtso/KpvLuloXyB1e+xdPepQovXdD4ab2wY38gadV3BS iJFgUvqbKLLvK0qtcul9uhFJGH1uA95PfKD9b1cO+OYA/GYTlojsFWMpJ OzTDe3P9mVFB3ypfgM3GXav839yA/UXO7271NMFYog7k7WeAn6HZOgy8Q X/+WOEUZ/4Y9Jaln5qgBu0TEt7+Zx62ZhOfw1GIf0PymGdQX1/JkPj7CZ w==; X-IronPort-AV: E=Sophos;i="5.97,261,1669071600"; d="scan'208";a="28770401" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 31 Jan 2023 13:14:04 +0100 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Tue, 31 Jan 2023 13:14:04 +0100 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Tue, 31 Jan 2023 13:14:04 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1675167244; x=1706703244; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=SrQW494zQd/xOVGrIEuwYC9iCR7cZ/BHB1SKMWvGKo4=; b=nDIFRpmEPdBbZxpUq0OHFzfX3uz16A0pnHMyI+/4h/melqT6Q+abOF3v laxhRb0HDDQnBReqhfVKgTfGSEcVXdnHbaEAyDxqN16yewHRp+h2/plCd Cr2vHTGlgT5yIL+/EhxEuxOuOHXEXtCIJ3WwL5rcPcKcr6putdWokZYOG STvN6zyteEkaGCGRAFk5SdhlU1Y1cS01vFMl805DiFJY9vuRG2l3l1Oya Pd6V3mPTO+CO0+WdrwvL6s8fz9EFf32Y02uSfvIRTAL0CWkeeFh6wKqdu CzVNTMG2SgzK2KMeZ8zJnaog5XRoPy+1dPOSAheBTbnnzaEy49VL39MEN g==; X-IronPort-AV: E=Sophos;i="5.97,261,1669071600"; d="scan'208";a="28770400" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 31 Jan 2023 13:14:03 +0100 Received: from steina-w.localnet (unknown [10.123.53.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 9AEFD280056; Tue, 31 Jan 2023 13:14:03 +0100 (CET) From: Alexander Stein To: Marco Felsch Cc: Cai Huoqing , Haibo Chen , Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Fabio Estevam , devicetree@vger.kernel.org, linux-iio@vger.kernel.org, NXP Linux Team , Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/1] dt-bindings: iio: adc: add missing vref-supply Date: Tue, 31 Jan 2023 13:14:00 +0100 Message-ID: <1850476.tdWV9SEqCh@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20230131104816.w5sfpcdjulr2ogze@pengutronix.de> References: <20230131101323.606931-1-alexander.stein@ew.tq-group.com> <20230131104816.w5sfpcdjulr2ogze@pengutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230131_041410_365704_5C162F6E X-CRM114-Status: GOOD ( 23.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marco, thanks for the feedback. Am Dienstag, 31. Januar 2023, 11:48:16 CET schrieb Marco Felsch: > Hi Alexander, > > On 23-01-31, Alexander Stein wrote: > > Although this property is used right now for IIO_CHAN_INFO_SCALE, > > this ADC has two internal reference voltages, which the driver currently > > doesn't make use of. > > > > Fixes: db73419d8c06 ("dt-bindings: iio: adc: Add binding documentation for > > NXP IMX8QXP ADC") Signed-off-by: Alexander Stein > > > > --- > > > > .../devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml > > b/Documentation/devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml index > > 63369ba388e4..879768af0303 100644 > > --- a/Documentation/devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml > > +++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml > > > > @@ -39,6 +39,9 @@ properties: > > power-domains: > > maxItems: 1 > > > > + vref-supply: > > + description: External ADC reference voltage supply on VREFH pad. > > Please add it to the list of required properties, we can remove it as > soon as the driver has support for the internal reference voltages. I was thinking in doing so before as well. But DT describes the hardware, and this ADC apparently would be functioning without a reference voltage on that pad, using a different one. What the driver actual does is a different matter. Best regards, Alexander > Regards, > Marco > > > + > > > > "#io-channel-cells": > > const: 1 > > > > @@ -72,6 +75,7 @@ examples: > > assigned-clocks = <&clk IMX_SC_R_ADC_0>; > > assigned-clock-rates = <24000000>; > > power-domains = <&pd IMX_SC_R_ADC_0>; > > > > + vref-supply = <®_1v8>; > > > > #io-channel-cells = <1>; > > > > }; > > > > }; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel