From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B41FFEE57DF for ; Mon, 11 Sep 2023 15:05:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AwnmpUn8Fhh0rdcGzskBDeC6ziqm4dmnmfAMmYApRGo=; b=H0fmDd5GnMaPxZ dNEmu8cfc+WUWsNUkNyVGVNI/oHx/DdqvqtAA/8nSMUKsGWloBxxec7X7uPs4ViBmSgxCFGv9/63x Yr+RA1rf8P/DPhKTyK28lLINQ5Yd98xsEgI8ctYI+mqBj2p2UPzyRBbmuIXBSAkZYg3AYh9G/ARNl 3ThS4CeUx8mmMtYLyiLMOHchsmD3evvjE6o4Xjav2w8eyqW1Y7dFdIsFuDB3KN2MTbCmMvtOfzwf/ C1HYIBoY+xkoOfZezP+iUzBIoqDuMoLTERN2tHpps90AqrdZ4P+TSBaJI4FklItysko5gAmluzvCw k1ebL/y58tnhNeSmsN5A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qfiSv-000oJT-2F; Mon, 11 Sep 2023 15:04:41 +0000 Received: from mail-lj1-x235.google.com ([2a00:1450:4864:20::235]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qfiSs-000oHZ-0A for linux-arm-kernel@lists.infradead.org; Mon, 11 Sep 2023 15:04:39 +0000 Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2b703a0453fso77072261fa.3 for ; Mon, 11 Sep 2023 08:04:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694444674; x=1695049474; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ODyJnPcImRel5P1Ykm7VeqTt2o5yZaj1e00zNOQ+VYI=; b=L25gQDMDfChUbD+a2dtoqrJDBMkrciSOLQXU/YpijEU+kr6bauOdirahy+bPv22iHX eutkDWFWOLpGFINgxm0B2jrotC2fyU2daAcJx3ERTeced7IQQs8Ci++KMUlSwMxUmQFk X8pBt8EOlbrKDG2XiYFAOw4KyWbfta/Fx6TS41tDMBJjBokIPHdlN8nr9lb/tJYue2LQ V4r955d+vX5jwrV0kZQwRRK76dRJyowrrL3w3oUh0krPtK1egOOnV/M1V98LlxJv6HVh 0pwXR8RG5+CFXfktiWvgB8WdeymmhjCUUXWf8DjewZl3tftMvxiYiJp71JSOs8wZC8fp 56Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694444674; x=1695049474; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ODyJnPcImRel5P1Ykm7VeqTt2o5yZaj1e00zNOQ+VYI=; b=ptZ6tJQuQC43FpC3BQyY97B0QvQuXCvhBednsoGL76RQ5U1IqhxcRmz10wh7k8YlQV SSOmBuRp1Tm8nQJEdRUzsndN4Vi1CT+RYZmsG7y1kf8D66QCmMmiPRAu+PKuGa/VFrOQ +ftYf8aSNBQ39xW5Yq+XaXxxSuPeztBV+04kH6KxL+8LQelYp68hDQ1guDOQ3NwLFG/B 4L2oNvdtzlCXPrBQ+F3L796jZdc+Zgavuj3vd8NU4ZDs25EHa0gRQbN/C7Jjd+c/9hup N91w0gjptuW/yjJjLnoREvbTxdZkaCeHuakhXJE8NH3/aq5typwgJ05fwFWHwmkgb27G qf+g== X-Gm-Message-State: AOJu0Yy4GmlnLt/LntoALML/usCqpJ+DQRloVcNwOJ97NdB0ZdEnKIzq 1d/vwqTVdrSDZrXHQls7bGj00b0yNHU9Xg== X-Google-Smtp-Source: AGHT+IF9ImvK5dW/GQLmY/Bl6WL9W44EGZzNuF3w6dcH5dzQKdEZgs4EZk2VmEgketwPJBzPBOxNDQ== X-Received: by 2002:a2e:9609:0:b0:2bc:fd50:573a with SMTP id v9-20020a2e9609000000b002bcfd50573amr8796822ljh.6.1694444674200; Mon, 11 Sep 2023 08:04:34 -0700 (PDT) Received: from jernej-laptop.localnet (82-149-12-148.dynamic.telemach.net. [82.149.12.148]) by smtp.gmail.com with ESMTPSA id z19-20020a170906715300b00992e14af9b9sm5426153ejj.134.2023.09.11.08.04.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Sep 2023 08:04:33 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: longqi , Andre Przywara Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Samuel Holland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/Allwinner sunXi SoC support" , "open list:ARM/Allwinner sunXi SoC support" , open list Subject: Re: [PATCH] fixes the pin settings of two LEDs on board nanopi neo plus2 Date: Mon, 11 Sep 2023 17:04:34 +0200 Message-ID: <1862064.tdWV9SEqCh@jernej-laptop> In-Reply-To: <20230911155418.330e2334@donnerap.manchester.arm.com> References: <20230911140959.2046340-1-longqi90@gmail.com> <20230911155418.330e2334@donnerap.manchester.arm.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230911_080438_086611_43DB711C X-CRM114-Status: GOOD ( 23.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne ponedeljek, 11. september 2023 ob 16:54:18 CEST je Andre Przywara napisal(a): > On Mon, 11 Sep 2023 22:09:59 +0800 > longqi wrote: > > Hi, > > please add a few lines here saying why you fix this: it looks like the red > LED wasn't working at all, because of the wrong GPIO, and the colours were > actually swapped? This would be good to know for everyone reading this > patch. Additionally, add "Fixes" tag, since it's a bug in DT. In any case, go through https://www.kernel.org/doc/html/latest/process/submitting-patches.html so your patch will be correctly formatted. Best regards, Jernej > > In general this is a good catch, so thanks for sending this! > > More below: > > Signed-off-by: longqi > > --- > > > > .../boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts | 11 ++++++----- > > 1 file changed, 6 insertions(+), 5 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts > > b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts index > > 4c3921ac236c..0cb7a07ab1de 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts > > @@ -26,14 +26,15 @@ leds { > > > > compatible = "gpio-leds"; > > > > led-0 { > > > > - label = "nanopi:green:pwr"; > > - gpios = <&r_pio 0 10 GPIO_ACTIVE_HIGH>; > > - default-state = "on"; > > + label = "nanopi:red:pwr"; > > label is now a deprecated property. That's fine for existing DTs, but I > guess touching this node means you should update this, by using "function" > and "color", as described in: > Documentation/devicetree/bindings/leds/common.yaml > > > + gpios = <&r_pio 0 10 GPIO_ACTIVE_HIGH>; /* PL10 */ > > + linux,default-trigger = "default-on"; > > > > }; > > > > led-1 { > > > > - label = "nanopi:red:status"; > > - gpios = <&pio 0 20 GPIO_ACTIVE_HIGH>; > > + label = "nanopi:green:status"; > > Same thing with label here, please use "function" and "color". > > > + gpios = <&pio 0 10 GPIO_ACTIVE_HIGH>; /* PA10 */ > > + linux,default-trigger = "heartbeat"; > > I don't think we assign default triggers for LED merely labelled "status", > as people might have different use cases for this. For instance I'd find > a USB or eMMC trigger more useful. So you can just drop that line. > > Cheers, > Andre _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel